Add warning to //flutter/graphics

iskakaushik · iskakaushik · commit deeb293d2c26 · 2020-11-05T09:57:20.000-08:00
diff --git a/graphics/BUILD.gn b/graphics/BUILD.gn
@@ -15,11 +15,16 @@ source_set("graphics") {
     "texture.h",
   ]
 
+  # Heed caution when adding targets to the dependencies. This is a minimal
+  # target containing graphics sources that embedders can depend on. Any
+  # additions here could result in added app sizes across embeddings.
   deps = [
     "//flutter/assets",
     "//flutter/fml",
     "//flutter/shell/version:version",
     "//third_party/rapidjson",
     "//third_party/skia",
   ]
+
+  public_configs = [ "//flutter:config" ]
 }

Original file line number	Diff line number	Diff line change
`@@ -15,11 +15,16 @@ source_set("graphics") {`
`15`	`15`	`"texture.h",`
`16`	`16`	`]`
`17`	`17`
	`18`	`+ # Heed caution when adding targets to the dependencies. This is a minimal`
	`19`	`+ # target containing graphics sources that embedders can depend on. Any`
	`20`	`+ # additions here could result in added app sizes across embeddings.`
`18`	`21`	`deps = [`
`19`	`22`	`"//flutter/assets",`
`20`	`23`	`"//flutter/fml",`
`21`	`24`	`"//flutter/shell/version:version",`
`22`	`25`	`"//third_party/rapidjson",`
`23`	`26`	`"//third_party/skia",`
`24`	`27`	`]`
	`28`	`+`
	`29`	`+ public_configs = [ "//flutter:config" ]`
`25`	`30`	`}`