replace factory with top-level function

Author: yjbanov

lib/web_ui/lib/src/engine/canvaskit/canvaskit_api.dart

@@ -3392,7 +3392,7 @@ abstract class Collector {
 class ProductionCollector implements Collector {
   ProductionCollector() {
     _skObjectFinalizationRegistry =
-        SkObjectFinalizationRegistry((SkDeletable deletable) {
+        createSkObjectFinalizationRegistry((SkDeletable deletable) {
       // This is called when GC decides to collect the wrapper object and
       // notify us, which may happen after the object is already deleted
       // explicitly, e.g. when its ref count drops to zero. When that happens
@@ -3568,13 +3568,13 @@ extension JsConstructorExtension on JsConstructor {
 /// 6. We call `delete` on SkPaint.
 @JS('window.FinalizationRegistry')
 @staticInterop
-class SkObjectFinalizationRegistry {
-  factory SkObjectFinalizationRegistry(JSFunction cleanup) {
-    return js_util.callConstructor(
-      _finalizationRegistryConstructor!.toObjectShallow,
-      <Object>[cleanup],
-    );
-  }
+class SkObjectFinalizationRegistry {}
+
+SkObjectFinalizationRegistry createSkObjectFinalizationRegistry(JSFunction cleanup) {
+  return js_util.callConstructor(
+    _finalizationRegistryConstructor!.toObjectShallow,
+    <Object>[cleanup],
+  );
 }
 
 extension SkObjectFinalizationRegistryExtension on SkObjectFinalizationRegistry {

lib/web_ui/lib/src/engine/canvaskit/native_memory.dart

@@ -11,7 +11,7 @@ import 'canvaskit_api.dart';
 
 /// Collects native objects that weren't explicitly disposed of using
 /// [UniqueRef.dispose] or [CountedRef.unref].
-SkObjectFinalizationRegistry _finalizationRegistry = SkObjectFinalizationRegistry(
+SkObjectFinalizationRegistry _finalizationRegistry = createSkObjectFinalizationRegistry(
   (UniqueRef<Object> uniq) {
     uniq.collect();
   }.toJS

lib/web_ui/test/canvaskit/canvaskit_api_test.dart

@@ -1900,7 +1900,7 @@ void _paragraphTests() {
     // FinalizationRegistry because it depends on GC, which cannot be controlled,
     // So the test simply tests that a FinalizationRegistry can be constructed
     // and its `register` method can be called.
-    final SkObjectFinalizationRegistry registry = SkObjectFinalizationRegistry((String arg) {}.toJS);
+    final SkObjectFinalizationRegistry registry = createSkObjectFinalizationRegistry((String arg) {}.toJS);
     registry.register(Object(), Object());
   });
 }