Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d6b75b7

Browse files
authored
Remove superfluous INFO logs from //flutter/runtime. (#16280)
These add no value to engine developers anymore and are not visible to external users because of the low log severity.
1 parent 804dca6 commit d6b75b7

File tree

3 files changed

+0
-22
lines changed

3 files changed

+0
-22
lines changed

runtime/dart_isolate.cc

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,6 @@ bool DartIsolate::Run(const std::string& entrypoint_name,
508508
}
509509

510510
phase_ = Phase::Running;
511-
FML_DLOG(INFO) << "New isolate is in the running state.";
512511

513512
if (on_run) {
514513
on_run();
@@ -540,7 +539,6 @@ bool DartIsolate::RunFromLibrary(const std::string& library_name,
540539
}
541540

542541
phase_ = Phase::Running;
543-
FML_DLOG(INFO) << "New isolate is in the running state.";
544542

545543
if (on_run) {
546544
on_run();
@@ -588,7 +586,6 @@ Dart_Isolate DartIsolate::DartCreateAndStartServiceIsolate(
588586
const auto& settings = vm_data->GetSettings();
589587

590588
if (!settings.enable_observatory) {
591-
FML_DLOG(INFO) << "Observatory is disabled.";
592589
return nullptr;
593590
}
594591

@@ -834,19 +831,13 @@ void DartIsolate::DartIsolateShutdownCallback(
834831
std::shared_ptr<DartIsolateGroupData>* isolate_group_data,
835832
std::shared_ptr<DartIsolate>* isolate_data) {
836833
TRACE_EVENT0("flutter", "DartIsolate::DartIsolateShutdownCallback");
837-
FML_DLOG(INFO) << "DartIsolateShutdownCallback"
838-
<< " isolate_group_data " << isolate_group_data
839-
<< " isolate_data " << isolate_data;
840834
isolate_data->get()->OnShutdownCallback();
841835
}
842836

843837
// |Dart_IsolateGroupCleanupCallback|
844838
void DartIsolate::DartIsolateGroupCleanupCallback(
845839
std::shared_ptr<DartIsolateGroupData>* isolate_data) {
846840
TRACE_EVENT0("flutter", "DartIsolate::DartIsolateGroupCleanupCallback");
847-
FML_DLOG(INFO) << "DartIsolateGroupCleanupCallback isolate_data "
848-
<< isolate_data;
849-
850841
delete isolate_data;
851842
}
852843

@@ -855,9 +846,6 @@ void DartIsolate::DartIsolateCleanupCallback(
855846
std::shared_ptr<DartIsolateGroupData>* isolate_group_data,
856847
std::shared_ptr<DartIsolate>* isolate_data) {
857848
TRACE_EVENT0("flutter", "DartIsolate::DartIsolateCleanupCallback");
858-
859-
FML_DLOG(INFO) << "DartIsolateCleanupCallback cleaned up isolate_data "
860-
<< isolate_data;
861849
delete isolate_data;
862850
}
863851

runtime/dart_isolate_unittests.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ class AutoIsolateShutdown {
111111
fml::AutoResetWaitableEvent latch;
112112
fml::TaskRunner::RunNowOrPostTask(
113113
runner_, [isolate = std::move(isolate_), &latch]() {
114-
FML_LOG(INFO) << "Shutting down isolate.";
115114
if (!isolate->Shutdown()) {
116115
FML_LOG(ERROR) << "Could not shutdown isolate.";
117116
FML_CHECK(false);

runtime/dart_vm.cc

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -282,9 +282,6 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
282282
FML_DCHECK(isolate_name_server_);
283283
FML_DCHECK(service_protocol_);
284284

285-
FML_DLOG(INFO) << "Attempting Dart VM launch for mode: "
286-
<< (IsRunningPrecompiledCode() ? "AOT" : "Interpreter");
287-
288285
{
289286
TRACE_EVENT0("flutter", "dart::bin::BootstrapDartIo");
290287
dart::bin::BootstrapDartIo();
@@ -456,9 +453,6 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
456453
Dart_SetDartLibrarySourcesKernel(dart_library_sources->GetMapping(),
457454
dart_library_sources->GetSize());
458455
}
459-
460-
FML_DLOG(INFO) << "New Dart VM instance created. Instance count: "
461-
<< gVMLaunchCount;
462456
}
463457

464458
DartVM::~DartVM() {
@@ -478,9 +472,6 @@ DartVM::~DartVM() {
478472
<< "Could not cleanly shut down the Dart VM. Error: \"" << result
479473
<< "\".";
480474
free(result);
481-
482-
FML_DLOG(INFO) << "Dart VM instance destroyed. Instance count: "
483-
<< gVMLaunchCount;
484475
}
485476

486477
std::shared_ptr<const DartVMData> DartVM::GetVMData() const {

0 commit comments

Comments
 (0)