moved the golden test runner to the profile build

Author: gaaclarke

ci/builders/mac_host_engine.json

@@ -143,12 +143,6 @@
                 "cpu=x86",
                 "mac_model=Macmini8,1"
             ],
-            "dependencies": [
-                {
-                    "dependency": "goldctl",
-                    "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
-                }
-            ],
             "gclient_variables": {
                 "download_android_deps": false
             },
@@ -169,7 +163,6 @@
                     "flutter/build/archives:archive_gen_snapshot",
                     "flutter/build/archives:artifacts",
                     "flutter/build/dart:copy_dart_sdk",
-                    "flutter/impeller/golden_tests:impeller_golden_tests",
                     "flutter/shell/platform/darwin/macos:zip_macos_flutter_framework",
                     "flutter/tools/font_subset",
                     "flutter:unittests"
@@ -183,13 +176,13 @@
             "tests": [
                 {
                     "language": "python3",
-                    "name": "Impeller-golden, dart and engine tests for host_release",
+                    "name": "dart and engine tests for host_release",
                     "script": "flutter/testing/run_tests.py",
                     "parameters": [
                         "--variant",
                         "host_release",
                         "--type",
-                        "dart,dart-host,engine,impeller-golden"
+                        "dart,dart-host,engine"
                     ]
                 }
             ]
@@ -259,6 +252,12 @@
                 "os=Mac-13",
                 "cpu=x86"
             ],
+            "dependencies": [
+                {
+                    "dependency": "goldctl",
+                    "version": "git_revision:720a542f6fe4f92922c3b8f0fdcc4d2ac6bb83cd"
+                }
+            ],
             "gclient_variables": {
                 "download_android_deps": false
             },
@@ -269,21 +268,38 @@
                 "--runtime-mode",
                 "profile",
                 "--no-lto",
-                "--prebuilt-dart-sdk"
+                "--prebuilt-dart-sdk",
+                "--enable-impeller-vulkan",
+                "--enable-impeller-opengles",
+                "--use-glfw-swiftshader"
             ],
             "name": "mac_profile_arm64",
             "ninja": {
                 "config": "mac_profile_arm64",
                 "targets": [
                     "flutter/build/archives:artifacts",
+                    "flutter/impeller/golden_tests:impeller_golden_tests",
                     "flutter/shell/platform/darwin/macos:zip_macos_flutter_framework"
                 ]
             },
             "properties": {
                 "$flutter/osx_sdk": {
                     "sdk_version": "15a240d"
                 }
-            }
+            },
+            "tests": [
+                {
+                    "language": "python3",
+                    "name": "Impeller-golden",
+                    "script": "flutter/testing/run_tests.py",
+                    "parameters": [
+                        "--variant",
+                        "host_profile",
+                        "--type",
+                        "impeller-golden"
+                    ]
+                }
+            ]
         },
         {
             "archives": [

impeller/tools/impeller.gni

@@ -54,8 +54,6 @@ declare_args() {
 }
 
 declare_args() {
-  impeller_enable_validation = impeller_debug
-
   # Wether to build and include the validation layers.
   impeller_enable_vulkan_validation_layers =
       impeller_enable_vulkan && flutter_runtime_mode == "debug" &&