Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit d3500e1

Browse files
authored
[Impeller] fixed CanRenderClippedRuntimeEffects for vulkan (#49912)
fixes flutter/flutter#141891 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent d87e742 commit d3500e1

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

impeller/aiks/aiks_unittests.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2742,7 +2742,8 @@ TEST_P(AiksTest, CanRenderClippedRuntimeEffects) {
27422742

27432743
TEST_P(AiksTest, DrawPaintTransformsBounds) {
27442744
auto runtime_stages = OpenAssetAsRuntimeStage("gradient.frag.iplr");
2745-
auto runtime_stage = runtime_stages[RuntimeStageBackend::kMetal];
2745+
auto runtime_stage =
2746+
runtime_stages[PlaygroundBackendToRuntimeStageBackend(GetBackend())];
27462747
ASSERT_TRUE(runtime_stage);
27472748
ASSERT_TRUE(runtime_stage->IsDirty());
27482749

impeller/golden_tests/golden_playground_test_mac.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -58,9 +58,6 @@ static const std::vector<std::string> kSkipTests = {
5858
"impeller_Play_AiksTest_CanRenderClippedRuntimeEffects_Vulkan",
5959
"impeller_Play_AiksTest_CaptureContext_Metal",
6060
"impeller_Play_AiksTest_CaptureContext_Vulkan",
61-
// TODO(https://github.com/flutter/flutter/issues/141891): This tests
62-
// crashes on vulkan and needs to be fixed.
63-
"impeller_Play_AiksTest_DrawPaintTransformsBounds_Vulkan",
6461
};
6562

6663
namespace {

0 commit comments

Comments
 (0)