Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c41f2e5

Browse files
khushalsagarCommit Bot
authored andcommitted
Disable UniformBufferTests on Windows 7 / D3D11 / NVIDIA.
Bug: chromium:1037644 Change-Id: Ic8bf76bb0c1b8bdcf36f6af5a8d91ac815334917 Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/1981070 Commit-Queue: Kenneth Russell <[email protected]> Reviewed-by: Shahbaz Youssefi <[email protected]> Reviewed-by: Kenneth Russell <[email protected]> Reviewed-by: Zhenyao Mo <[email protected]>
1 parent e2fc92c commit c41f2e5

File tree

1 file changed

+12
-0
lines changed

1 file changed

+12
-0
lines changed

src/tests/gl_tests/UniformBufferTest.cpp

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1636,6 +1636,9 @@ TEST_P(UniformBufferTest, LargeArrayOfStructs)
16361636
// member.
16371637
TEST_P(UniformBufferTest, UniformBlockWithOneLargeStructArray)
16381638
{
1639+
// TODO(crbug.com/1037644): Re-enable this test on this config.
1640+
ANGLE_SKIP_TEST_IF(IsWindows7() && IsNVIDIA() && IsD3D11());
1641+
16391642
GLint64 maxUniformBlockSize;
16401643
glGetInteger64v(GL_MAX_UNIFORM_BLOCK_SIZE, &maxUniformBlockSize);
16411644
std::ostringstream stream;
@@ -1748,6 +1751,9 @@ TEST_P(UniformBufferTest, UniformBlockWithOneLargeStructArray)
17481751
// a mat4 member and a float member.
17491752
TEST_P(UniformBufferTest, UniformBlockWithOneLargeMixStructArray)
17501753
{
1754+
// TODO(crbug.com/1037644): Re-enable this test on this config.
1755+
ANGLE_SKIP_TEST_IF(IsWindows7() && IsNVIDIA() && IsD3D11());
1756+
17511757
GLint64 maxUniformBlockSize;
17521758
glGetInteger64v(GL_MAX_UNIFORM_BLOCK_SIZE, &maxUniformBlockSize);
17531759
std::ostringstream stream;
@@ -1878,6 +1884,9 @@ TEST_P(UniformBufferTest, UniformBlockWithOneLargeMixStructArray)
18781884
// struct array member in the same program, and they share a uniform buffer.
18791885
TEST_P(UniformBufferTest, UniformBlocksInSameProgramShareUniformBuffer)
18801886
{
1887+
// TODO(crbug.com/1037644): Re-enable this test on this config.
1888+
ANGLE_SKIP_TEST_IF(IsWindows7() && IsNVIDIA() && IsD3D11());
1889+
18811890
GLint64 maxUniformBlockSize;
18821891
glGetInteger64v(GL_MAX_UNIFORM_BLOCK_SIZE, &maxUniformBlockSize);
18831892
std::ostringstream stream;
@@ -2007,6 +2016,9 @@ TEST_P(UniformBufferTest, UniformBlocksInSameProgramShareUniformBuffer)
20072016
// struct array member in the different programs, and they share a uniform buffer.
20082017
TEST_P(UniformBufferTest, UniformBlocksInDiffProgramShareUniformBuffer)
20092018
{
2019+
// TODO(crbug.com/1037644): Re-enable this test on this config.
2020+
ANGLE_SKIP_TEST_IF(IsWindows7() && IsNVIDIA() && IsD3D11());
2021+
20102022
GLint64 maxUniformBlockSize;
20112023
glGetInteger64v(GL_MAX_UNIFORM_BLOCK_SIZE, &maxUniformBlockSize);
20122024
std::ostringstream stream1;

0 commit comments

Comments
 (0)