Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit c279243

Browse files
committed
Rename
1 parent 0887aef commit c279243

File tree

6 files changed

+22
-25
lines changed

6 files changed

+22
-25
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1118,7 +1118,6 @@ FILE: ../../../flutter/lib/web_ui/lib/src/engine/initialization.dart
11181118
FILE: ../../../flutter/lib/web_ui/lib/src/engine/js_interop/js_loader.dart
11191119
FILE: ../../../flutter/lib/web_ui/lib/src/engine/js_interop/js_promise.dart
11201120
FILE: ../../../flutter/lib/web_ui/lib/src/engine/key_map.g.dart
1121-
FILE: ../../../flutter/lib/web_ui/lib/src/engine/keyboard.dart
11221121
FILE: ../../../flutter/lib/web_ui/lib/src/engine/keyboard_binding.dart
11231122
FILE: ../../../flutter/lib/web_ui/lib/src/engine/mouse_cursor.dart
11241123
FILE: ../../../flutter/lib/web_ui/lib/src/engine/navigation.dart
@@ -1136,6 +1135,7 @@ FILE: ../../../flutter/lib/web_ui/lib/src/engine/plugins.dart
11361135
FILE: ../../../flutter/lib/web_ui/lib/src/engine/pointer_binding.dart
11371136
FILE: ../../../flutter/lib/web_ui/lib/src/engine/pointer_converter.dart
11381137
FILE: ../../../flutter/lib/web_ui/lib/src/engine/profiler.dart
1138+
FILE: ../../../flutter/lib/web_ui/lib/src/engine/raw_keyboard.dart
11391139
FILE: ../../../flutter/lib/web_ui/lib/src/engine/rrect_renderer.dart
11401140
FILE: ../../../flutter/lib/web_ui/lib/src/engine/safe_browser_api.dart
11411141
FILE: ../../../flutter/lib/web_ui/lib/src/engine/semantics.dart

lib/web_ui/lib/src/engine.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,6 @@ export 'engine/initialization.dart';
104104
export 'engine/js_interop/js_loader.dart';
105105
export 'engine/js_interop/js_promise.dart';
106106
export 'engine/key_map.g.dart';
107-
export 'engine/keyboard.dart';
108107
export 'engine/keyboard_binding.dart';
109108
export 'engine/mouse_cursor.dart';
110109
export 'engine/navigation/history.dart';
@@ -121,6 +120,7 @@ export 'engine/plugins.dart';
121120
export 'engine/pointer_binding.dart';
122121
export 'engine/pointer_converter.dart';
123122
export 'engine/profiler.dart';
123+
export 'engine/raw_keyboard.dart';
124124
export 'engine/rrect_renderer.dart';
125125
export 'engine/safe_browser_api.dart';
126126
export 'engine/semantics/accessibility.dart';

lib/web_ui/lib/src/engine/keyboard_binding.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ import '../engine.dart' show registerHotRestartListener;
88
import 'browser_detection.dart';
99
import 'dom.dart';
1010
import 'key_map.g.dart';
11-
import 'keyboard.dart';
1211
import 'platform_dispatcher.dart';
12+
import 'raw_keyboard.dart';
1313
import 'safe_browser_api.dart';
1414
import 'semantics.dart';
1515

@@ -105,13 +105,13 @@ class KeyboardBinding {
105105

106106
KeyboardBinding._() {
107107
_converter = KeyboardConverter(_onKeyData, onMacOs: operatingSystem == OperatingSystem.macOs);
108-
_rawKeyboard = Keyboard(onMacOs: operatingSystem == OperatingSystem.macOs);
108+
_rawKeyboard = RawKeyboard(onMacOs: operatingSystem == OperatingSystem.macOs);
109109
_addEventListener('keydown', allowInterop(_handleDomEvent));
110110
_addEventListener('keyup', allowInterop(_handleDomEvent));
111111
}
112112

113113
late final KeyboardConverter _converter;
114-
late final Keyboard _rawKeyboard;
114+
late final RawKeyboard _rawKeyboard;
115115
final Map<String, DomEventListener> _listeners = <String, DomEventListener>{};
116116

117117
void _handleDomEvent(DomEvent event) {

lib/web_ui/lib/src/engine/keyboard.dart renamed to lib/web_ui/lib/src/engine/raw_keyboard.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,16 @@ import 'platform_dispatcher.dart';
1010
import 'services.dart';
1111

1212
/// Provides keyboard bindings, such as the `flutter/keyevent` channel.
13-
class Keyboard {
14-
Keyboard({this.onMacOs = false});
13+
class RawKeyboard {
14+
RawKeyboard({this.onMacOs = false});
1515

1616
/// A mapping of [KeyboardEvent.code] to [Timer].
1717
///
1818
/// The timer is for when to synthesize a keyup for the [KeyboardEvent.code]
1919
/// if no repeat events were received.
2020
final Map<String, Timer> _keydownTimers = <String, Timer>{};
2121

22-
/// Uninitializes the [Keyboard] singleton.
22+
/// Uninitializes the [RawKeyboard] singleton.
2323
///
2424
/// After calling this method this object becomes unusable and [instance]
2525
/// becomes `null`. Call [initialize] again to initialize a new singleton.

lib/web_ui/test/canvaskit/initialization_services_vs_ui_test.dart

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ void testMain() {
1616
expect(windowFlutterCanvasKit, isNull);
1717

1818
expect(findGlassPane(), isNull);
19-
expect(Keyboard.instance, isNull);
2019
expect(MouseCursor.instance, isNull);
2120
expect(KeyboardBinding.instance, isNull);
2221
expect(PointerBinding.instance, isNull);
@@ -27,15 +26,13 @@ void testMain() {
2726
expect(windowFlutterCanvasKit, isNotNull);
2827

2928
expect(findGlassPane(), isNull);
30-
expect(Keyboard.instance, isNull);
3129
expect(MouseCursor.instance, isNull);
3230
expect(KeyboardBinding.instance, isNull);
3331
expect(PointerBinding.instance, isNull);
3432

3533
// Now UI should be taken over by Flutter.
3634
await initializeEngineUi();
3735
expect(findGlassPane(), isNotNull);
38-
expect(Keyboard.instance, isNotNull);
3936
expect(MouseCursor.instance, isNotNull);
4037
expect(KeyboardBinding.instance, isNotNull);
4138
expect(PointerBinding.instance, isNotNull);

lib/web_ui/test/keyboard_test.dart renamed to lib/web_ui/test/raw_keyboard_test.dart

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import 'package:test/bootstrap/browser.dart';
1010
import 'package:test/test.dart';
1111
import 'package:ui/src/engine/browser_detection.dart';
1212
import 'package:ui/src/engine/dom.dart';
13-
import 'package:ui/src/engine/keyboard.dart';
13+
import 'package:ui/src/engine/raw_keyboard.dart';
1414
import 'package:ui/src/engine/services.dart';
1515
import 'package:ui/ui.dart' as ui;
1616

@@ -19,7 +19,7 @@ void main() {
1919
}
2020

2121
void testMain() {
22-
group('Keyboard', () {
22+
group('RawKeyboard', () {
2323
/// Used to save and restore [ui.window.onPlatformMessage] after each test.
2424
ui.PlatformMessageCallback? savedCallback;
2525

@@ -32,7 +32,7 @@ void testMain() {
3232
});
3333

3434
test('dispatches keyup to flutter/keyevent channel', () {
35-
final Keyboard keyboard = Keyboard();
35+
final RawKeyboard keyboard = RawKeyboard();
3636

3737
String? channelReceived;
3838
Map<String, dynamic>? dataReceived;
@@ -64,7 +64,7 @@ void testMain() {
6464
skip: browserEngine == BrowserEngine.edge);
6565

6666
test('dispatches keydown to flutter/keyevent channel', () {
67-
final Keyboard keyboard = Keyboard();
67+
final RawKeyboard keyboard = RawKeyboard();
6868

6969
String? channelReceived;
7070
Map<String, dynamic>? dataReceived;
@@ -97,7 +97,7 @@ void testMain() {
9797
skip: browserEngine == BrowserEngine.edge);
9898

9999
test('dispatches correct meta state', () {
100-
final Keyboard keyboard = Keyboard();
100+
final RawKeyboard keyboard = RawKeyboard();
101101

102102
Map<String, dynamic>? dataReceived;
103103
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -153,7 +153,7 @@ void testMain() {
153153
skip: browserEngine == BrowserEngine.edge);
154154

155155
test('dispatches repeat events', () {
156-
final Keyboard keyboard = Keyboard();
156+
final RawKeyboard keyboard = RawKeyboard();
157157

158158
final List<Map<String, dynamic>> messages = <Map<String, dynamic>>[];
159159
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -211,7 +211,7 @@ void testMain() {
211211
skip: browserEngine == BrowserEngine.edge);
212212

213213
test('prevents default when key is handled by the framework', () {
214-
final Keyboard keyboard = Keyboard();
214+
final RawKeyboard keyboard = RawKeyboard();
215215

216216
int count = 0;
217217
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -235,7 +235,7 @@ void testMain() {
235235
});
236236

237237
test("Doesn't prevent default when key is not handled by the framework", () {
238-
final Keyboard keyboard = Keyboard();
238+
final RawKeyboard keyboard = RawKeyboard();
239239

240240
int count = 0;
241241
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -268,7 +268,7 @@ void testMain() {
268268
//
269269
// There's no `keyup(i)`. The web engine is expected to synthesize a
270270
// `keyup(i)` event.
271-
final Keyboard keyboard = Keyboard(onMacOs: true);
271+
final RawKeyboard keyboard = RawKeyboard(onMacOs: true);
272272

273273
final List<Map<String, dynamic>> messages = <Map<String, dynamic>>[];
274274
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -396,7 +396,7 @@ void testMain() {
396396
testFakeAsync(
397397
'On macOS, do not synthesize keyup when we receive repeat events',
398398
(FakeAsync async) {
399-
final Keyboard keyboard = Keyboard(onMacOs: true);
399+
final RawKeyboard keyboard = RawKeyboard(onMacOs: true);
400400

401401
final List<Map<String, dynamic>> messages = <Map<String, dynamic>>[];
402402
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -484,7 +484,7 @@ void testMain() {
484484
testFakeAsync(
485485
'On macOS, do not synthesize keyup when keys are not affected by meta modifiers',
486486
(FakeAsync async) {
487-
final Keyboard keyboard = Keyboard();
487+
final RawKeyboard keyboard = RawKeyboard();
488488

489489
final List<Map<String, dynamic>> messages = <Map<String, dynamic>>[];
490490
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -516,7 +516,7 @@ void testMain() {
516516
);
517517

518518
testFakeAsync('On macOS, do not synthesize keyup for meta keys', (FakeAsync async) {
519-
final Keyboard keyboard = Keyboard(onMacOs: true);
519+
final RawKeyboard keyboard = RawKeyboard(onMacOs: true);
520520

521521
final List<Map<String, dynamic>> messages = <Map<String, dynamic>>[];
522522
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -584,7 +584,7 @@ void testMain() {
584584
testFakeAsync(
585585
'On non-macOS, do not synthesize keyup for shortcuts',
586586
(FakeAsync async) {
587-
final Keyboard keyboard = Keyboard(onMacOs: false);
587+
final RawKeyboard keyboard = RawKeyboard(onMacOs: false);
588588

589589
final List<Map<String, dynamic>> messages = <Map<String, dynamic>>[];
590590
ui.window.onPlatformMessage = (String channel, ByteData? data,
@@ -650,7 +650,7 @@ void testMain() {
650650
}
651651

652652
DomKeyboardEvent dispatchKeyboardEvent(
653-
Keyboard keyboard,
653+
RawKeyboard keyboard,
654654
String type, {
655655
String? key,
656656
String? code,

0 commit comments

Comments
 (0)