Version 2.14.0-112.0.dev

Merge commit '2f85591b67d12f8bbbaa5ad86ceefadc4c150371' into 'dev'

Author: Dart CI

CHANGELOG.md

@@ -132,7 +132,7 @@ Updated the Linter to `1.4.0`, which includes:
     }
     ```
 
-## 2.13.0
+## 2.13.0 - 2021-05-18
 
 ### Language
 

DEPS

@@ -710,20 +710,4 @@ hooks = [
     'action': ['python3', 'sdk/build/vs_toolchain.py', 'update'],
     'condition': 'checkout_win'
   },
-  {
-    "name": "7zip",
-    "pattern": ".",
-    "action": [
-      "download_from_google_storage",
-      "--no_auth",
-      "--no_resume",
-      "--bucket",
-      "dart-dependencies",
-      "--platform=win32",
-      "--extract",
-      "-s",
-      Var('dart_root') + "/third_party/7zip.tar.gz.sha1",
-    ],
-    'condition': 'checkout_win'
-  },
 ]

pkg/analyzer/lib/src/dart/analysis/experiments.g.dart

@@ -25,6 +25,7 @@ final _knownFeatures = <String, ExperimentalFeature>{
       ExperimentalFeatures.nonfunction_type_aliases,
   EnableString.set_literals: ExperimentalFeatures.set_literals,
   EnableString.spread_collections: ExperimentalFeatures.spread_collections,
+  EnableString.test_experiment: ExperimentalFeatures.test_experiment,
   EnableString.triple_shift: ExperimentalFeatures.triple_shift,
   EnableString.value_class: ExperimentalFeatures.value_class,
   EnableString.variance: ExperimentalFeatures.variance,
@@ -66,6 +67,9 @@ class EnableString {
   /// String to enable the experiment "spread-collections"
   static const String spread_collections = 'spread-collections';
 
+  /// String to enable the experiment "test-experiment"
+  static const String test_experiment = 'test-experiment';
+
   /// String to enable the experiment "triple-shift"
   static const String triple_shift = 'triple-shift';
 
@@ -190,8 +194,19 @@ class ExperimentalFeatures {
     releaseVersion: Version.parse('2.0.0'),
   );
 
-  static final triple_shift = ExperimentalFeature(
+  static final test_experiment = ExperimentalFeature(
     index: 11,
+    enableString: EnableString.test_experiment,
+    isEnabledByDefault: IsEnabledByDefault.test_experiment,
+    isExpired: IsExpired.test_experiment,
+    documentation:
+        'Has no effect. Can be used for testing the --enable-experiment command line functionality.',
+    experimentalReleaseVersion: null,
+    releaseVersion: null,
+  );
+
+  static final triple_shift = ExperimentalFeature(
+    index: 12,
     enableString: EnableString.triple_shift,
     isEnabledByDefault: IsEnabledByDefault.triple_shift,
     isExpired: IsExpired.triple_shift,
@@ -201,7 +216,7 @@ class ExperimentalFeatures {
   );
 
   static final value_class = ExperimentalFeature(
-    index: 12,
+    index: 13,
     enableString: EnableString.value_class,
     isEnabledByDefault: IsEnabledByDefault.value_class,
     isExpired: IsExpired.value_class,
@@ -211,7 +226,7 @@ class ExperimentalFeatures {
   );
 
   static final variance = ExperimentalFeature(
-    index: 13,
+    index: 14,
     enableString: EnableString.variance,
     isEnabledByDefault: IsEnabledByDefault.variance,
     isExpired: IsExpired.variance,
@@ -257,6 +272,9 @@ class IsEnabledByDefault {
   /// Default state of the experiment "spread-collections"
   static const bool spread_collections = true;
 
+  /// Default state of the experiment "test-experiment"
+  static const bool test_experiment = false;
+
   /// Default state of the experiment "triple-shift"
   static const bool triple_shift = true;
 
@@ -304,6 +322,9 @@ class IsExpired {
   /// Expiration status of the experiment "spread-collections"
   static const bool spread_collections = true;
 
+  /// Expiration status of the experiment "test-experiment"
+  static const bool test_experiment = false;
+
   /// Expiration status of the experiment "triple-shift"
   static const bool triple_shift = false;
 
@@ -354,6 +375,9 @@ mixin _CurrentState {
   bool get spread_collections =>
       isEnabled(ExperimentalFeatures.spread_collections);
 
+  /// Current state for the flag "test-experiment"
+  bool get test_experiment => isEnabled(ExperimentalFeatures.test_experiment);
+
   /// Current state for the flag "triple-shift"
   bool get triple_shift => isEnabled(ExperimentalFeatures.triple_shift);
 

pkg/analyzer/lib/src/dart/element/element.dart

@@ -6265,10 +6265,6 @@ class PrefixElementImpl extends _ExistingElementImpl implements PrefixElement {
   PrefixElementImpl(String name, int nameOffset, {Reference? reference})
       : super(name, nameOffset, reference: reference);
 
-  PrefixElementImpl.forLinkedNode(
-      ElementImpl enclosing, Reference reference, SimpleIdentifier linkedNode)
-      : super.forLinkedNode(enclosing, reference, linkedNode);
-
   @override
   String get displayName => name;
 
@@ -6281,20 +6277,9 @@ class PrefixElementImpl extends _ExistingElementImpl implements PrefixElement {
 
   @override
   String get name {
-    if (linkedNode != null) {
-      return reference!.name;
-    }
     return super.name!;
   }
 
-  @override
-  int get nameOffset {
-    if (linkedNode != null) {
-      return (linkedNode as SimpleIdentifier).offset;
-    }
-    return super.nameOffset;
-  }
-
   @override
   Scope get scope => _scope ??= PrefixScope(enclosingElement, this);
 

pkg/analyzer/lib/src/summary2/library_builder.dart

@@ -406,9 +406,7 @@ class _ElementBuilder extends ThrowingAstVisitor<void> {
   }
 
   @override
-  void visitExportDirective(ast.ExportDirective node) {
-    node as ast.ExportDirectiveImpl;
-
+  void visitExportDirective(covariant ast.ExportDirectiveImpl node) {
     var element = ExportElementImpl(node.keyword.offset);
     element.combinators = _buildCombinators(node.combinators);
     element.exportedLibrary = _selectLibrary(node);
@@ -420,9 +418,7 @@ class _ElementBuilder extends ThrowingAstVisitor<void> {
   }
 
   @override
-  void visitImportDirective(ast.ImportDirective node) {
-    node as ast.ImportDirectiveImpl;
-
+  void visitImportDirective(covariant ast.ImportDirectiveImpl node) {
     var element = ImportElementImpl(node.keyword.offset);
     element.combinators = _buildCombinators(node.combinators);
     element.importedLibrary = _selectLibrary(node);

pkg/compiler/lib/src/commandline_options.dart

@@ -79,6 +79,10 @@ class Flags {
   static const String noNativeNullAssertions = '--no-native-null-assertions';
 
   static const String noSourceMaps = '--no-source-maps';
+
+  static const String omitLateNames = '--omit-late-names';
+  static const String noOmitLateNames = '--no-omit-late-names';
+
   static const String preserveUris = '--preserve-uris';
   static const String printLegacyStars = '--debug-print-legacy-stars';
   static const String showPackageWarnings = '--show-package-warnings';

pkg/compiler/lib/src/dart2js.dart

@@ -512,6 +512,8 @@ Future<api.CompilationResult> compile(List<String> argv,
     new OptionHandler(Flags.initializingFormalAccess, ignoreOption),
     new OptionHandler(Flags.minify, passThrough),
     new OptionHandler(Flags.noMinify, passThrough),
+    new OptionHandler(Flags.omitLateNames, passThrough),
+    new OptionHandler(Flags.noOmitLateNames, passThrough),
     new OptionHandler(Flags.preserveUris, ignoreOption),
     new OptionHandler(Flags.printLegacyStars, passThrough),
     new OptionHandler('--force-strip=.*', setStrip),
@@ -1122,6 +1124,11 @@ Supported options:
   --no-source-maps
     Do not generate a source map file.
 
+  --omit-late-names
+    Do not include names of late variables in error messages. This allows
+    dart2js to generate smaller code by removing late variable names from the
+    generated JavaScript.
+
   -O<0,1,2,3,4>
     Controls optimizations that can help reduce code-size and improve
     performance of the generated code for deployment.
@@ -1149,6 +1156,7 @@ Supported options:
        Equivalent to calling dart2js with these extra flags:
         --minify
         --lax-runtime-type-to-string
+        --omit-late-names
 
     -O3
        Enables optimizations that respect the language semantics only on

pkg/compiler/lib/src/ir/scope_visitor.dart

@@ -983,17 +983,20 @@ class ScopeModelBuilder extends ir.Visitor<EvaluationComplexity>
   @override
   EvaluationComplexity visitConstructorInvocation(
       ir.ConstructorInvocation node) {
+    ir.Constructor target = node.target;
+    ir.Class enclosingClass = target.enclosingClass;
+
     // TODO(45681): Investigate if other initializers should be made eager.
 
-    // Lazily invoking the `_Cell` constructor pessimizes certain uses of late
-    // variables, so we ensure it gets called eagerly.
-    if (node.target == _coreTypes.cellConstructor) {
+    // Lazily constructing cells pessimizes certain uses of late variables, so
+    // we ensure they get constructed eagerly.
+    if (enclosingClass == _coreTypes.cellClass) {
       return EvaluationComplexity.eager();
     }
 
     if (node.arguments.types.isNotEmpty) {
       visitNodesInContext(node.arguments.types,
-          new VariableUse.constructorTypeArgument(node.target));
+          new VariableUse.constructorTypeArgument(target));
     }
     visitArguments(node.arguments);
     return node.isConst

pkg/compiler/lib/src/kernel/dart2js_target.dart

@@ -77,9 +77,11 @@ class Dart2jsTarget extends Target {
   @override
   final String name;
 
+  final bool omitLateNames;
+
   Map<String, ir.Class> _nativeClasses;
 
-  Dart2jsTarget(this.name, this.flags);
+  Dart2jsTarget(this.name, this.flags, {this.omitLateNames = false});
 
   @override
   bool get enableNoSuchMethodForwarders => true;
@@ -158,7 +160,8 @@ class Dart2jsTarget extends Target {
               _nativeClasses)
           .visitLibrary(library);
     }
-    lowering.transformLibraries(libraries, coreTypes, hierarchy);
+    lowering.transformLibraries(libraries, coreTypes, hierarchy,
+        omitLateNames: omitLateNames);
     logger?.call("Lowering transformations performed");
   }
 

pkg/compiler/lib/src/kernel/loader.dart

@@ -136,7 +136,8 @@ class KernelLoaderTask extends CompilerTask {
         }
       } else {
         bool verbose = false;
-        Target target = Dart2jsTarget(targetName, TargetFlags());
+        Target target = Dart2jsTarget(targetName, TargetFlags(),
+            omitLateNames: _options.omitLateNames);
         fe.FileSystem fileSystem = CompilerFileSystem(_compilerInput);
         fe.Verbosity verbosity = _options.verbosity;
         fe.DiagnosticMessageHandler onDiagnostic =