fixes selectable text

chunhtai · chunhtai · commit bf6e493f6643 · 2021-01-12T15:58:17.000-08:00
diff --git a/shell/platform/common/cpp/accessibility_bridge.cc b/shell/platform/common/cpp/accessibility_bridge.cc
@@ -219,7 +219,8 @@ void AccessibilityBridge::SetRoleFromFlutterUpdate(ui::AXNodeData& node_data,
     node_data.role = ax::mojom::Role::kButton;
     return;
   }
-  if (flags & FlutterSemanticsFlag::kFlutterSemanticsFlagIsTextField) {
+  if (flags & FlutterSemanticsFlag::kFlutterSemanticsFlagIsTextField &&
+      !(flags & FlutterSemanticsFlag::kFlutterSemanticsFlagIsReadOnly)) {
     node_data.role = ax::mojom::Role::kTextField;
     return;
   }

Original file line number	Diff line number	Diff line change
`@@ -219,7 +219,8 @@ void AccessibilityBridge::SetRoleFromFlutterUpdate(ui::AXNodeData& node_data,`
`219`	`219`	`node_data.role = ax::mojom::Role::kButton;`
`220`	`220`	`return;`
`221`	`221`	`}`
`222`		`- if (flags & FlutterSemanticsFlag::kFlutterSemanticsFlagIsTextField) {`
	`222`	`+ if (flags & FlutterSemanticsFlag::kFlutterSemanticsFlagIsTextField &&`
	`223`	`+ !(flags & FlutterSemanticsFlag::kFlutterSemanticsFlagIsReadOnly)) {`
`223`	`224`	`node_data.role = ax::mojom::Role::kTextField;`
`224`	`225`	`return;`
`225`	`226`	`}`