[web] Build unit tests with dart2js instead of build_runner (#20390)

* change from build_runner to dart2js

* add internalBootstrapBrowserTest to some of the tests

* add internalBootstrapBrowserTest to all remaining tests

* make tests build in paralel. Total time dropped from 586 to 177 seconds for 8 core MacBook

* change isolates with pool

* fixing analysis errors

* skipping canvaskit tests for ios-safari

* copy image files to the build directory

* adding internalBootstrapBrowserTest to newly added tests

* add internalBootstrapBrowserTest to faling path iterator test

* necessary changes to make chrome windows work

* in windows test in chrome instead of edge. our edge code was for legacy edge

* do not run golden unit tests on Windows LUCI bots for now

* addressing reviewer comments. Adding a method for deciding when to run integration tests.

* remove lines that I forgot to remove

* fixing analysis error. add issue for todo

* add bootstap to a test file

* adding bootstrap to another test

* add internalBootstrapBrowserTest to a golden test

* return test result in bat file. use archieve package to unzip

* fixing logs for chrome_installer

* use archieve and archieve entity instead of dynamic

* adding comments for windows platform archieve part

* addressing reviewer comments

* change readme file

Author: nturgut

lib/web_ui/dev/README.md

@@ -41,9 +41,7 @@ felt build [-w] -j 100
 
 If you are a Google employee, you can use an internal instance of Goma to parallelize your builds. Because Goma compiles code on remote servers, this option is effective even on low-powered laptops.
 
-By default, when compiling Dart code to JavaScript, we use 4 `dart2js` workers.
-If you need to increase or reduce the number of workers, set the `BUILD_MAX_WORKERS_PER_TASK`
-environment variable to the desired number.
+By default, when compiling Dart code to JavaScript, we use 8 `dart2js` workers.
 
 ## Running web engine tests
 

lib/web_ui/dev/browser_lock.yaml

@@ -5,7 +5,7 @@ chrome:
   # is not working with chrome.binary option.
   Linux: 741412
   Mac: 735194
-  Win: 735105
+  Win: 768975
 firefox:
   version: '72.0'
 edge:

lib/web_ui/dev/chrome_installer.dart

@@ -3,8 +3,11 @@
 // found in the LICENSE file.
 
 // @dart = 2.6
+import 'dart:async';
 import 'dart:io' as io;
 
+import 'package:archive/archive.dart';
+import 'package:archive/archive_io.dart';
 import 'package:args/args.dart';
 import 'package:http/http.dart';
 import 'package:meta/meta.dart';
@@ -186,7 +189,7 @@ class ChromeInstaller {
     } else if (versionDir.existsSync() && isLuci) {
       print('INFO: Chrome version directory in LUCI: '
           '${versionDir.path}');
-    } else if(!versionDir.existsSync() && isLuci) {
+    } else if (!versionDir.existsSync() && isLuci) {
       // Chrome should have been deployed as a CIPD package on LUCI.
       // Throw if it does not exists.
       throw StateError('Failed to locate Chrome on LUCI on path:'
@@ -196,6 +199,8 @@ class ChromeInstaller {
       versionDir.createSync(recursive: true);
     }
 
+    print('INFO: Starting Chrome download.');
+
     final String url = PlatformBinding.instance.getChromeDownloadUrl(version);
     final StreamedResponse download = await client.send(Request(
       'GET',
@@ -206,17 +211,50 @@ class ChromeInstaller {
         io.File(path.join(versionDir.path, 'chrome.zip'));
     await download.stream.pipe(downloadedFile.openWrite());
 
-    final io.ProcessResult unzipResult = await io.Process.run('unzip', <String>[
-      downloadedFile.path,
-      '-d',
-      versionDir.path,
-    ]);
-
-    if (unzipResult.exitCode != 0) {
-      throw BrowserInstallerException(
-          'Failed to unzip the downloaded Chrome archive ${downloadedFile.path}.\n'
-          'With the version path ${versionDir.path}\n'
-          'The unzip process exited with code ${unzipResult.exitCode}.');
+    /// Windows LUCI bots does not have a `unzip`. Instead we are
+    /// using `archive` pub package.
+    ///
+    /// We didn't use `archieve` on Mac/Linux since the new files have
+    /// permission issues. For now we are not able change file permissions
+    /// from dart.
+    /// See: https://github.com/dart-lang/sdk/issues/15078.
+    if (io.Platform.isWindows) {
+      final Stopwatch stopwatch = Stopwatch()..start();
+
+      // Read the Zip file from disk.
+      final bytes = downloadedFile.readAsBytesSync();
+
+      final Archive archive = ZipDecoder().decodeBytes(bytes);
+
+      // Extract the contents of the Zip archive to disk.
+      for (final ArchiveFile file in archive) {
+        final String filename = file.name;
+        if (file.isFile) {
+          final data = file.content as List<int>;
+          io.File(path.join(versionDir.path, filename))
+            ..createSync(recursive: true)
+            ..writeAsBytesSync(data);
+        } else {
+          io.Directory(path.join(versionDir.path, filename))
+            ..create(recursive: true);
+        }
+      }
+
+      stopwatch.stop();
+      print('INFO: The unzip took ${stopwatch.elapsedMilliseconds ~/ 1000} seconds.');
+    } else {
+      final io.ProcessResult unzipResult =
+          await io.Process.run('unzip', <String>[
+        downloadedFile.path,
+        '-d',
+        versionDir.path,
+      ]);
+      if (unzipResult.exitCode != 0) {
+        throw BrowserInstallerException(
+            'Failed to unzip the downloaded Chrome archive ${downloadedFile.path}.\n'
+            'With the version path ${versionDir.path}\n'
+            'The unzip process exited with code ${unzipResult.exitCode}.');
+      }
     }
 
     downloadedFile.deleteSync();

lib/web_ui/dev/common.dart

@@ -59,11 +59,11 @@ class _WindowsBinding implements PlatformBinding {
 
   @override
   String getChromeDownloadUrl(String version) =>
-      'https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Win%2F${version}%2Fchrome-win32.zip?alt=media';
+      'https://www.googleapis.com/download/storage/v1/b/chromium-browser-snapshots/o/Win%2F${version}%2Fchrome-win.zip?alt=media';
 
   @override
   String getChromeExecutablePath(io.Directory versionDir) =>
-      path.join(versionDir.path, 'chrome-win32', 'chrome');
+      path.join(versionDir.path, 'chrome-win', 'chrome.exe');
 
   @override
   String getFirefoxDownloadUrl(String version) =>

lib/web_ui/dev/felt_windows.bat

@@ -57,15 +57,15 @@ IF %orTempValue%==0 (
 :: TODO(nurhan): The batch script does not support snanphot option.
 :: Support snapshot option.
 CALL :installdeps
-IF %1==test (%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* --browser=edge) ELSE ( %DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* )
+IF %1==test (%DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* --browser=chrome) ELSE ( %DART_SDK_DIR%\bin\dart "%DEV_DIR%\felt.dart" %* )
 
-EXIT /B 0
+EXIT /B %ERRORLEVEL%
 
 :installdeps
 ECHO "Running \`pub get\` in 'engine/src/flutter/web_sdk/web_engine_tester'"
 cd "%FLUTTER_DIR%web_sdk\web_engine_tester"
 CALL %PUB_DIR% get
 ECHO "Running \`pub get\` in 'engine/src/flutter/lib/web_ui'"
-cd %WEB_UI_DIR% 
+cd %WEB_UI_DIR%
 CALL %PUB_DIR% get
 EXIT /B 0

lib/web_ui/dev/test_platform.dart

@@ -34,7 +34,6 @@ import 'package:test_core/src/runner/environment.dart'; // ignore: implementatio
 
 import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
 import 'package:test_core/src/runner/configuration.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/load_exception.dart'; // ignore: implementation_imports
 import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart'
     as wip;
 
@@ -407,15 +406,6 @@ Golden file $filename did not match the image generated by the test.
       throw ArgumentError('$browser is not a browser.');
     }
 
-    var htmlPath = p.withoutExtension(path) + '.html';
-    if (File(htmlPath).existsSync() &&
-        !File(htmlPath).readAsStringSync().contains('packages/test/dart.js')) {
-      throw LoadException(
-          path,
-          '"${htmlPath}" must contain <script src="packages/test/dart.js">'
-          '</script>.');
-    }
-
     if (_closed) {
       return null;
     }
@@ -811,15 +801,18 @@ class BrowserManager {
         controller = deserializeSuite(path, currentPlatform(_runtime),
             suiteConfig, await _environment, suiteChannel, message);
 
-        final String mapPath = p.join(
-          env.environment.webUiRootDir.path,
-          'build',
-          '$path.browser_test.dart.js.map',
-        );
-        PackageConfig packageConfig = await loadPackageConfigUri(
-          await Isolate.packageConfig);
-        Map<String, Uri> packageMap =
-          {for (var p in packageConfig.packages) p.name: p.packageUriRoot};
+        final String sourceMapFileName =
+            '${p.basename(path)}.browser_test.dart.js.map';
+        final String pathToTest = p.dirname(path);
+
+        final String mapPath = p.join(env.environment.webUiRootDir.path,
+            'build', pathToTest, sourceMapFileName);
+
+        PackageConfig packageConfig =
+            await loadPackageConfigUri(await Isolate.packageConfig);
+        Map<String, Uri> packageMap = {
+          for (var p in packageConfig.packages) p.name: p.packageUriRoot
+        };
         final JSStackTraceMapper mapper = JSStackTraceMapper(
           await File(mapPath).readAsString(),
           mapUrl: p.toUri(mapPath),