use SkOnce for singleton patheffect

reed-at-google · Skia Commit-Bot · commit b6d158aaf3dd · 2020-05-23T13:38:15.000Z
Change-Id: Iabeadca7dda29d0247536b5a02f977066772e2ee Reviewed-on: https://skia-review.googlesource.com/c/skia/+/291657 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by: Mike Klein <mtklein@google.com>
diff --git a/src/effects/SkOpPathEffect.cpp b/src/effects/SkOpPathEffect.cpp
@@ -127,7 +127,8 @@ sk_sp<SkFlattenable> SkStrokePE::CreateProc(SkReadBuffer& buffer) {
 #include "src/core/SkPathPriv.h"
 
 sk_sp<SkPathEffect> SkStrokeAndFillPathEffect::Make() {
-    return sk_sp<SkPathEffect>(new SkStrokeAndFillPE);
+    static SkPathEffect* strokeAndFill = new SkStrokeAndFillPE;
+    return sk_ref_sp(strokeAndFill);
 }
 
 void SkStrokeAndFillPE::flatten(SkWriteBuffer&) const {}

Original file line number	Diff line number	Diff line change
`@@ -127,7 +127,8 @@ sk_sp<SkFlattenable> SkStrokePE::CreateProc(SkReadBuffer& buffer) {`
`127`	`127`	`#include "src/core/SkPathPriv.h"`
`128`	`128`
`129`	`129`	`sk_sp<SkPathEffect> SkStrokeAndFillPathEffect::Make() {`
`130`		`- return sk_sp<SkPathEffect>(new SkStrokeAndFillPE);`
	`130`	`+ static SkPathEffect* strokeAndFill = new SkStrokeAndFillPE;`
	`131`	`+ return sk_ref_sp(strokeAndFill);`
`131`	`132`	`}`
`132`	`133`
`133`	`134`	`void SkStrokeAndFillPE::flatten(SkWriteBuffer&) const {}`