Remove ignores that are not ignoring anything (#25128)

Author: goderbauer

lib/web_ui/dev/chrome.dart

@@ -9,7 +9,7 @@ import 'dart:io';
 
 import 'package:pedantic/pedantic.dart';
 
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
+import 'package:test_core/src/util/io.dart';
 
 import 'browser.dart';
 import 'chrome_installer.dart';

lib/web_ui/dev/firefox.dart

@@ -9,7 +9,7 @@ import 'dart:io';
 import 'package:pedantic/pedantic.dart';
 
 import 'package:path/path.dart' as path;
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
+import 'package:test_core/src/util/io.dart';
 
 import 'browser.dart';
 import 'common.dart';

lib/web_ui/dev/test_platform.dart

@@ -25,18 +25,18 @@ import 'package:web_socket_channel/web_socket_channel.dart';
 import 'package:web_test_utils/goldens.dart';
 import 'package:web_test_utils/image_compare.dart';
 
-import 'package:test_api/src/backend/runtime.dart'; // ignore: implementation_imports
-import 'package:test_api/src/backend/suite_platform.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/runner_suite.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/platform.dart'; // ignore: implementation_imports
-import 'package:test_core/src/util/stack_trace_mapper.dart'; // ignore: implementation_imports
-import 'package:test_api/src/utils.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/suite.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/plugin/platform_helpers.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/environment.dart'; // ignore: implementation_imports
-
-import 'package:test_core/src/util/io.dart'; // ignore: implementation_imports
-import 'package:test_core/src/runner/configuration.dart'; // ignore: implementation_imports
+import 'package:test_api/src/backend/runtime.dart';
+import 'package:test_api/src/backend/suite_platform.dart';
+import 'package:test_core/src/runner/runner_suite.dart';
+import 'package:test_core/src/runner/platform.dart';
+import 'package:test_core/src/util/stack_trace_mapper.dart';
+import 'package:test_api/src/utils.dart';
+import 'package:test_core/src/runner/suite.dart';
+import 'package:test_core/src/runner/plugin/platform_helpers.dart';
+import 'package:test_core/src/runner/environment.dart';
+
+import 'package:test_core/src/util/io.dart';
+import 'package:test_core/src/runner/configuration.dart';
 
 import 'browser.dart';
 import 'common.dart';

lib/web_ui/dev/test_runner.dart

@@ -11,10 +11,10 @@ import 'package:meta/meta.dart';
 import 'package:path/path.dart' as path;
 import 'package:pool/pool.dart';
 import 'package:test_core/src/runner/hack_register_platform.dart'
-    as hack; // ignore: implementation_imports
-import 'package:test_api/src/backend/runtime.dart'; // ignore: implementation_imports
+    as hack;
+import 'package:test_api/src/backend/runtime.dart';
 import 'package:test_core/src/executable.dart'
-    as test; // ignore: implementation_imports
+    as test;
 import 'package:web_test_utils/goldens.dart';
 
 import 'common.dart';

lib/web_ui/lib/src/engine.dart

@@ -17,8 +17,8 @@ import 'dart:js_util' as js_util;
 import 'dart:math' as math;
 import 'dart:typed_data';
 
-import 'package:js/js.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:meta/meta.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:js/js.dart';
+import 'package:meta/meta.dart';
 
 import '../ui.dart' as ui;
 

lib/web_ui/lib/src/engine/bitmap_canvas.dart

@@ -577,7 +577,7 @@ class BitmapCanvas extends EngineCanvas {
       String cssColor = paint.color == null
           ? '#000000'
           : colorToCssString(
-              paint.color)!; // ignore: unnecessary_null_comparison
+              paint.color)!;
       final double sigma = paint.maskFilter!.webOnlySigma;
       if (browserEngine == BrowserEngine.webkit && !isStroke) {
         // A bug in webkit leaves artifacts when this element is animated

lib/web_ui/lib/src/engine/window.dart

@@ -272,7 +272,6 @@ typedef _JsSetUrlStrategy = void Function(JsUrlStrategy?);
 //
 // TODO: Add integration test https://github.com/flutter/flutter/issues/66852
 @JS('_flutter_web_set_location_strategy')
-// ignore: unused_element
 external set _jsSetUrlStrategy(_JsSetUrlStrategy? newJsSetUrlStrategy);
 
 UrlStrategy? _createDefaultUrlStrategy() {

lib/web_ui/test/color_test.dart

@@ -55,7 +55,7 @@ void testMain() {
   test('two colors are only == if they have the same runtime type', () {
     expect(const Color(123), equals(const Color(123)));
     expect(const Color(123),
-        equals(Color(123))); // ignore: prefer_const_constructors
+        equals(Color(123)));
     expect(const Color(123), isNot(equals(const Color(321))));
     expect(const Color(123), isNot(equals(const NotAColor(123))));
     expect(const NotAColor(123), isNot(equals(const Color(123))));

lib/web_ui/test/engine/path_metrics_test.dart

@@ -4,11 +4,11 @@
 
 import 'dart:math' as math;
 
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:ui/ui.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
+import 'package:ui/ui.dart';
 
-import '../matchers.dart'; // ignore: import_of_legacy_library_into_null_safe
+import '../matchers.dart';
 
 const double kTolerance = 0.001;
 

lib/web_ui/test/engine/surface/path/path_iterator_test.dart

@@ -5,8 +5,8 @@
 import 'dart:typed_data';
 
 import 'package:ui/src/engine.dart';
-import 'package:test/bootstrap/browser.dart'; // ignore: import_of_legacy_library_into_null_safe
-import 'package:test/test.dart'; // ignore: import_of_legacy_library_into_null_safe
+import 'package:test/bootstrap/browser.dart';
+import 'package:test/test.dart';
 
 void main() {
   internalBootstrapBrowserTest(() => testMain);