Fix memory leak in FlutterDarwinExternalTextureMetal (#28059)

ColdPaleLight · web-flow · commit b4b44f2adff3 · 2021-08-24T07:59:02.000-07:00
diff --git a/shell/platform/darwin/graphics/FlutterDarwinExternalTextureMetal.mm b/shell/platform/darwin/graphics/FlutterDarwinExternalTextureMetal.mm
@@ -39,6 +39,9 @@ - (instancetype)initWithTextureCache:(nonnull CVMetalTextureCacheRef)textureCach
 - (void)dealloc {
   CVPixelBufferRelease(_lastPixelBuffer);
   if (_textureCache) {
+    CVMetalTextureCacheFlush(_textureCache,  // cache
+                             0               // options (must be zero)
+    );
     CFRelease(_textureCache);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,9 @@ - (instancetype)initWithTextureCache:(nonnull CVMetalTextureCacheRef)textureCach`
`39`	`39`	`- (void)dealloc {`
`40`	`40`	`CVPixelBufferRelease(_lastPixelBuffer);`
`41`	`41`	`if (_textureCache) {`
	`42`	`+ CVMetalTextureCacheFlush(_textureCache, // cache`
	`43`	`+ 0 // options (must be zero)`
	`44`	`+ );`
`42`	`45`	`CFRelease(_textureCache);`
`43`	`46`	`}`
`44`	`47`	`}`