Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit b3af39f

Browse files
authored
iOS: Add dSYM binaries to without_entitlements.txt (#54573)
In #54414, we added dSYM files for physical and simulator binaries in both regular and extension-safe framework builds, but did not add the dSYMs to the without_entitlements.txt list. This passed all engine pre/post-submit tests, as well as framework tests, but failed during release codesigning in Cocoon in a test here: https://github.com/flutter/cocoon/blob/d849b14bab90e0f90e2f7667e37c9f9a5696b918/cipd_packages/codesign/lib/src/file_codesign_visitor.dart#L305-L313 This adds the missing files to without_entitlements.txt. Issue: flutter/flutter#116493 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
1 parent 61b9f5b commit b3af39f

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

sky/tools/create_full_ios_framework.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,13 @@ def zip_archive(dst):
197197
ios_file_with_entitlements = ['gen_snapshot_arm64']
198198
ios_file_without_entitlements = [
199199
'Flutter.xcframework/ios-arm64/Flutter.framework/Flutter',
200+
'Flutter.xcframework/ios-arm64/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter',
200201
'Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter',
202+
'Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter', # pylint: disable=line-too-long
201203
'extension_safe/Flutter.xcframework/ios-arm64/Flutter.framework/Flutter',
202-
'extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter'
204+
'extension_safe/Flutter.xcframework/ios-arm64/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter', # pylint: disable=line-too-long
205+
'extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/Flutter.framework/Flutter',
206+
'extension_safe/Flutter.xcframework/ios-arm64_x86_64-simulator/dSYMs/Flutter.framework.dSYM/Contents/Resources/DWARF/Flutter' # pylint: disable=line-too-long
203207
]
204208
embed_codesign_configuration(os.path.join(dst, 'entitlements.txt'), ios_file_with_entitlements)
205209

0 commit comments

Comments
 (0)