Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit b01cb58

Browse files
bkonyicommit-bot@chromium.org
authored andcommitted
Revert "Re-land "[vm] Add type to _AsyncAwaitCompleter.start.""
This reverts commit 4049ab5. Reason for revert: Appears to break standalone_2/dwarf_stack_trace_test and other related tests. https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket.appspot.com/8886276259895791440/+/steps/test_results/0/logs/new_test_failures__logs_/0 Original change's description: > Re-land "[vm] Add type to _AsyncAwaitCompleter.start." > > We need to relax vm/dart/causal_stacks/async_throws_stack_no_causal_test > > Change-Id: I40c08d432afeac839ce4f49bbf48c3707b23ef7f > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138804 > Reviewed-by: Martin Kustermann <[email protected]> > Commit-Queue: Samir Jindel <[email protected]> [email protected],[email protected],[email protected] Change-Id: Ib77bdb5ba9927cf5a9a588570a5d70641e912aed No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138791 Reviewed-by: Ben Konyi <[email protected]> Commit-Queue: Ben Konyi <[email protected]>
1 parent 043af43 commit b01cb58

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

runtime/tests/vm/dart/causal_stacks/utils.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -616,16 +616,13 @@ Future<void> doTestsNoCausalNoLazy() async {
616616
r'^#0 throwSync \(.*/utils.dart:16(:3)?\)$',
617617
r'^#1 noYields3 \(.*/utils.dart:54(:3)?\)$',
618618
r'^#2 _AsyncAwaitCompleter.start ',
619-
// TODO: fix line number here
620-
r'^#3 noYields3 \(.*/utils.dart(:53(:23)?|.*)\)$',
619+
r'^#3 noYields3 \(.*/utils.dart:53(:23)?\)$',
621620
r'^#4 noYields2 \(.*/utils.dart:50(:9)?\)$',
622621
r'^#5 _AsyncAwaitCompleter.start ',
623-
// TODO: fix line number here
624-
r'^#6 noYields2 \(.*/utils.dart',
622+
r'^#6 noYields2 \(.*/utils.dart:49(:23)?\)$',
625623
r'^#7 noYields \(.*/utils.dart:46(:9)?\)$',
626624
r'^#8 _AsyncAwaitCompleter.start ',
627-
// TODO: fix line number here
628-
r'^#9 noYields \(.*/utils.dart',
625+
r'^#9 noYields \(.*/utils.dart:45(:22)?\)$',
629626
];
630627
await doTestAwait(
631628
noYields,

sdk/lib/_internal/vm/lib/async_patch.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class _AsyncAwaitCompleter<T> implements Completer<T> {
4343
}
4444
}
4545

46-
void start(void Function() f) {
46+
void start(f) {
4747
f();
4848
isSync = true;
4949
}

sdk_nnbd/lib/_internal/vm/lib/async_patch.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ class _AsyncAwaitCompleter<T> implements Completer<T> {
4141
}
4242
}
4343

44-
void start(void Function() f) {
44+
void start(f) {
4545
f();
4646
isSync = true;
4747
}

0 commit comments

Comments
 (0)