Review Changes

Author: gspencergoog

lib/ui/text/paragraph_builder.cc

@@ -169,7 +169,7 @@ fml::RefPtr<ParagraphBuilder> ParagraphBuilder::create(
 // parameter passed directly.
 void decodeStrut(Dart_Handle strut_data,
                  const std::vector<std::string>& strut_font_families,
-                 txt::ParagraphStyle& paragraph_style) { // NOLINT
+                 txt::ParagraphStyle& paragraph_style) {  // NOLINT
   if (strut_data == Dart_Null()) {
     return;
   }
@@ -305,8 +305,9 @@ ParagraphBuilder::ParagraphBuilder(
 
 ParagraphBuilder::~ParagraphBuilder() = default;
 
-void decodeTextShadows(Dart_Handle shadows_data,
-                       std::vector<txt::TextShadow>& decoded_shadows) { // NOLINT
+void decodeTextShadows(
+    Dart_Handle shadows_data,
+    std::vector<txt::TextShadow>& decoded_shadows) {  // NOLINT
   decoded_shadows.clear();
 
   tonic::DartByteData byte_data(shadows_data);
@@ -330,7 +331,7 @@ void decodeTextShadows(Dart_Handle shadows_data,
 }
 
 void decodeFontFeatures(Dart_Handle font_features_data,
-                        txt::FontFeatures& font_features) { // NOLINT
+                        txt::FontFeatures& font_features) {  // NOLINT
   tonic::DartByteData byte_data(font_features_data);
   FML_CHECK(byte_data.length_in_bytes() % kBytesPerFontFeature == 0);
 
@@ -403,23 +404,23 @@ void ParagraphBuilder::pushStyle(tonic::Int32List& encoded,
     if (mask & tsFontWeightMask) {
       style.font_weight =
           static_cast<txt::FontWeight>(encoded[tsFontWeightIndex]);
-}
+    }
 
     if (mask & tsFontStyleMask) {
       style.font_style = static_cast<txt::FontStyle>(encoded[tsFontStyleIndex]);
-}
+    }
 
     if (mask & tsFontSizeMask) {
       style.font_size = fontSize;
-}
+    }
 
     if (mask & tsLetterSpacingMask) {
       style.letter_spacing = letterSpacing;
-}
+    }
 
     if (mask & tsWordSpacingMask) {
       style.word_spacing = wordSpacing;
-}
+    }
   }
 
   if (mask & tsHeightMask) {
@@ -472,7 +473,7 @@ void ParagraphBuilder::pop() {
 Dart_Handle ParagraphBuilder::addText(const std::u16string& text) {
   if (text.empty()) {
     return Dart_Null();
-}
+  }
 
   // Use ICU to validate the UTF-16 input.  Calling u_strToUTF8 with a null
   // output buffer will return U_BUFFER_OVERFLOW_ERROR if the input is well
@@ -482,7 +483,7 @@ Dart_Handle ParagraphBuilder::addText(const std::u16string& text) {
   u_strToUTF8(nullptr, 0, nullptr, text_ptr, text.size(), &error_code);
   if (error_code != U_BUFFER_OVERFLOW_ERROR) {
     return tonic::ToDart("string is not well-formed UTF-16");
-}
+  }
 
   m_paragraphBuilder->AddText(text);
 

lib/ui/window/platform_configuration_unittests.cc

@@ -25,21 +25,20 @@ class DummyPlatformConfigurationClient : public PlatformConfigurationClient {
     std::vector<uint8_t> data;
     isolate_data_.reset(new ::fml::DataMapping(data));
   }
-  virtual std::string DefaultRouteName() { return "TestRoute"; }
-  virtual void ScheduleFrame() {}
-  virtual void Render(Scene* scene) {}
-  virtual void UpdateSemantics(SemanticsUpdate* update) {}
-  virtual void HandlePlatformMessage(fml::RefPtr<PlatformMessage> message) {}
-  virtual FontCollection& GetFontCollection() { return font_collection_; }
-  virtual void UpdateIsolateDescription(const std::string isolate_name,
-                                        int64_t isolate_port) {}
-  virtual void SetNeedsReportTimings(bool value) {}
-  virtual std::shared_ptr<const fml::Mapping> GetPersistentIsolateData() {
+  std::string DefaultRouteName() override { return "TestRoute"; }
+  void ScheduleFrame() override {}
+  void Render(Scene* scene) override {}
+  void UpdateSemantics(SemanticsUpdate* update) override {}
+  void HandlePlatformMessage(fml::RefPtr<PlatformMessage> message) override {}
+  FontCollection& GetFontCollection() override { return font_collection_; }
+  void UpdateIsolateDescription(const std::string isolate_name,
+                                int64_t isolate_port) override {}
+  void SetNeedsReportTimings(bool value) override {}
+  std::shared_ptr<const fml::Mapping> GetPersistentIsolateData() override {
     return isolate_data_;
   }
-  virtual std::unique_ptr<std::vector<std::string>>
-  ComputePlatformResolvedLocale(
-      const std::vector<std::string>& supported_locale_data) {
+  std::unique_ptr<std::vector<std::string>> ComputePlatformResolvedLocale(
+      const std::vector<std::string>& supported_locale_data) override {
     return nullptr;
   };