Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit acaf9d6

Browse files
goderbauergoderbauer
committed
remove ignores
1 parent 978fea2 commit acaf9d6

File tree

24 files changed

+176
-203
lines changed

24 files changed

+176
-203
lines changed

‎ci/licenses_golden/tool_signature‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
Signature: f2b15cda839d356d1d2a906e432770d6
1+
Signature: 249aeecf2b9a309a2b26c2be6cd18b12
22

‎e2etests/web/regular_integration_tests/test_driver/platform_messages_integration.dart‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
// found in the LICENSE file.
44

55
import 'dart:html' as html;
6-
// ignore: undefined_shown_name
76
import 'dart:ui' as ui show platformViewRegistry;
87
import 'package:flutter/material.dart';
98
import 'package:flutter/services.dart';
@@ -37,7 +36,6 @@ void main() async {
3736
int viewInstanceCount = 0;
3837

3938
platformViewsRegistry.getNextPlatformViewId();
40-
// ignore: undefined_prefixed_name
4139
ui.platformViewRegistry.registerViewFactory('MyView', (int viewId) {
4240
++viewInstanceCount;
4341
return html.DivElement();

‎lib/ui/compositing.dart‎

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,7 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
339339
Clip clipBehavior = Clip.antiAlias,
340340
ClipRectEngineLayer? oldLayer,
341341
}) {
342-
assert(clipBehavior != null); // ignore: unnecessary_null_comparison
342+
assert(clipBehavior != null);
343343
assert(clipBehavior != Clip.none);
344344
assert(_debugCheckCanBeUsedAsOldLayer(oldLayer, 'pushClipRect'));
345345
final EngineLayer engineLayer = EngineLayer._();
@@ -368,7 +368,7 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
368368
Clip clipBehavior = Clip.antiAlias,
369369
ClipRRectEngineLayer? oldLayer,
370370
}) {
371-
assert(clipBehavior != null); // ignore: unnecessary_null_comparison
371+
assert(clipBehavior != null);
372372
assert(clipBehavior != Clip.none);
373373
assert(_debugCheckCanBeUsedAsOldLayer(oldLayer, 'pushClipRRect'));
374374
final EngineLayer engineLayer = EngineLayer._();
@@ -396,7 +396,7 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
396396
Clip clipBehavior = Clip.antiAlias,
397397
ClipPathEngineLayer? oldLayer,
398398
}) {
399-
assert(clipBehavior != null); // ignore: unnecessary_null_comparison
399+
assert(clipBehavior != null);
400400
assert(clipBehavior != Clip.none);
401401
assert(_debugCheckCanBeUsedAsOldLayer(oldLayer, 'pushClipPath'));
402402
final EngineLayer engineLayer = EngineLayer._();
@@ -451,10 +451,10 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
451451
ColorFilter filter, {
452452
ColorFilterEngineLayer? oldLayer,
453453
}) {
454-
assert(filter != null); // ignore: unnecessary_null_comparison
454+
assert(filter != null);
455455
assert(_debugCheckCanBeUsedAsOldLayer(oldLayer, 'pushColorFilter'));
456456
final _ColorFilter nativeFilter = filter._toNativeColorFilter()!;
457-
assert(nativeFilter != null); // ignore: unnecessary_null_comparison
457+
assert(nativeFilter != null);
458458
final EngineLayer engineLayer = EngineLayer._();
459459
_pushColorFilter(engineLayer, nativeFilter, oldLayer?._nativeLayer);
460460
final ColorFilterEngineLayer layer = ColorFilterEngineLayer._(engineLayer);
@@ -479,10 +479,10 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
479479
ImageFilter filter, {
480480
ImageFilterEngineLayer? oldLayer,
481481
}) {
482-
assert(filter != null); // ignore: unnecessary_null_comparison
482+
assert(filter != null);
483483
assert(_debugCheckCanBeUsedAsOldLayer(oldLayer, 'pushImageFilter'));
484484
final _ImageFilter nativeFilter = filter._toNativeImageFilter();
485-
assert(nativeFilter != null); // ignore: unnecessary_null_comparison
485+
assert(nativeFilter != null);
486486
final EngineLayer engineLayer = EngineLayer._();
487487
_pushImageFilter(engineLayer, nativeFilter, oldLayer?._nativeLayer);
488488
final ImageFilterEngineLayer layer = ImageFilterEngineLayer._(engineLayer);
@@ -577,7 +577,6 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
577577
/// {@macro dart.ui.sceneBuilder.oldLayerVsRetained}
578578
///
579579
/// See [pop] for details about the operation stack, and [Clip] for different clip modes.
580-
// ignore: deprecated_member_use
581580
PhysicalShapeEngineLayer? pushPhysicalShape({
582581
required Path path,
583582
required double elevation,
@@ -727,7 +726,7 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
727726
bool freeze = false,
728727
FilterQuality filterQuality = FilterQuality.low,
729728
}) {
730-
assert(offset != null, 'Offset argument was null'); // ignore: unnecessary_null_comparison
729+
assert(offset != null, 'Offset argument was null');
731730
_addTexture(offset.dx, offset.dy, width, height, textureId, freeze, filterQuality.index);
732731
}
733732

@@ -756,7 +755,7 @@ class SceneBuilder extends NativeFieldWrapperClass2 {
756755
double width = 0.0,
757756
double height = 0.0,
758757
}) {
759-
assert(offset != null, 'Offset argument was null'); // ignore: unnecessary_null_comparison
758+
assert(offset != null, 'Offset argument was null');
760759
_addPlatformView(offset.dx, offset.dy, width, height, viewId);
761760
}
762761

‎lib/ui/geometry.dart‎

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ abstract class OffsetBase {
1515
/// The first argument sets the horizontal component, and the second the
1616
/// vertical component.
1717
const OffsetBase(this._dx, this._dy)
18-
: assert(_dx != null), // ignore: unnecessary_null_comparison
19-
assert(_dy != null); // ignore: unnecessary_null_comparison
18+
: assert(_dx != null),
19+
assert(_dy != null);
2020

2121
final double _dx;
2222
final double _dy;
@@ -316,7 +316,7 @@ class Offset extends OffsetBase {
316316
/// Values for `t` are usually obtained from an [Animation<double>], such as
317317
/// an [AnimationController].
318318
static Offset? lerp(Offset? a, Offset? b, double t) {
319-
assert(t != null); // ignore: unnecessary_null_comparison
319+
assert(t != null);
320320
if (b == null) {
321321
if (a == null) {
322322
return null;
@@ -587,7 +587,7 @@ class Size extends OffsetBase {
587587
/// Values for `t` are usually obtained from an [Animation<double>], such as
588588
/// an [AnimationController].
589589
static Size? lerp(Size? a, Size? b, double t) {
590-
assert(t != null); // ignore: unnecessary_null_comparison
590+
assert(t != null);
591591
if (b == null) {
592592
if (a == null) {
593593
return null;
@@ -632,10 +632,10 @@ class Rect {
632632
/// Construct a rectangle from its left, top, right, and bottom edges.
633633
@pragma('vm:entry-point')
634634
const Rect.fromLTRB(this.left, this.top, this.right, this.bottom)
635-
: assert(left != null), // ignore: unnecessary_null_comparison
636-
assert(top != null), // ignore: unnecessary_null_comparison
637-
assert(right != null), // ignore: unnecessary_null_comparison
638-
assert(bottom != null); // ignore: unnecessary_null_comparison
635+
: assert(left != null),
636+
assert(top != null),
637+
assert(right != null),
638+
assert(bottom != null);
639639

640640
/// Construct a rectangle from its left and top edges, its width, and its
641641
/// height.
@@ -864,7 +864,7 @@ class Rect {
864864
/// Values for `t` are usually obtained from an [Animation<double>], such as
865865
/// an [AnimationController].
866866
static Rect? lerp(Rect? a, Rect? b, double t) {
867-
assert(t != null); // ignore: unnecessary_null_comparison
867+
assert(t != null);
868868
if (b == null) {
869869
if (a == null) {
870870
return null;
@@ -993,7 +993,7 @@ class Radius {
993993
/// Values for `t` are usually obtained from an [Animation<double>], such as
994994
/// an [AnimationController].
995995
static Radius? lerp(Radius? a, Radius? b, double t) {
996-
assert(t != null); // ignore: unnecessary_null_comparison
996+
assert(t != null);
997997
if (b == null) {
998998
if (a == null) {
999999
return null;
@@ -1179,18 +1179,18 @@ class RRect {
11791179
this.brRadiusY = 0.0,
11801180
this.blRadiusX = 0.0,
11811181
this.blRadiusY = 0.0,
1182-
}) : assert(left != null), // ignore: unnecessary_null_comparison
1183-
assert(top != null), // ignore: unnecessary_null_comparison
1184-
assert(right != null), // ignore: unnecessary_null_comparison
1185-
assert(bottom != null), // ignore: unnecessary_null_comparison
1186-
assert(tlRadiusX != null), // ignore: unnecessary_null_comparison
1187-
assert(tlRadiusY != null), // ignore: unnecessary_null_comparison
1188-
assert(trRadiusX != null), // ignore: unnecessary_null_comparison
1189-
assert(trRadiusY != null), // ignore: unnecessary_null_comparison
1190-
assert(brRadiusX != null), // ignore: unnecessary_null_comparison
1191-
assert(brRadiusY != null), // ignore: unnecessary_null_comparison
1192-
assert(blRadiusX != null), // ignore: unnecessary_null_comparison
1193-
assert(blRadiusY != null); // ignore: unnecessary_null_comparison
1182+
}) : assert(left != null),
1183+
assert(top != null),
1184+
assert(right != null),
1185+
assert(bottom != null),
1186+
assert(tlRadiusX != null),
1187+
assert(tlRadiusY != null),
1188+
assert(trRadiusX != null),
1189+
assert(trRadiusY != null),
1190+
assert(brRadiusX != null),
1191+
assert(brRadiusY != null),
1192+
assert(blRadiusX != null),
1193+
assert(blRadiusY != null);
11941194

11951195
Float32List get _value32 => Float32List.fromList(<double>[
11961196
left,
@@ -1558,7 +1558,7 @@ class RRect {
15581558
/// Values for `t` are usually obtained from an [Animation<double>], such as
15591559
/// an [AnimationController].
15601560
static RRect? lerp(RRect? a, RRect? b, double t) {
1561-
assert(t != null); // ignore: unnecessary_null_comparison
1561+
assert(t != null);
15621562
if (b == null) {
15631563
if (a == null) {
15641564
return null;

‎lib/ui/hooks.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ void _invoke(void Function()? callback, Zone zone) {
159159
return;
160160
}
161161

162-
assert(zone != null); // ignore: unnecessary_null_comparison
162+
assert(zone != null);
163163

164164
if (identical(zone, Zone.current)) {
165165
callback();
@@ -178,7 +178,7 @@ void _invoke1<A>(void Function(A a)? callback, Zone zone, A arg) {
178178
return;
179179
}
180180

181-
assert(zone != null); // ignore: unnecessary_null_comparison
181+
assert(zone != null);
182182

183183
if (identical(zone, Zone.current)) {
184184
callback(arg);
@@ -197,7 +197,7 @@ void _invoke2<A1, A2>(void Function(A1 a1, A2 a2)? callback, Zone zone, A1 arg1,
197197
return;
198198
}
199199

200-
assert(zone != null); // ignore: unnecessary_null_comparison
200+
assert(zone != null);
201201

202202
if (identical(zone, Zone.current)) {
203203
callback(arg1, arg2);
@@ -218,7 +218,7 @@ void _invoke3<A1, A2, A3>(void Function(A1 a1, A2 a2, A3 a3)? callback, Zone zon
218218
return;
219219
}
220220

221-
assert(zone != null); // ignore: unnecessary_null_comparison
221+
assert(zone != null);
222222

223223
if (identical(zone, Zone.current)) {
224224
callback(arg1, arg2, arg3);

‎lib/ui/isolate_name_server.dart‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class IsolateNameServer {
3333
///
3434
/// The `name` argument must not be null.
3535
static SendPort? lookupPortByName(String name) {
36-
assert(name != null, "'name' cannot be null."); // ignore: unnecessary_null_comparison
36+
assert(name != null, "'name' cannot be null.");
3737
return _lookupPortByName(name);
3838
}
3939

@@ -51,8 +51,8 @@ class IsolateNameServer {
5151
///
5252
/// The `port` and `name` arguments must not be null.
5353
static bool registerPortWithName(SendPort port, String name) {
54-
assert(port != null, "'port' cannot be null."); // ignore: unnecessary_null_comparison
55-
assert(name != null, "'name' cannot be null."); // ignore: unnecessary_null_comparison
54+
assert(port != null, "'port' cannot be null.");
55+
assert(name != null, "'name' cannot be null.");
5656
return _registerPortWithName(port, name);
5757
}
5858

@@ -68,7 +68,7 @@ class IsolateNameServer {
6868
///
6969
/// The `name` argument must not be null.
7070
static bool removePortNameMapping(String name) {
71-
assert(name != null, "'name' cannot be null."); // ignore: unnecessary_null_comparison
71+
assert(name != null, "'name' cannot be null.");
7272
return _removePortNameMapping(name);
7373
}
7474

0 commit comments

Comments
 (0)