Version 2.15.0-43.0.dev

Merge commit 'b977476ca044d23807c7342245158ea335124bdf' into 'dev'

Author: Dart CI

pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart

@@ -668,8 +668,9 @@ class Parser {
       listener.handleImportPrefix(/* deferredKeyword = */ null, asKeyword);
     } else {
       listener.handleImportPrefix(
-          /* deferredKeyword = */ null,
-          /* asKeyword = */ null);
+        /* deferredKeyword = */ null,
+        /* asKeyword = */ null,
+      );
     }
     return token;
   }
@@ -1447,9 +1448,10 @@ class Parser {
       }
       // Parse the (potential) new type.
       TypeInfo typeInfoAlternative = computeType(
-          token,
-          /* required = */ false,
-          /* inDeclaration = */ true);
+        token,
+        /* required = */ false,
+        /* inDeclaration = */ true,
+      );
       token = typeInfoAlternative.skipType(token);
       next = token.next!;
 
@@ -2115,8 +2117,9 @@ class Parser {
     } else {
       listener.handleNoType(token);
       listener.handleClassExtends(
-          /* extendsKeyword = */ null,
-          /* typeCount = */ 1);
+        /* extendsKeyword = */ null,
+        /* typeCount = */ 1,
+      );
     }
     return token;
   }
@@ -2524,9 +2527,10 @@ class Parser {
       }
       // Parse the (potential) new type.
       TypeInfo typeInfoAlternative = computeType(
-          token,
-          /* required = */ false,
-          /* inDeclaration = */ true);
+        token,
+        /* required = */ false,
+        /* inDeclaration = */ true,
+      );
       token = typeInfoAlternative.skipType(token);
       next = token.next!;
 
@@ -2643,9 +2647,10 @@ class Parser {
         indicatesMethodOrField(next.next!.next!)) {
       // Recovery: Use the reserved keyword despite that not being legal.
       typeInfo = computeType(
-          token,
-          /*required = */ true,
-          /* inDeclaration = */ true);
+        token,
+        /* required = */ true,
+        /* inDeclaration = */ true,
+      );
       token = typeInfo.skipType(token);
       next = token.next!;
       nameIsRecovered = true;
@@ -3610,9 +3615,10 @@ class Parser {
 
     Token beforeType = token;
     TypeInfo typeInfo = computeType(
-        token,
-        /*required = */ false,
-        /* inDeclaration = */ true);
+      token,
+      /* required = */ false,
+      /* inDeclaration = */ true,
+    );
     token = typeInfo.skipType(token);
     next = token.next!;
 
@@ -3757,9 +3763,10 @@ class Parser {
           indicatesMethodOrField(next2.next!)) {
         // Recovery: Use the reserved keyword despite that not being legal.
         typeInfo = computeType(
-            token,
-            /*required = */ true,
-            /* inDeclaration = */ true);
+          token,
+          /* required = */ true,
+          /* inDeclaration = */ true,
+        );
         token = typeInfo.skipType(token);
         next = token.next!;
         nameIsRecovered = true;
@@ -3962,8 +3969,11 @@ class Parser {
       reportRecoverableError(bodyStart, codes.messageRedirectionInNonFactory);
       token = parseRedirectingFactoryBody(token);
     } else {
-      token = parseFunctionBody(token, /* ofFunctionExpression = */ false,
-          (staticToken == null || externalToken != null) && inPlainSync);
+      token = parseFunctionBody(
+        token,
+        /* ofFunctionExpression = */ false,
+        (staticToken == null || externalToken != null) && inPlainSync,
+      );
     }
     asyncState = savedAsyncModifier;
 
@@ -4112,19 +4122,21 @@ class Parser {
         reportRecoverableError(next, codes.messageExternalFactoryWithBody);
       }
       token = parseFunctionBody(
-          token,
-          /* ofFunctionExpression = */ false,
-          /* allowAbstract = */ true);
+        token,
+        /* ofFunctionExpression = */ false,
+        /* allowAbstract = */ true,
+      );
     } else {
       if (varFinalOrConst != null && !optional('native', next)) {
         if (optional('const', varFinalOrConst)) {
           listener.handleConstFactory(varFinalOrConst);
         }
       }
       token = parseFunctionBody(
-          token,
-          /* ofFunctionExpression = */ false,
-          /* allowAbstract = */ false);
+        token,
+        /* ofFunctionExpression = */ false,
+        /* allowAbstract = */ false,
+      );
     }
     switch (kind) {
       case DeclarationKind.Class:
@@ -4418,9 +4430,7 @@ class Parser {
         begin = next = token.next!;
         // Fall through to parse the block.
       } else {
-        token = ensureBlock(
-            token,
-            codes.templateExpectedFunctionBody,
+        token = ensureBlock(token, codes.templateExpectedFunctionBody,
             /* missingBlockName = */ null);
         listener.handleInvalidFunctionBody(token);
         return token.endGroup!;
@@ -5528,10 +5538,11 @@ class Parser {
     if (optional('[]', token)) {
       token = rewriteSquareBrackets(beforeToken).next!;
       listener.handleLiteralList(
-          /* count = */ 0,
-          token,
-          constKeyword,
-          token.next!);
+        /* count = */ 0,
+        token,
+        constKeyword,
+        token.next!,
+      );
       return token.next!;
     }
     bool old = mayParseFunctionExpressions;
@@ -6584,10 +6595,11 @@ class Parser {
         listener.beginLocalFunctionDeclaration(start.next!);
         token = typeInfo.parseType(beforeType, this);
         return parseNamedFunctionRest(
-            token,
-            start.next!,
-            beforeFormals,
-            /* isFunctionExpression = */ false);
+          token,
+          start.next!,
+          beforeFormals,
+          /* isFunctionExpression = */ false,
+        );
       }
     }
 

pkg/_fe_analyzer_shared/lib/src/parser/quote.dart

@@ -181,7 +181,7 @@ String unescape(String string, Quote quote, Object location,
 String unescapeCodeUnits(List<int> codeUnits, bool isRaw, Object location,
     UnescapeErrorListener listener) {
   // Can't use Uint8List or Uint16List here, the code units may be larger.
-  List<int> result = new List<int>.filled(codeUnits.length, 0);
+  List<int> result = new List<int>.filled(codeUnits.length, /* fill = */ 0);
   int resultOffset = 0;
 
   for (int i = 0; i < codeUnits.length; i++) {

pkg/_fe_analyzer_shared/lib/src/parser/stack_listener.dart

@@ -526,7 +526,8 @@ abstract class Stack {
 }
 
 class StackImpl implements Stack {
-  List<Object?> array = new List<Object?>.filled(/* length = */ 8, null);
+  List<Object?> array =
+      new List<Object?>.filled(/* length = */ 8, /* fill = */ null);
   int arrayLength = 0;
 
   bool get isNotEmpty => arrayLength > 0;
@@ -610,14 +611,16 @@ class StackImpl implements Stack {
 
   List<Object?> get values {
     final int length = arrayLength;
-    final List<Object?> list = new List<Object?>.filled(length, null);
+    final List<Object?> list =
+        new List<Object?>.filled(length, /* fill = */ null);
     list.setRange(/* start = */ 0, length, array);
     return list;
   }
 
   void _grow() {
     final int length = array.length;
-    final List<Object?> newArray = new List<Object?>.filled(length * 2, null);
+    final List<Object?> newArray =
+        new List<Object?>.filled(length * 2, /* fill = */ null);
     newArray.setRange(/* start = */ 0, length, array, /* skipCount = */ 0);
     array = newArray;
   }
@@ -692,7 +695,8 @@ class FixedNullableList<T> {
 
   List<T?>? pop(Stack stack, int count, [NullValue? nullValue]) {
     if (count == 0) return null;
-    return stack.popList(count, new List<T?>.filled(count, null), nullValue);
+    return stack.popList(
+        count, new List<T?>.filled(count, /* fill = */ null), nullValue);
   }
 
   List<T>? popNonNullable(Stack stack, int count, T dummyValue) {
@@ -704,8 +708,8 @@ class FixedNullableList<T> {
   List<T?>? popPadded(Stack stack, int count, int padding,
       [NullValue? nullValue]) {
     if (count + padding == 0) return null;
-    return stack.popList(
-        count, new List<T?>.filled(count + padding, null), nullValue);
+    return stack.popList(count,
+        new List<T?>.filled(count + padding, /* fill = */ null), nullValue);
   }
 
   List<T>? popPaddedNonNullable(

pkg/_fe_analyzer_shared/lib/src/scanner/keyword_state.dart

@@ -25,10 +25,11 @@ abstract class KeywordState {
           .toList(growable: false);
       strings.sort((a, b) => a.compareTo(b));
       _KEYWORD_STATE = computeKeywordStateTable(
-          /* start = */ 0,
-          strings,
-          /* offset = */ 0,
-          strings.length);
+        /* start = */ 0,
+        strings,
+        /* offset = */ 0,
+        strings.length,
+      );
     }
     return _KEYWORD_STATE!;
   }
@@ -38,7 +39,7 @@ abstract class KeywordState {
     bool isLowercase = true;
 
     List<KeywordState?> table =
-        new List<KeywordState?>.filled($z - $A + 1, null);
+        new List<KeywordState?>.filled($z - $A + 1, /* fill = */ null);
     assert(length != 0);
     int chunk = 0;
     int chunkStart = -1;

pkg/_fe_analyzer_shared/lib/src/scanner/string_canonicalizer.dart

@@ -34,7 +34,7 @@ class StringCanonicalizer {
   int _count = 0;
 
   /// The table itself.
-  List<Node?> _nodes = new List<Node?>.filled(INITIAL_SIZE, null);
+  List<Node?> _nodes = new List<Node?>.filled(INITIAL_SIZE, /* fill = */ null);
 
   static String decode(List<int> data, int start, int end, bool asciiOnly) {
     String s;
@@ -64,7 +64,7 @@ class StringCanonicalizer {
 
   rehash() {
     int newSize = _size * 2;
-    List<Node?> newNodes = new List<Node?>.filled(newSize, null);
+    List<Node?> newNodes = new List<Node?>.filled(newSize, /* fill = */ null);
     for (int i = 0; i < _size; i++) {
       Node? t = _nodes[i];
       while (t != null) {
@@ -117,7 +117,7 @@ class StringCanonicalizer {
 
   clear() {
     _size = INITIAL_SIZE;
-    _nodes = new List<Node?>.filled(_size, null);
+    _nodes = new List<Node?>.filled(_size, /* fill = */ null);
     _count = 0;
   }
 }

pkg/front_end/parser_testcases/error_recovery/keyword_named_formal_parameter.dart

@@ -0,0 +1,69 @@
+void test(int abstract) {}
+void test(int as) {}
+void test(int assert) {}
+void test(int async) {}
+void test(int await) {}
+void test(int break) {}
+void test(int case) {}
+void test(int catch) {}
+void test(int class) {}
+void test(int const) {}
+void test(int continue) {}
+void test(int covariant) {}
+void test(int default) {}
+void test(int deferred) {}
+void test(int do) {}
+void test(int dynamic) {}
+void test(int else) {}
+void test(int enum) {}
+void test(int export) {}
+void test(int extends) {}
+void test(int extension) {}
+void test(int external) {}
+void test(int factory) {}
+void test(int false) {}
+void test(int final) {}
+void test(int finally) {}
+void test(int for) {}
+void test(int Function) {}
+void test(int get) {}
+void test(int hide) {}
+void test(int if) {}
+void test(int implements) {}
+void test(int import) {}
+void test(int in) {}
+void test(int inout) {}
+void test(int interface) {}
+void test(int is) {}
+void test(int late) {}
+void test(int library) {}
+void test(int mixin) {}
+void test(int native) {}
+void test(int new) {}
+void test(int null) {}
+void test(int of) {}
+void test(int on) {}
+void test(int operator) {}
+void test(int out) {}
+void test(int part) {}
+void test(int patch) {}
+void test(int required) {}
+void test(int rethrow) {}
+void test(int return) {}
+void test(int set) {}
+void test(int show) {}
+void test(int source) {}
+void test(int static) {}
+void test(int super) {}
+void test(int switch) {}
+void test(int sync) {}
+void test(int this) {}
+void test(int throw) {}
+void test(int true) {}
+void test(int try) {}
+void test(int typedef) {}
+void test(int var) {}
+void test(int void) {}
+void test(int while) {}
+void test(int with) {}
+void test(int yield) {}