Remove prints

Author: dkwingsmt

shell/platform/embedder/tests/embedder_metal_unittests.mm

@@ -108,9 +108,9 @@ GrBackendTexture backend_texture(texture_size.width(), texture_size.height(), Gr
   builder.SetMetalRendererConfig(texture_size);
 
   auto engine = builder.LaunchEngine();
-  EXPECT_TRUE(engine.is_valid());
+  ASSERT_TRUE(engine.is_valid());
 
-  EXPECT_EQ(FlutterEngineRegisterExternalTexture(engine.get(), texture_id), kSuccess);
+  ASSERT_EQ(FlutterEngineRegisterExternalTexture(engine.get(), texture_id), kSuccess);
 
   auto rendered_scene = context.GetNextSceneImage();
 
@@ -120,9 +120,9 @@ GrBackendTexture backend_texture(texture_size.width(), texture_size.height(), Gr
   event.width = texture_size.width();
   event.height = texture_size.height();
   event.pixel_ratio = 1.0;
-  EXPECT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), kSuccess);
+  ASSERT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), kSuccess);
 
-  EXPECT_TRUE(ImageMatchesFixture("external_texture_metal.png", rendered_scene));
+  ASSERT_TRUE(ImageMatchesFixture("external_texture_metal.png", rendered_scene));
 }
 
 TEST_F(EmbedderTest, MetalCompositorMustBeAbleToRenderPlatformViews) {
@@ -218,26 +218,18 @@ GrBackendTexture backend_texture(texture_size.width(), texture_size.height(), Gr
 
   auto rendered_scene = context.GetNextSceneImage();
 
-  printf("main 1\n");
-  fflush(stdout);
   auto engine = builder.LaunchEngine();
-  EXPECT_TRUE(engine.is_valid());
-  printf("main 2\n");
-  fflush(stdout);
+  ASSERT_TRUE(engine.is_valid());
 
   // Send a window metrics events so frames may be scheduled.
   FlutterWindowMetricsEvent event = {};
   event.struct_size = sizeof(event);
   event.width = 800;
   event.height = 600;
   event.pixel_ratio = 1.0;
-  EXPECT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), kSuccess);
-  printf("main 3\n");
-  fflush(stdout);
+  ASSERT_EQ(FlutterEngineSendWindowMetricsEvent(engine.get(), &event), kSuccess);
 
-  EXPECT_TRUE(ImageMatchesFixture("scene_without_custom_compositor.png", rendered_scene));
-  printf("main 4\n");
-  fflush(stdout);
+  ASSERT_TRUE(ImageMatchesFixture("scene_without_custom_compositor.png", rendered_scene));
 }
 
 TEST_F(EmbedderTest, TextureDestructionCallbackCalledWithoutCustomCompositorMetal) {

shell/platform/embedder/tests/embedder_test_context.cc

@@ -257,8 +257,6 @@ std::future<sk_sp<SkImage>> EmbedderTestContext::GetNextSceneImage() {
   auto future = promise.get_future();
   SetNextSceneCallback(
       fml::MakeCopyable([promise = std::move(promise)](auto image) mutable {
-        printf("Assign GetNextSceneImage\n");
-        fflush(stdout);
         promise.set_value(image);
       }));
   return future;

shell/platform/embedder/tests/embedder_unittests_util.cc

@@ -151,11 +151,7 @@ bool WriteImageToDisk(const fml::UniqueFD& directory,
 
 bool ImageMatchesFixture(const std::string& fixture_file_name,
                          const sk_sp<SkImage>& scene_image) {
-  printf("ImageMatchesFixture sync\n");
-  fflush(stdout);
   fml::FileMapping fixture_image_mapping(OpenFixture(fixture_file_name));
-  printf("ImageMatchesFixture sync 1\n");
-  fflush(stdout);
 
   FML_CHECK(fixture_image_mapping.GetSize() != 0u)
       << "Could not find fixture: " << fixture_file_name;
@@ -166,8 +162,6 @@ bool ImageMatchesFixture(const std::string& fixture_file_name,
       SkImages::DeferredFromEncodedData(std::move(encoded_image))
           ->makeRasterImage();
 
-  printf("ImageMatchesFixture 1\n");
-  fflush(stdout);
   FML_CHECK(fixture_image) << "Could not create image from fixture: "
                            << fixture_file_name;
 
@@ -181,19 +175,13 @@ bool ImageMatchesFixture(const std::string& fixture_file_name,
       << "Could not create image subset for fixture comparison: "
       << scene_image_subset;
 
-  printf("ImageMatchesFixture 2\n");
-  fflush(stdout);
   const auto images_are_same =
       RasterImagesAreSame(scene_image_subset, fixture_image);
-  printf("ImageMatchesFixture 3\n");
-  fflush(stdout);
 
   // If the images are not the same, this predicate is going to indicate test
   // failure. Dump both the actual image and the expectation to disk to the
   // test author can figure out what went wrong.
   if (!images_are_same) {
-    printf("ImageMatchesFixture diff\n");
-    fflush(stdout);
     const auto fixtures_path = GetFixturesPath();
 
     const auto actual_file_name = "actual_" + fixture_file_name;
@@ -216,8 +204,6 @@ bool ImageMatchesFixture(const std::string& fixture_file_name,
                    << fml::paths::JoinPaths({fixtures_path, actual_file_name})
                    << std::endl;
   }
-  printf("ImageMatchesFixture 4\n");
-  fflush(stdout);
   return images_are_same;
 }