Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit a61e012

Browse files
srujzscommit-bot@chromium.org
authored andcommitted
Migrate html tests using async_minitest and minitest
Move them to async_minitest. Change-Id: Ibe850b05a838dd64ae62b30c9a979de371b24db6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138741 Commit-Queue: Srujan Gaddam <[email protected]> Reviewed-by: Bob Nystrom <[email protected]>
1 parent e3070b6 commit a61e012

File tree

2 files changed

+5
-9
lines changed

2 files changed

+5
-9
lines changed

tests/lib_2/html/fileapi_supported_test.dart

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import 'dart:html';
55

66
import 'package:async_helper/async_helper.dart';
77
import 'package:async_helper/async_minitest.dart';
8-
import 'package:expect/minitest.dart' as minitest;
98

109

1110
Future<FileSystem> _fileSystem;
@@ -30,8 +29,8 @@ main() {
3029
});
3130

3231
test('requestFileSystem', () async {
33-
var expectation = FileSystem.supported ? minitest.returnsNormally : throws;
34-
minitest.expect(() async {
32+
var expectation = FileSystem.supported ? returnsNormally : throws;
33+
expect(() async {
3534
var fs = await fileSystem;
3635
expect(fs.root != null, true);
3736
}, expectation);

tests/lib_2/html/websocket_test.dart

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ library WebSocketTest;
33
import 'dart:html';
44

55
import 'package:async_helper/async_minitest.dart';
6-
import 'package:expect/minitest.dart' as minitest;
76

87
main() {
98
group('supported', () {
@@ -13,15 +12,13 @@ main() {
1312
});
1413

1514
group('websocket', () {
16-
var isWebSocket =
17-
minitest.predicate((x) => x is WebSocket, 'is a WebSocket');
18-
var expectation = WebSocket.supported ? minitest.returnsNormally : throws;
15+
var expectation = WebSocket.supported ? returnsNormally : throws;
1916

2017
test('constructorTest', () {
21-
minitest.expect(() {
18+
expect(() {
2219
var socket = new WebSocket('ws://localhost/ws', 'chat');
2320
expect(socket, isNotNull);
24-
minitest.expect(socket, isWebSocket);
21+
expect(socket, isInstanceOf<WebSocket>());
2522
}, expectation);
2623
});
2724

0 commit comments

Comments
 (0)