Feedback

Author: loic-sharma

lib/ui/window/platform_configuration.cc

@@ -73,10 +73,9 @@ void PlatformConfiguration::DidCreateIsolate() {
   // TODO(loicsharma): This should only be created if the embedder enables the
   // implicit view.
   // See: https://github.com/flutter/flutter/issues/120306
-  windows_.insert(
-      std::make_pair(kImplicitViewId,
-                     std::make_unique<Window>(
-                         kImplicitViewId, ViewportMetrics{1.0, 0.0, 0.0, -1})));
+  windows_.emplace(kImplicitViewId,
+                   std::make_unique<Window>(
+                       kImplicitViewId, ViewportMetrics{1.0, 0.0, 0.0, -1}));
 }
 
 void PlatformConfiguration::UpdateLocales(

shell/platform/embedder/tests/embedder_unittests.cc

@@ -177,12 +177,12 @@ TEST_F(EmbedderTest, ExecutableNameNotNull) {
 TEST_F(EmbedderTest, ImplicitViewNotNull) {
   auto& context = GetEmbedderContext(EmbedderTestContextType::kSoftwareContext);
 
+  bool implicitViewNotNull = false;
   fml::AutoResetWaitableEvent latch;
   context.AddNativeCallback(
       "NotifyBoolValue", CREATE_NATIVE_ENTRY([&](Dart_NativeArguments args) {
-        const auto dart_bool = tonic::DartConverter<bool>::FromDart(
+        implicitViewNotNull = tonic::DartConverter<bool>::FromDart(
             Dart_GetNativeArgument(args, 0));
-        EXPECT_TRUE(dart_bool);
         latch.Signal();
       }));
 
@@ -191,6 +191,8 @@ TEST_F(EmbedderTest, ImplicitViewNotNull) {
   builder.SetDartEntrypoint("implicitViewNotNull");
   auto engine = builder.LaunchEngine();
   latch.Wait();
+
+  EXPECT_TRUE(implicitViewNotNull);
 }
 
 std::atomic_size_t EmbedderTestTaskRunner::sEmbedderTaskRunnerIdentifiers = {};