Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9b923cc

Browse files
committed
Review.
1 parent 26cf915 commit 9b923cc

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

impeller/docs/standalone_gles.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ First create an EGL display connection:
2727
egl::Display display;
2828
```
2929

30-
Ask the display for a valid EGL configuration. Impeller needs and OpenGL ES 2.0 configuration.
30+
Ask the display for a valid EGL configuration. Impeller needs an OpenGL ES 2.0 configuration.
3131

3232
```c++
3333
egl::ConfigDescriptor egl_desc;
@@ -41,22 +41,22 @@ egl_desc.surface_type = egl::SurfaceType::kWindow;
4141
auto config = display.ChooseConfig(egl_desc);
4242
```
4343

44-
Once a valid config has been obtained, create a context and window surface. Creating the window surface requires a native window handle. Get the appropriate one for your platform. For instance, on Android, this is an `ANativeWindow`.
44+
Once a valid config has been obtained, create a context and window surface. Creating the window surface requires a native window handle. Get the appropriate one for your platform. For instance, on Android this is an `ANativeWindow`.
4545

4646
```c++
47-
auto context = display.CreateContext(*config, nullptr /* sharegroup */ );
47+
auto context = display.CreateContext(*config, /* sharegroup= */ nullptr );
4848
auto surface = display.CreateWindowSurface(*config, native_window_handle);
4949
```
5050

51-
Now that we have context, make it current on the calling thread. This should be fully setup WSI.
51+
Now that we have a context, make it current on the calling thread. This will complete the setup of WSI.
5252

5353
```c++
5454
context->MakeCurrent(*surface);
5555
```
5656
5757
## Creating the OpenGL ES Context
5858
59-
Impeller doesn't statically link against OpenGL ES. You need to give it a callback the return the appropriate OpenGL ES function for given name. With EGL, this can be something as simple as:
59+
Impeller doesn't statically link against OpenGL ES. You need to give it a callback the returns the appropriate OpenGL ES function for given name. With EGL, this can be something as simple as:
6060
6161
```c++
6262
auto resolver = [](const char* name) -> void* {
@@ -66,7 +66,7 @@ auto resolver = [](const char* name) -> void* {
6666

6767
Adjust as necessary.
6868

69-
Once you have the resolver, you need to create an OpenGL ES proc table. The proc table contains the table of OpenGL ES procs that Impeller will need at runtime.
69+
Once you have the resolver, you need to create an OpenGL ES proc table. The proc table contains the function pointers for the subset of the OpenGL ES API used by Impeller.
7070

7171
```c++
7272
auto gl = std::make_unique<ProcTableGLES>(resolver);

0 commit comments

Comments
 (0)