Fix silly use of json.encode

Author: gspencergoog

lib/web_ui/lib/src/engine/keyboard.dart

@@ -131,8 +131,7 @@ class Keyboard {
         if (data == null) {
           return;
         }
-        final String response = utf8.decode(data.buffer.asUint8List());
-        final Map<String, dynamic> jsonResponse = json.decode(response);
+        final Map<String, dynamic> jsonResponse = _messageCodec.decodeMessage(data);
         if (jsonResponse['handled'] as bool) {
           // If the framework handled it, then don't propagate it any further.
           event.preventDefault();

lib/web_ui/test/keyboard_test.dart

@@ -6,7 +6,6 @@
 import 'dart:html' as html;
 import 'dart:js_util' as js_util;
 import 'dart:typed_data';
-import 'dart:convert' hide Codec;
 
 import 'package:quiver/testing/async.dart';
 import 'package:test/bootstrap/browser.dart';
@@ -18,14 +17,6 @@ void main() {
   internalBootstrapBrowserTest(() => testMain);
 }
 
-ByteData _toByteData(List<int> bytes) {
-  final ByteData byteData = ByteData(bytes.length);
-  for (int i = 0; i < bytes.length; i++) {
-    byteData.setUint8(i, bytes[i]);
-  }
-  return byteData;
-}
-
 void testMain() {
   group('Keyboard', () {
     /// Used to save and restore [ui.window.onPlatformMessage] after each test.
@@ -236,21 +227,13 @@ void testMain() {
     });
 
     test('prevents default when key is handled by the framework', () {
-      ByteData _toByteData(List<int> bytes) {
-        final ByteData byteData = ByteData(bytes.length);
-        for (int i = 0; i < bytes.length; i++) {
-          byteData.setUint8(i, bytes[i]);
-        }
-        return byteData;
-      }
-
       Keyboard.initialize();
 
       int count = 0;
       ui.window.onPlatformMessage = (String channel, ByteData data,
           ui.PlatformMessageResponseCallback callback) {
         count += 1;
-        ByteData response = _toByteData(utf8.encode(json.encode(<String, dynamic>{'handled': true})));
+        ByteData response = const JSONMessageCodec().encodeMessage(<String, dynamic>{'handled': true});
         callback(response);
       };
 
@@ -273,7 +256,7 @@ void testMain() {
       ui.window.onPlatformMessage = (String channel, ByteData data,
           ui.PlatformMessageResponseCallback callback) {
         count += 1;
-        ByteData response = _toByteData(utf8.encode(json.encode(<String, dynamic>{'handled': false})));
+        ByteData response = const JSONMessageCodec().encodeMessage(<String, dynamic>{'handled': false});
         callback(response);
       };
 
@@ -320,7 +303,7 @@ void testMain() {
       ui.window.onPlatformMessage = (String channel, ByteData data,
           ui.PlatformMessageResponseCallback callback) {
         count += 1;
-        ByteData response = _toByteData(utf8.encode(json.encode(<String, dynamic>{'handled': true})));
+        ByteData response = const JSONMessageCodec().encodeMessage(<String, dynamic>{'handled': true});
         callback(response);
       };