Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9662a38

Browse files
author
Emmanuel Garcia
authored
Prevent race condition while switching surfaces (#24838)
1 parent ce21b84 commit 9662a38

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

shell/platform/android/io/flutter/embedding/android/FlutterImageView.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,6 @@ public FlutterRenderer getAttachedRenderer() {
118118
*/
119119
@Override
120120
public void attachToRenderer(@NonNull FlutterRenderer flutterRenderer) {
121-
if (isAttachedToFlutterRenderer) {
122-
return;
123-
}
124121
switch (kind) {
125122
case background:
126123
flutterRenderer.swapSurface(imageReader.getSurface());

shell/platform/android/io/flutter/embedding/android/FlutterView.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1068,7 +1068,9 @@ public void revertImageView(@NonNull Runnable onDone) {
10681068
public void onFlutterUiDisplayed() {
10691069
renderer.removeIsDisplayingFlutterUiListener(this);
10701070
onDone.run();
1071-
flutterImageView.detachFromRenderer();
1071+
if (!(renderSurface instanceof FlutterImageView)) {
1072+
flutterImageView.detachFromRenderer();
1073+
}
10721074
}
10731075

10741076
@Override

0 commit comments

Comments
 (0)