Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 95e6c17

Browse files
authored
Add missing baseline check in text layout tests (#51444)
This PR adds a check for the `baseline` value in text layout service tests that appears to be missing. Test-exempt: increasing test coverage only.
1 parent 76f33eb commit 95e6c17

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

lib/web_ui/test/html/text/layout_service_helper.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,13 @@ void expectLines(CanvasParagraph paragraph, List<TestLine> expectedLines) {
107107
'line #$i had a different `left` value: "${line.left}" vs. "${expectedLine.left}"',
108108
);
109109
}
110+
if (expectedLine.baseline != null) {
111+
expect(
112+
line.baseline,
113+
expectedLine.baseline,
114+
reason: 'line #$i had a different `baseline` value: "${line.baseline}" vs. "${expectedLine.baseline}"',
115+
);
116+
}
110117
}
111118
}
112119

0 commit comments

Comments
 (0)