Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 9474c23

Browse files
filmilcommit-bot@chromium.org
authored andcommitted
[vm] Replaces fuchsia.deprecatedtimezone
(prior attempt was rolled back as it had a regression which was not caught by tests. Tests are fixed now at: https://fuchsia-review.googlesource.com/c/fuchsia/+/409840) The FIDL library fuchsia.deprecatedtimezone is going away. There are different and better ways to obtain the same functionality. This change removes the dependency on fuchsia.deprecatedtimezone from the Dart SDK. Adds inspect metrics that allow whitebox testing of the runners. Here's a sample `fx iquery` excerpt from a running device, showing both a dart and a flutter runner exposing the same OS diagnostic metrics. Adds support for asynchronous timezone updates, which was missing from previous versions of this commit. ``` /hub/c/dart_jit_runner.cmx/70981/out/diagnostics: /hub/c/dart_jit_runner.cmx/70981/out/diagnostics#os: dst_status = 0 get_profile_status = 0 timezone_content_status = 0 tz_data_close_status = 0 tz_data_status = 0 /hub/c/flutter_jit_runner.cmx/29567/out/diagnostics: /hub/c/flutter_jit_runner.cmx/29567/out/diagnostics#os: dst_status = 0 get_profile_status = 0 timezone_content_status = 0 tz_data_close_status = 0 tz_data_status = 0 ``` Under nominal operation, all of the above values should be equal to 0. Nonzero values indicate an error. This functionality is guarded by Fuchsia integration tests at //src/tests/intl. Tested: (compile locally for Fuchsia and deploy) fx test //src/tests/intl See: - dart-lang/sdk#42245 - dart-lang/sdk#39650 Fixes #39650 TEST=see Tested: above Change-Id: Icb72ddd554c263f970e18b9cbbaab7adf43c8710 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155582 Auto-Submit: Filip Filmar <[email protected]> Reviewed-by: Martin Kustermann <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent ff6ddd2 commit 9474c23

File tree

2 files changed

+276
-35
lines changed

2 files changed

+276
-35
lines changed

runtime/vm/BUILD.gn

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ library_for_all_configs("libdart_vm") {
7474
if (is_fuchsia) {
7575
if (using_fuchsia_gn_sdk) {
7676
extra_deps = [
77-
"$fuchsia_sdk_root/fidl/fuchsia.deprecatedtimezone",
77+
"$fuchsia_sdk_root/fidl/fuchsia.intl",
7878
"$fuchsia_sdk_root/pkg/async",
7979
"$fuchsia_sdk_root/pkg/async-default",
8080
"$fuchsia_sdk_root/pkg/async-loop",
@@ -87,7 +87,7 @@ library_for_all_configs("libdart_vm") {
8787
]
8888
} else if (using_fuchsia_sdk) {
8989
extra_deps = [
90-
"$fuchsia_sdk_root/fidl:fuchsia.deprecatedtimezone",
90+
"$fuchsia_sdk_root/fidl:fuchsia.intl",
9191
"$fuchsia_sdk_root/pkg:async-loop",
9292
"$fuchsia_sdk_root/pkg:async-loop-default",
9393
"$fuchsia_sdk_root/pkg:inspect",
@@ -98,9 +98,7 @@ library_for_all_configs("libdart_vm") {
9898
]
9999
} else {
100100
extra_deps = [
101-
# TODO(US-399): Remove time_service specific code when it is no longer
102-
# necessary.
103-
"//sdk/fidl/fuchsia.deprecatedtimezone",
101+
"//sdk/fidl/fuchsia.intl",
104102
"//sdk/lib/sys/cpp",
105103
"//sdk/lib/sys/inspect/cpp",
106104
"//zircon/public/lib/fbl",

0 commit comments

Comments
 (0)