Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 8e1406f

Browse files
authored
Fix the local-only lint errors due to an unexpected GeneratedPluginRegistrant.java (#50795)
Remove `android/**/GeneratedPluginRegistrant.java` from the global `.gitignore`. This file should never exist in the source tree, locally or on CI, and it existing/being hidden causes lint errors. ## Background Here is what we _think_ happens: - Someone opens `$ENGINE/src/flutter/testing/scenario_app` in VS Code - VS Code picks this up as a "Flutter package", running `flutter packages get` - The Flutter tool generates `../GeneratedPluginRegistrant.java`, thinking this is a Flutter app - The lint error fails on `GeneratedPluginRegistrant` ```txt $ ninja -j100 -C out/android_debug_unopt_arm64/ FAILED: scenario_app/reports/lint-results.xml vpython3 ../../flutter/testing/rules/run_gradle.py /Users/aaclarke/dev/engine/src/flutter/testing/scenario_app/android lint --no-daemon -Pflutter_jar=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/flutter.jar -Pout_dir=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app --project-cache-dir=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app/.gradle --gradle-user-home=/Users/aaclarke/dev/engine/src/out/android_debug_unopt_arm64/scenario_app/.gradle FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':app:lintDebug'. > Lint found errors in the project; aborting build. Fix the issues identified by lint, or create a baseline to see only new errors: ''' android { lint { baseline = file("lint-baseline.xml") } } ''' For more details, see https://developer.android.com/studio/write/lint#snapshot Lint found 1 errors, 0 warnings. First failure: ``` /cc @christopherfujino for any other theories.
1 parent db49661 commit 8e1406f

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

.gitignore

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ xcuserdata
3434
*.log
3535
*.pyc
3636
*.swp
37-
.DS_Store
3837
.atom/
3938
.buildlog/
4039
.history
@@ -76,7 +75,6 @@ unlinked_spec.ds
7675
**/android/gradlew
7776
**/android/gradlew.bat
7877
**/android/local.properties
79-
**/android/**/GeneratedPluginRegistrant.java
8078
**/android/key.properties
8179
*.jks
8280

0 commit comments

Comments
 (0)