This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Commit 8c48577
authored
[CP-stable]Move detection of cutouts in Android engine to
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
### Issue Link:
What is the link to the issue this cherry-pick is addressing?
flutter/flutter#158192
### Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples
#55992. - Positions of display cutouts on Android may not update - as returned by `MediaQuery` and used by `SafeArea` - upon screen orientation change.
### Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
The positions of display cutouts as reported by `MediaQuery` would not properly update on screen orientation.
### Workaround:
Is there a workaround for this issue?
N/A
### Risk:
What is the risk level of this cherry-pick?
### Test Coverage:
Are you confident that your fix is well-tested by automated tests?
### Validation Steps:
What are the steps to validate that this fix works?
Run the code sample provided by flutter/flutter#155658 on Android and change the screen orientation.onApplyWindowInsets (#56379)1 parent cb4b5ff commit 8c48577
File tree
4 files changed
+251
-75
lines changed- shell/platform/android
- io/flutter/embedding
- android
- engine/renderer
- test/io/flutter/embedding
- android
- engine/renderer
4 files changed
+251
-75
lines changedLines changed: 30 additions & 29 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
194 | 194 | | |
195 | 195 | | |
196 | 196 | | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
| 197 | + | |
204 | 198 | | |
205 | 199 | | |
206 | 200 | | |
| |||
512 | 506 | | |
513 | 507 | | |
514 | 508 | | |
| 509 | + | |
| 510 | + | |
| 511 | + | |
| 512 | + | |
515 | 513 | | |
516 | 514 | | |
517 | 515 | | |
| |||
524 | 522 | | |
525 | 523 | | |
526 | 524 | | |
527 | | - | |
| 525 | + | |
528 | 526 | | |
529 | 527 | | |
| 528 | + | |
530 | 529 | | |
531 | 530 | | |
532 | 531 | | |
| |||
537 | 536 | | |
538 | 537 | | |
539 | 538 | | |
540 | | - | |
541 | | - | |
| 539 | + | |
| 540 | + | |
542 | 541 | | |
543 | 542 | | |
544 | 543 | | |
545 | | - | |
| 544 | + | |
546 | 545 | | |
547 | 546 | | |
548 | 547 | | |
| |||
565 | 564 | | |
566 | 565 | | |
567 | 566 | | |
568 | | - | |
| 567 | + | |
| 568 | + | |
569 | 569 | | |
570 | | - | |
| 570 | + | |
571 | 571 | | |
572 | 572 | | |
573 | 573 | | |
574 | 574 | | |
575 | 575 | | |
576 | 576 | | |
577 | | - | |
578 | | - | |
579 | | - | |
580 | | - | |
581 | | - | |
582 | | - | |
583 | | - | |
584 | | - | |
585 | | - | |
586 | | - | |
587 | | - | |
588 | | - | |
589 | | - | |
590 | | - | |
591 | | - | |
592 | | - | |
| 577 | + | |
593 | 578 | | |
594 | 579 | | |
595 | 580 | | |
| |||
782 | 767 | | |
783 | 768 | | |
784 | 769 | | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
785 | 786 | | |
786 | 787 | | |
787 | 788 | | |
| |||
Lines changed: 50 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1137 | 1137 | | |
1138 | 1138 | | |
1139 | 1139 | | |
| 1140 | + | |
| 1141 | + | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
1140 | 1147 | | |
1141 | 1148 | | |
1142 | 1149 | | |
| |||
1187 | 1194 | | |
1188 | 1195 | | |
1189 | 1196 | | |
1190 | | - | |
1191 | | - | |
1192 | | - | |
1193 | | - | |
1194 | | - | |
| 1197 | + | |
| 1198 | + | |
| 1199 | + | |
| 1200 | + | |
| 1201 | + | |
| 1202 | + | |
| 1203 | + | |
| 1204 | + | |
| 1205 | + | |
| 1206 | + | |
1195 | 1207 | | |
1196 | 1208 | | |
1197 | | - | |
1198 | | - | |
1199 | | - | |
1200 | | - | |
| 1209 | + | |
1201 | 1210 | | |
1202 | 1211 | | |
1203 | 1212 | | |
| 1213 | + | |
| 1214 | + | |
| 1215 | + | |
| 1216 | + | |
| 1217 | + | |
| 1218 | + | |
| 1219 | + | |
| 1220 | + | |
| 1221 | + | |
1204 | 1222 | | |
1205 | 1223 | | |
1206 | 1224 | | |
| |||
1314 | 1332 | | |
1315 | 1333 | | |
1316 | 1334 | | |
1317 | | - | |
| 1335 | + | |
| 1336 | + | |
| 1337 | + | |
| 1338 | + | |
| 1339 | + | |
| 1340 | + | |
| 1341 | + | |
| 1342 | + | |
| 1343 | + | |
| 1344 | + | |
| 1345 | + | |
| 1346 | + | |
| 1347 | + | |
| 1348 | + | |
| 1349 | + | |
| 1350 | + | |
| 1351 | + | |
| 1352 | + | |
| 1353 | + | |
| 1354 | + | |
| 1355 | + | |
| 1356 | + | |
| 1357 | + | |
1318 | 1358 | | |
1319 | 1359 | | |
1320 | 1360 | | |
| |||
1337 | 1377 | | |
1338 | 1378 | | |
1339 | 1379 | | |
1340 | | - | |
1341 | | - | |
1342 | | - | |
1343 | | - | |
1344 | | - | |
1345 | | - | |
1346 | 1380 | | |
1347 | 1381 | | |
1348 | 1382 | | |
| |||
0 commit comments