Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 6d69561

Browse files
committed
Address comments
1 parent 89088f0 commit 6d69561

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

flow/BUILD.gn

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
import("//build/fuchsia/sdk.gni")
66
import("//flutter/common/config.gni")
7-
import("//flutter/impeller/tools/impeller.gni")
87
import("//flutter/shell/config.gni")
98
import("//flutter/testing/testing.gni")
109

@@ -100,6 +99,7 @@ source_set("flow") {
10099
public_deps = [
101100
"//flutter/display_list",
102101
"//flutter/impeller",
102+
"//flutter/impeller/aiks",
103103
]
104104
}
105105

shell/platform/embedder/embedder_external_view.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ bool EmbedderExternalView::Render(const EmbedderRenderTarget& render_target) {
8989
if (impeller_target.has_value()) {
9090
auto aiks_context = render_target.GetAiksContext();
9191

92-
DisplayListBuilder dl_builder;
92+
auto dl_builder = DisplayListBuilder();
9393
dl_builder.SetTransform(&surface_transformation_);
9494
slice_->render_into(&dl_builder);
9595

shell/platform/embedder/embedder_render_target.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ EmbedderRenderTarget::EmbedderRenderTarget(
3434
FML_DCHECK(aiks_context_);
3535
FML_DCHECK(!render_surface_);
3636
} else {
37-
FML_CHECK(render_surface_);
37+
FML_DCHECK(render_surface_);
3838
}
3939
}
4040

shell/platform/embedder/embedder_surface_metal_impeller.mm

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,7 @@
5959
return valid_;
6060
}
6161

62-
std::unique_ptr<Surface> EmbedderSurfaceMetalImpeller::CreateGPUSurface() API_AVAILABLE(ios(13.0)) {
63-
if (@available(iOS 13.0, *)) {
64-
} else {
65-
return nullptr;
66-
}
62+
std::unique_ptr<Surface> EmbedderSurfaceMetalImpeller::CreateGPUSurface() {
6763
if (!IsValid()) {
6864
return nullptr;
6965
}

0 commit comments

Comments
 (0)