[Impeller] Enable GLES MSAA only if the multisampled_render_to_texture2 extension is available (#47364)

jason-simmons · web-flow · commit 674de5b2cb53 · 2023-10-27T14:44:58.000Z
The GLES MSAA implementation may need to call FramebufferTexture2DMultisampleEXT for the stencil attachment. See flutter/flutter#137252
diff --git a/impeller/renderer/backend/gles/capabilities_gles.cc b/impeller/renderer/backend/gles/capabilities_gles.cc
@@ -108,7 +108,7 @@ CapabilitiesGLES::CapabilitiesGLES(const ProcTableGLES& gl) {
   }
 
   if (gl.GetDescription()->HasExtension(
-          "GL_EXT_multisampled_render_to_texture") &&
+          "GL_EXT_multisampled_render_to_texture2") &&
       // The current implementation of MSAA support in Impeller GLES requires
       // the use of glBlitFramebuffer, which is not available on all GLES
       // implementations. We can't use MSAA on these platforms yet.

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ CapabilitiesGLES::CapabilitiesGLES(const ProcTableGLES& gl) {`
`108`	`108`	`}`
`109`	`109`
`110`	`110`	`if (gl.GetDescription()->HasExtension(`
`111`		`- "GL_EXT_multisampled_render_to_texture") &&`
	`111`	`+ "GL_EXT_multisampled_render_to_texture2") &&`
`112`	`112`	`// The current implementation of MSAA support in Impeller GLES requires`
`113`	`113`	`// the use of glBlitFramebuffer, which is not available on all GLES`
`114`	`114`	`// implementations. We can't use MSAA on these platforms yet.`