Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 66ba4d8

Browse files
committed
Address review comments
1 parent 6b8c39c commit 66ba4d8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ private static int inputTypeFromTextInputType(
275275
if (!enableSuggestions) {
276276
// Note: both required. Some devices ignore TYPE_TEXT_FLAG_NO_SUGGESTIONS.
277277
textType |= InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS;
278-
textType |= InputType.TYPE_TEXT_VARIATION_PASSWORD;
278+
textType |= InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD;
279279
}
280280
}
281281

shell/platform/android/test/io/flutter/plugin/editing/TextInputPluginTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ public void textEditingDelta_TestUpdateEditingValueWithDeltasIsNotInvokedWhenDel
273273
true,
274274
false, // Delta model is disabled.
275275
TextInputChannel.TextCapitalization.NONE,
276-
new TextInputChannel.InputType(TextInputChannel.TextInputType.MULTILINE, false, false),
276+
new TextInputChannel.InputType(TextInputChannel.TextInputType.TEXT, false, false),
277277
null,
278278
null,
279279
null,
@@ -1339,7 +1339,7 @@ public void inputConnection_textInputTypeMultilineAndSuggestionsDisabled() {
13391339
InputType.TYPE_CLASS_TEXT
13401340
| InputType.TYPE_TEXT_FLAG_MULTI_LINE
13411341
| InputType.TYPE_TEXT_FLAG_NO_SUGGESTIONS
1342-
| InputType.TYPE_TEXT_VARIATION_PASSWORD);
1342+
| InputType.TYPE_TEXT_VARIATION_VISIBLE_PASSWORD);
13431343
}
13441344

13451345
// -------- Start: Autofill Tests -------

0 commit comments

Comments
 (0)