Address comments

Author: bdero

impeller/renderer/BUILD.gn

@@ -160,6 +160,6 @@ impeller_component("renderer_dart_unittests") {
     "../playground:playground_test",
     "//flutter/runtime:runtime",
     "//flutter/testing:fixture_test",
-    "//flutter/testing:testing_lib",
+    "//flutter/testing:testing",
   ]
 }

impeller/renderer/renderer_dart_unittests.cc

@@ -26,6 +26,8 @@
 #include "gtest/gtest.h"
 #include "third_party/imgui/imgui.h"
 
+#define FML_USED_ON_EMBEDDER
+
 namespace impeller {
 namespace testing {
 
@@ -37,10 +39,7 @@ class RendererDartTest : public PlaygroundTest,
         vm_ref_(flutter::DartVMRef::Create(settings_)) {
     fml::MessageLoop::EnsureInitializedForCurrentThread();
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
     current_task_runner_ = fml::MessageLoop::GetCurrent().GetTaskRunner();
-#pragma clang diagnostic pop
 
     isolate_ = CreateDartIsolate();
     assert(isolate_);
@@ -93,10 +92,3 @@ TEST_P(RendererDartTest, CanRunDartInPlaygroundFrame) {
 
 }  // namespace testing
 }  // namespace impeller
-
-int main(int argc, char** argv) {
-  fml::InstallCrashHandler();
-  testing::InitGoogleTest(&argc, argv);
-  fml::CommandLine cmd = fml::CommandLineFromPlatformOrArgcArgv(argc, argv);
-  return RUN_ALL_TESTS();
-}

lib/ui/gpu/context.h

@@ -7,6 +7,7 @@
 
 #include <memory>
 
+#include "flutter/fml/macros.h"
 #include "flutter/fml/memory/ref_counted.h"
 #include "flutter/lib/ui/dart_wrapper.h"
 #include "impeller/renderer/context.h"
@@ -27,6 +28,8 @@ class GpuContext : public RefCountedDartWrappable<GpuContext> {
 
  private:
   std::shared_ptr<impeller::Context> context_;
+
+  FML_DISALLOW_COPY_AND_ASSIGN(GpuContext);
 };
 
 }  // namespace flutter