Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 63738b1

Browse files
committed
Move the major display list classes to their own translation units.
No functional change. Makes the display list subsystem easier to navigate as the major classes are in their own TUs. Also avoids importing unnecessary headers when the previous kitchen sink header was imported. I've tried to remove all display list related imports and start from scratch but I may have missed some files. Minor structs and classes (like the ones in utils, ops, etc..) still don't get their own TUs though. There were [two](#29562) [related](#30484) changes being made to this subsystem that have since landed. So I don't think I am stepping on anyones toes with the reorganization. Happy to incorporate any work-in-progress changes being made to the this subsystem before submitting.
1 parent fb2aa6f commit 63738b1

34 files changed

+3216
-3038
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,12 +34,23 @@ FILE: ../../../flutter/common/task_runners.cc
3434
FILE: ../../../flutter/common/task_runners.h
3535
FILE: ../../../flutter/display_list/display_list.cc
3636
FILE: ../../../flutter/display_list/display_list.h
37-
FILE: ../../../flutter/display_list/display_list_canvas.cc
38-
FILE: ../../../flutter/display_list/display_list_canvas.h
37+
FILE: ../../../flutter/display_list/display_list_builder.cc
38+
FILE: ../../../flutter/display_list/display_list_builder.h
39+
FILE: ../../../flutter/display_list/display_list_canvas_dispatcher.cc
40+
FILE: ../../../flutter/display_list/display_list_canvas_dispatcher.h
41+
FILE: ../../../flutter/display_list/display_list_canvas_recorder.cc
42+
FILE: ../../../flutter/display_list/display_list_canvas_recorder.h
3943
FILE: ../../../flutter/display_list/display_list_canvas_unittests.cc
44+
FILE: ../../../flutter/display_list/display_list_dispatcher.cc
45+
FILE: ../../../flutter/display_list/display_list_dispatcher.h
46+
FILE: ../../../flutter/display_list/display_list_flags.cc
47+
FILE: ../../../flutter/display_list/display_list_flags.h
48+
FILE: ../../../flutter/display_list/display_list_ops.cc
49+
FILE: ../../../flutter/display_list/display_list_ops.h
4050
FILE: ../../../flutter/display_list/display_list_unittests.cc
4151
FILE: ../../../flutter/display_list/display_list_utils.cc
4252
FILE: ../../../flutter/display_list/display_list_utils.h
53+
FILE: ../../../flutter/display_list/types.h
4354
FILE: ../../../flutter/flow/compositor_context.cc
4455
FILE: ../../../flutter/flow/compositor_context.h
4556
FILE: ../../../flutter/flow/diff_context.cc

display_list/BUILD.gn

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,19 @@ source_set("display_list") {
66
sources = [
77
"display_list.cc",
88
"display_list.h",
9-
"display_list_canvas.cc",
10-
"display_list_canvas.h",
9+
"display_list_builder.cc",
10+
"display_list_builder.h",
11+
"display_list_canvas_dispatcher.cc",
12+
"display_list_canvas_dispatcher.h",
13+
"display_list_canvas_recorder.cc",
14+
"display_list_canvas_recorder.h",
15+
"display_list_dispatcher.cc",
16+
"display_list_dispatcher.h",
17+
"display_list_flags.cc",
18+
"display_list_flags.h",
1119
"display_list_utils.cc",
1220
"display_list_utils.h",
21+
"types.h",
1322
]
1423

1524
public_deps = [

0 commit comments

Comments
 (0)