Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 5a38589

Browse files
rmacnak-googlecommit-bot@chromium.org
authored andcommitted
[test] Apply simarm64 status file entries to simarm64c.
Remove references to the removed simarmv6 architecture. TEST=ci Change-Id: I10e9fc8291c3e5b6b9a4bd71ca05de95e53f22c6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187500 Commit-Queue: Ryan Macnak <[email protected]> Reviewed-by: Alexander Markov <[email protected]>
1 parent 0e9f75c commit 5a38589

File tree

27 files changed

+71
-70
lines changed

27 files changed

+71
-70
lines changed

pkg/pkg.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ analysis_server/test/socket_server_test: Skip # Pass, Slow
227227

228228
# Timeout. These tests do not run efficiently on our simulator or low-end
229229
# devices.
230-
[ $runtime == vm && ($arch == armv6 || $arch == simarm || $arch == simarm64 || $arch == simarmv6) ]
230+
[ $runtime == vm && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
231231
*: Skip
232232

233233
[ $mode == debug || $runtime != vm || $system == android ]

pkg/status_file/test/data/vm.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ cc/Read: Fail # TODO(zra): Investigate, ../../dart/runtime/bin/file_test.cc: 34
5050
# On the simluator stack traces produced by the Profiler do not match
5151
# up with the real Dart stack trace and hence we don't get correct
5252
# symbol names.
53-
[ $arch == simarm || $arch == simarmv6 || $arch == simarm64 ]
53+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c]
5454
cc/Service_Profile: Skip
5555
cc/Profiler_AllocationSampleTest: Skip
5656
cc/Profiler_ArrayAllocation: Skip

runtime/observatory/tests/service/service.status

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,11 @@ dds_log_history_size_gigantic_test: Skip # Too slow: dartbug.com/41825
5252
[ $mode == debug && $system == windows && $checked ]
5353
async_scope_test: Pass, Slow
5454

55-
[ $mode == debug && ($arch == simarm || $arch == simarm64) ]
55+
[ $mode == debug && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
5656
*: SkipSlow
5757

5858
# These tests are slow on simulators.
59-
[ $arch == simarm || $arch == simarm64 ]
59+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c ]
6060
*: Pass, Slow
6161

6262
# All tests use dart:io

runtime/observatory/tests/service/service_kernel.status

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ rewind_optimized_out_test: SkipSlow # Timeout
211211
[ $arch == ia32 && $compiler == dartk ]
212212
valid_source_locations_test: Skip # Issue 34736, too slow.
213213

214-
[ $arch != simarm && $arch != simarm64 && $compiler == dartk ]
214+
[ $arch != simarm && $arch != simarm64 && $arch != simarm64c && $compiler == dartk ]
215215
complex_reload_test: RuntimeError
216216

217217
[ $compiler == dartk && $mode == debug ]
@@ -270,7 +270,7 @@ step_through_setter_test: Skip # Issues 32137 and 32138.
270270
step_through_switch_test: Skip # Times out. Issue 32137.
271271
step_through_switch_with_continue_test: Skip # Times out. Issue 32137.
272272

273-
[ $compiler == dartk && ($arch == simarm || $arch == simarm64) ]
273+
[ $compiler == dartk && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
274274
add_breakpoint_rpc_kernel_test: RuntimeError # Issue #34736
275275
async_generator_breakpoint_test: SkipByDesign # No incremental compiler available.
276276
bad_reload_test: Skip # Times out on sim architectures, also RuntimeError.

runtime/observatory_2/tests/service_2/service_2.status

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ dds_log_history_size_gigantic_test: Skip # Too slow: dartbug.com/41825
5454
[ $mode == debug && $system == windows && $checked ]
5555
async_scope_test: Pass, Slow
5656

57-
[ $mode == debug && ($arch == simarm || $arch == simarm64) ]
57+
[ $mode == debug && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
5858
*: SkipSlow
5959

6060
# These tests are slow on simulators.
61-
[ $arch == simarm || $arch == simarm64 ]
61+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c ]
6262
*: Pass, Slow
6363

6464
# All tests use dart:io

runtime/observatory_2/tests/service_2/service_2_kernel.status

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ rewind_optimized_out_test: SkipSlow # Timeout
210210
[ $arch == ia32 && $compiler == dartk ]
211211
valid_source_locations_test: Skip # Issue 34736, too slow.
212212

213-
[ $arch != simarm && $arch != simarm64 && $compiler == dartk ]
213+
[ $arch != simarm && $arch != simarm64 && $arch != simarm64c && $compiler == dartk ]
214214
complex_reload_test: RuntimeError
215215

216216
[ $compiler == dartk && $mode == debug ]
@@ -269,7 +269,7 @@ step_through_setter_test: Skip # Issues 32137 and 32138.
269269
step_through_switch_test: Skip # Times out. Issue 32137.
270270
step_through_switch_with_continue_test: Skip # Times out. Issue 32137.
271271

272-
[ $compiler == dartk && ($arch == simarm || $arch == simarm64) ]
272+
[ $compiler == dartk && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
273273
add_breakpoint_rpc_kernel_test: RuntimeError # Issue #34736
274274
async_generator_breakpoint_test: SkipByDesign # No incremental compiler available.
275275
bad_reload_test: Skip # Times out on sim architectures, also RuntimeError.

runtime/tests/vm/vm.status

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ dart_2/isolates/dart_api_create_lightweight_isolate_test: SkipByDesign # https:/
176176
dart/transferable_test: Skip # This is performance test and somehow debug win ia32 bot's performance is unpredictable
177177
dart_2/transferable_test: Skip # This is performance test and somehow debug win ia32 bot's performance is unpredictable
178178

179-
[ $arch != simarm && $arch != simarm64 && $compiler == dartk && $hot_reload ]
179+
[ $arch != simarm && $arch != simarm64 && $arch != simarm64c && $compiler == dartk && $hot_reload ]
180180
dart/data_uri_import_test/base64: Crash
181181
dart/data_uri_import_test/nocharset: Crash
182182
dart/data_uri_import_test/nomime: Crash
@@ -207,7 +207,7 @@ dart_2/regress_37382_test: SkipByDesign # Matches the type arguments names
207207
# Enabling of dartk for sim{arm,arm64} revelaed these test failures, which
208208
# are to be triaged. Isolate tests are skipped on purpose due to the usage of
209209
# batch mode.
210-
[ $compiler == dartk && $mode == debug && ($arch == simarm || $arch == simarm64) ]
210+
[ $compiler == dartk && $mode == debug && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
211211
cc/StackTraceMallocHookLengthTest: Fail # Please triage.
212212

213213
[ $compiler == dartk && $mode == product && $runtime == vm ]
@@ -245,7 +245,7 @@ cc/IsolateReload_LibraryLookup: Fail, Crash
245245
dart/redirection_type_shuffling_test/00: Pass # Works in --checked mode but not in --strong mode.
246246
dart_2/redirection_type_shuffling_test/00: Pass # Works in --checked mode but not in --strong mode.
247247

248-
[ $compiler == dartk && ($arch == simarm || $arch == simarm64) ]
248+
[ $compiler == dartk && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
249249
dart/appjit*: SkipSlow # DFE too slow
250250
dart/b162922506_test: SkipSlow # Generates large input file
251251
dart/data_uri_spawn_test: Skip # Please triage.
@@ -279,7 +279,7 @@ dart_2/minimal_kernel_test: SkipByDesign # Test needs to run from source
279279
dart_2/null_safety_autodetection_in_kernel_compiler_test: SkipByDesign # Test needs to run from source
280280
dart_2/snapshot_depfile_test: SkipByDesign # Test needs to run from source
281281

282-
[ $compiler == dartkp && ($arch == simarm || $arch == simarm64) ]
282+
[ $compiler == dartkp && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
283283
dart/causal_stacks/async_throws_stack_lazy_non_symbolic_test: Pass, Slow
284284
dart_2/causal_stacks/async_throws_stack_lazy_non_symbolic_test: Pass, Slow
285285

@@ -311,14 +311,14 @@ dart_2/catch_entry_state: SkipByDesign
311311
[ $system != fuchsia && ($arch != x64 || $system != linux) ]
312312
cc/CodeExecutability: SkipByDesign # --dual-map-code not supported on non-Linux/Fuchsia
313313

314-
[ $arch == arm || $arch == arm64 || $builder_tag == crossword || $builder_tag == crossword_ast || $compiler != dartkp || $system == linux && ($arch == simarm || $arch == simarm64) ]
314+
[ $arch == arm || $arch == arm64 || $builder_tag == crossword || $builder_tag == crossword_ast || $compiler != dartkp || $system == linux && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
315315
dart/v8_snapshot_profile_writer_test: SkipByDesign # Only relevant for AOT. Doesn't work in cross-compilation (has to run on the host). On Linux/simarm64 and Linux/simarm this test requires buildtools/clang which is not always available on testing shards.
316316
dart_2/v8_snapshot_profile_writer_test: SkipByDesign # Only relevant for AOT. Doesn't work in cross-compilation (has to run on the host). On Linux/simarm64 and Linux/simarm this test requires buildtools/clang which is not always available on testing shards.
317317

318318
# On the simluator stack traces produced by the Profiler do not match
319319
# up with the real Dart stack trace and hence we don't get correct
320320
# symbol names.
321-
[ $arch == simarm || $arch == simarm64 ]
321+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c ]
322322
cc/LargeMap: SkipByDesign
323323
cc/Profiler_AllocationSampleTest: SkipByDesign
324324
cc/Profiler_ArrayAllocation: SkipByDesign
@@ -360,15 +360,15 @@ dart_2/unboxed_param_args_descriptor_test: SkipByDesign # FFI helper not support
360360
dart_2/unboxed_param_tear_off_test: SkipByDesign # FFI helper not supported on simulator
361361
dart_2/unboxed_param_test: SkipByDesign # FFI helper not supported on simulator
362362

363-
[ $arch == simarm || $arch == simarm64 || $system != macos ]
363+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $system != macos ]
364364
dart/thread_priority_macos_test: SkipByDesign
365365
dart_2/thread_priority_macos_test: SkipByDesign
366366

367-
[ $arch == simarm || $arch == simarm64 || $system != windows ]
367+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $system != windows ]
368368
dart/thread_priority_windows_test: SkipByDesign
369369
dart_2/thread_priority_windows_test: SkipByDesign
370370

371-
[ $arch == simarm || $arch == simarm64 || $system != android && $system != linux ]
371+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c || $system != android && $system != linux ]
372372
dart/thread_priority_linux_test: SkipByDesign
373373
dart_2/thread_priority_linux_test: SkipByDesign
374374

@@ -410,7 +410,7 @@ dart_2/*: SkipByDesign # Legacy tests are not supposed to run on NNBD bots.
410410
# as that would involve running CFE (the front end) in simulator mode
411411
# to compile the URI file specified in spawnURI code.
412412
# These Isolate tests that use spawnURI are hence skipped on purpose.
413-
[ $runtime == dart_precompiled || $runtime == vm && ($arch == simarm || $arch == simarm64) ]
413+
[ $runtime == dart_precompiled || $runtime == vm && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
414414
dart/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri
415415
dart/issue32950_test: SkipByDesign # uses spawnUri.
416416
dart_2/data_uri_spawn_test: SkipByDesign # Isolate.spawnUri

samples/samples.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ sample_extension/test/sample_extension_app_snapshot_test: Pass, RuntimeError # I
2020
[ $compiler == none && $runtime == vm && $system == fuchsia ]
2121
*: Skip # Not yet triaged.
2222

23-
[ $arch == simarm || $arch == simarm64 ]
23+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c ]
2424
ffi/*: SkipByDesign # FFI skips, see ffi.status
2525

2626
[ $arch != x64 || $compiler != dartk || $system != linux || $hot_reload || $hot_reload_rollback ]

samples_2/samples_2.status

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ sample_extension/test/sample_extension_app_snapshot_test: Pass, RuntimeError # I
2020
[ $compiler == none && $runtime == vm && $system == fuchsia ]
2121
*: Skip # Not yet triaged.
2222

23-
[ $arch == simarm || $arch == simarm64 ]
23+
[ $arch == simarm || $arch == simarm64 || $arch == simarm64c ]
2424
ffi/*: SkipByDesign # FFI skips, see ffi.status
2525

2626
[ $arch != x64 || $compiler != dartk || $system != linux || $hot_reload || $hot_reload_rollback ]

tests/co19/co19-kernel.status

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,6 @@ LanguageFeatures/Set-literals/disambiguating_A02_t03: Crash
184184
LanguageFeatures/regression/34803_t01: Crash
185185
LanguageFeatures/regression/34803_t02: Crash
186186

187-
[ $arch == simarm64 && $runtime == dart_precompiled ]
188-
LibTest/collection/ListBase/ListBase_class_A01_t01: Skip # Issue 43036
189-
LibTest/collection/ListMixin/ListMixin_class_A01_t01: Skip # Issue 43036
190-
191187
[ $compiler == dartk && $runtime == vm && $system == linux ]
192188
LibTest/isolate/Isolate/spawn_A06_t03: Crash
193189

@@ -202,9 +198,13 @@ LibTest/core/List/List_class_A01_t03: Slow, Pass
202198
[ $compiler == dartk && $runtime != vm ]
203199
Language/Classes/Constructors/Constant_Constructors/potentially_constant_expression_t01: Crash
204200

201+
[ $runtime == dart_precompiled && ($arch == simarm64 || $arch == simarm64c) ]
202+
LibTest/collection/ListBase/ListBase_class_A01_t01: Skip # Issue 43036
203+
LibTest/collection/ListMixin/ListMixin_class_A01_t01: Skip # Issue 43036
204+
205205
# It makes no sense to run any test that uses spawnURI under the simulator
206206
# as that would involve running CFE (the front end) in simulator mode
207207
# to compile the URI file specified in spawnURI code.
208208
# These Isolate tests that use spawnURI are hence skipped on purpose.
209-
[ $runtime == dart_precompiled || $runtime == vm && ($arch == simarm || $arch == simarm64) ]
209+
[ $runtime == dart_precompiled || $runtime == vm && ($arch == simarm || $arch == simarm64 || $arch == simarm64c) ]
210210
LibTest/isolate/Isolate/spawnUri*: Skip

0 commit comments

Comments
 (0)