[web] remove implicit casts and implicit dynamic (#27882)

Author: yjbanov

lib/web_ui/analysis_options.yaml

@@ -6,11 +6,6 @@
 
 include: ../../analysis_options.yaml
 
-analyzer:
-  strong-mode:
-    implicit-casts: true
-    implicit-dynamic: true
-
 linter:
   rules:
     public_member_api_docs: false

lib/web_ui/lib/src/engine/assets.dart

@@ -61,7 +61,7 @@ class AssetManager {
       final html.HttpRequest request =
           await html.HttpRequest.request(url, responseType: 'arraybuffer');
 
-      final ByteBuffer response = request.response;
+      final ByteBuffer response = request.response as ByteBuffer;
       return response.asByteData();
     } on html.ProgressEvent catch (e) {
       final html.EventTarget? target = e.target;

lib/web_ui/lib/src/engine/canvaskit/font_fallbacks.dart

@@ -969,8 +969,8 @@ class NotoDownloader {
     if (assertionsEnabled) {
       _debugActiveDownloadCount += 1;
     }
-    final Future<ByteBuffer> result = html.window.fetch(url).then(
-        (dynamic fetchResult) => fetchResult
+    final Future<ByteBuffer> result = httpFetch(url).then(
+        (html.Body fetchResult) => fetchResult
             .arrayBuffer()
             .then<ByteBuffer>((dynamic x) => x as ByteBuffer));
     if (assertionsEnabled) {
@@ -988,8 +988,8 @@ class NotoDownloader {
     if (assertionsEnabled) {
       _debugActiveDownloadCount += 1;
     }
-    final Future<String> result = html.window.fetch(url).then(
-        (dynamic response) =>
+    final Future<String> result = httpFetch(url).then(
+        (html.Body response) =>
             response.text().then<String>((dynamic x) => x as String));
     if (assertionsEnabled) {
       result.whenComplete(() {

lib/web_ui/lib/src/engine/canvaskit/fonts.dart

@@ -109,7 +109,7 @@ class SkiaFontCollection {
     }
 
     final List<dynamic>? fontManifest =
-        json.decode(utf8.decode(byteData.buffer.asUint8List()));
+        json.decode(utf8.decode(byteData.buffer.asUint8List())) as List<dynamic>?;
     if (fontManifest == null) {
       throw AssertionError(
           'There was a problem trying to load FontManifest.json');
@@ -119,16 +119,16 @@ class SkiaFontCollection {
 
     for (final Map<String, dynamic> fontFamily
         in fontManifest.cast<Map<String, dynamic>>()) {
-      final String family = fontFamily['family']!;
-      final List<dynamic> fontAssets = fontFamily['fonts'];
+      final String family = fontFamily.readString('family');
+      final List<dynamic> fontAssets = fontFamily.readList('fonts');
 
       if (family == 'Roboto') {
         registeredRoboto = true;
       }
 
       for (final dynamic fontAssetItem in fontAssets) {
-        final Map<String, dynamic> fontAsset = fontAssetItem;
-        final String asset = fontAsset['asset'];
+        final Map<String, dynamic> fontAsset = fontAssetItem as Map<String, dynamic>;
+        final String asset = fontAsset.readString('asset');
         _unloadedFonts
             .add(_registerFont(assetManager.getAssetUrl(asset), family));
       }
@@ -151,7 +151,7 @@ class SkiaFontCollection {
   Future<RegisteredFont?> _registerFont(String url, String family) async {
     ByteBuffer buffer;
     try {
-      buffer = await html.window.fetch(url).then(_getArrayBuffer);
+      buffer = await httpFetch(url).then(_getArrayBuffer);
     } catch (e) {
       printWarning('Failed to load font $family at $url');
       printWarning(e.toString());
@@ -178,8 +178,7 @@ class SkiaFontCollection {
     return actualFamily;
   }
 
-  Future<ByteBuffer> _getArrayBuffer(dynamic fetchResult) {
-    // TODO(yjbanov): fetchResult.arrayBuffer is a dynamic invocation. Clean it up.
+  Future<ByteBuffer> _getArrayBuffer(html.Body fetchResult) {
     return fetchResult
         .arrayBuffer()
         .then<ByteBuffer>((dynamic x) => x as ByteBuffer);

lib/web_ui/lib/src/engine/canvaskit/initialization.dart

@@ -179,7 +179,7 @@ void _startDownloadingCanvasKit(String? canvasKitBase) {
 
     // First check if `exports` and `module` are already defined. If so, then
     // CommonJS is being used, and we shouldn't have any problems.
-    final js.JsFunction objectConstructor = js.context['Object'];
+    final js.JsFunction objectConstructor = js.context['Object'] as js.JsFunction;
     if (js.context['exports'] == null) {
       final js.JsObject exportsAccessor = js.JsObject.jsify(<String, dynamic>{
         'get': js.allowInterop(() {

lib/web_ui/lib/src/engine/canvaskit/layer.dart

@@ -361,7 +361,7 @@ class TransformEngineLayer extends ContainerLayer
 
   @override
   void preroll(PrerollContext prerollContext, Matrix4 matrix) {
-    final Matrix4 childMatrix = matrix * _transform;
+    final Matrix4 childMatrix = matrix.multiplied(_transform);
     prerollContext.mutatorsStack.pushTransform(_transform);
     final ui.Rect childPaintBounds = prerollChildren(prerollContext, childMatrix);
     paintBounds = transformRect(_transform, childPaintBounds);

lib/web_ui/lib/src/engine/canvaskit/text.dart

@@ -725,7 +725,7 @@ class CkParagraph extends SkiaObject<SkParagraph> implements ui.Paragraph {
     final List<ui.TextBox> result = <ui.TextBox>[];
 
     for (int i = 0; i < skRects.length; i++) {
-      final List<double> rect = skRects[i];
+      final List<double> rect = skRects[i] as List<double>;
       result.add(ui.TextBox.fromLTRBD(
         rect[0],
         rect[1],

lib/web_ui/lib/src/engine/clipboard.dart

@@ -25,7 +25,7 @@ class ClipboardMessageHandler {
     const MethodCodec codec = JSONMethodCodec();
     bool errorEnvelopeEncoded = false;
     _copyToClipboardStrategy
-        .setData(methodCall.arguments['text'])
+        .setData(methodCall.arguments['text'] as String?)
         .then((bool success) {
       if (success) {
         callback!(codec.encodeSuccessEnvelope(true));

lib/web_ui/lib/src/engine/dom_renderer.dart

@@ -115,12 +115,12 @@ class DomRenderer {
   /// See for more details:
   /// https://developer.mozilla.org/en-US/docs/Web/API/Document/hasFocus
   bool get windowHasFocus =>
-      js_util.callMethod(html.document, 'hasFocus', <dynamic>[]) ?? false;
+      js_util.callMethod(html.document, 'hasFocus', <dynamic>[]) as bool;
 
   void _setupHotRestart() {
     // This persists across hot restarts to clear stale DOM.
     _staleHotRestartState =
-        js_util.getProperty(html.window, _staleHotRestartStore);
+        js_util.getProperty(html.window, _staleHotRestartStore) as List<html.Element?>?;
     if (_staleHotRestartState == null) {
       _staleHotRestartState = <html.Element?>[];
       js_util.setProperty(
@@ -238,7 +238,10 @@ class DomRenderer {
 
   static void setElementTransform(html.Element element, String transformValue) {
     js_util.setProperty(
-        js_util.getProperty(element, 'style'), 'transform', transformValue);
+      js_util.getProperty(element, 'style') as Object,
+      'transform',
+      transformValue,
+    );
   }
 
   void setText(html.Element element, String text) {
@@ -571,7 +574,7 @@ class DomRenderer {
           return Future<bool>.value(true);
         } else {
           final String? lockType =
-              _deviceOrientationToLockType(orientations.first);
+              _deviceOrientationToLockType(orientations.first as String?);
           if (lockType != null) {
             final Completer<bool> completer = Completer<bool>();
             try {

lib/web_ui/lib/src/engine/html/offscreen_canvas.dart

@@ -69,15 +69,16 @@ class OffScreenCanvas {
           0, 0, width, height]);
   }
 
-  /// Converts canvas contents to an image and returns as data url.
+  /// Converts canvas contents to an image and returns as data URL.
   Future<String> toDataUrl() {
     final Completer<String> completer = Completer<String>();
     if (offScreenCanvas != null) {
       offScreenCanvas!.convertToBlob().then((html.Blob value) {
         final html.FileReader fileReader = html.FileReader();
         fileReader.onLoad.listen((html.ProgressEvent event) {
-          completer.complete(js_util.getProperty(
-              js_util.getProperty(event, 'target')!, 'result')!);
+          completer.complete(
+            js_util.getProperty(js_util.getProperty(event, 'target') as Object, 'result') as String,
+          );
         });
         fileReader.readAsDataUrl(value);
       });