Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 581e67b

Browse files
authored
Update legacy call to SkImage::makeSubset (#43786)
In https://skia-review.googlesource.com/c/skia/+/671679 Skia updated the calls to SkImage::makeSubset() to always need a `GrDirectContext*`. This updates Flutter's one call that needed it. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent eb22852 commit 581e67b

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

shell/platform/embedder/tests/embedder_unittests_util.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ bool ImageMatchesFixture(const std::string& fixture_file_name,
168168
FML_CHECK(scene_image) << "Invalid scene image.";
169169

170170
auto scene_image_subset = scene_image->makeSubset(
171+
nullptr,
171172
SkIRect::MakeWH(fixture_image->width(), fixture_image->height()));
172173

173174
FML_CHECK(scene_image_subset)

0 commit comments

Comments
 (0)