Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 56e3f36

Browse files
authored
Fix usage of --out-dir with a relative path. (#50992)
@dnfield: > it looks like the new dart script doesn't necessarily work well with relative directories for the out dir
1 parent 984eb25 commit 56e3f36

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

testing/scenario_app/bin/run_android_tests.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,9 @@ Future<void> _run({
401401
// TODO(matanlurey): Resolve this in a better way. On CI this file always exists.
402402
File(join(screenshotPath, 'noop.txt')).writeAsStringSync('');
403403
// TODO(gaaclarke): We should move this into dir_contents_diff.
404-
_withTemporaryCwd(dirname(contentsGolden), () {
405-
final int exitCode = dirContentsDiff(basename(contentsGolden), screenshotPath);
404+
final String diffScreenhotPath = absolute(screenshotPath);
405+
_withTemporaryCwd(absolute(dirname(contentsGolden)), () {
406+
final int exitCode = dirContentsDiff(basename(contentsGolden), diffScreenhotPath);
406407
if (exitCode != 0) {
407408
panic(<String>['Output contents incorrect.']);
408409
}

0 commit comments

Comments
 (0)