Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 5578fc8

Browse files
Brandon SchadeCommit Bot
authored andcommitted
Vulkan: Disable EXT_texture_sRGB_R8
Due to a dEQP bug, EXT_texture_sRGB_R8 cannot be exposed before EXT_texture_sRGB_decode is available. This change disables EXT_texture_sRGB_R8 on the vulkan backend. Bug: angleproject:3609 Test: dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.* Change-Id: I261c80986484e489f6903eb54ac6865433050bfa Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2161985 Reviewed-by: Jamie Madill <[email protected]> Reviewed-by: Cody Northrop <[email protected]> Commit-Queue: Mohan Maiya <[email protected]>
1 parent 2362182 commit 5578fc8

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

src/libANGLE/renderer/vulkan/vk_caps_utils.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ void RendererVk::ensureCapsInitialized() const
4848

4949
mNativeExtensions.setTextureExtensionSupport(mNativeTextureCaps);
5050

51+
// TODO: http://anglebug.com/3609
52+
// Due to a dEQP bug, this extension cannot be exposed until EXT_texture_sRGB_decode is
53+
// implemented
54+
mNativeExtensions.sRGBR8EXT = false;
55+
5156
// To ensure that ETC2/EAC formats are enabled only on hardware that supports them natively,
5257
// this flag is not set by the function above and must be set explicitly. It exposes
5358
// ANGLE_compressed_texture_etc extension string.

src/tests/deqp_support/deqp_gles31_test_expectations.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -271,4 +271,3 @@
271271
4371 VULKAN ANDROID : dEQP-GLES31.functional.shaders.implicit_conversions.es31.arithmetic.input_before_literal.add.int_to_vec3_vertex = FAIL
272272
4371 VULKAN ANDROID : dEQP-GLES31.functional.shaders.implicit_conversions.es31.arithmetic.input_before_literal.add.int_to_uvec3_vertex = FAIL
273273
4371 SWIFTSHADER : dEQP-GLES31.functional.shaders.implicit_conversions.* = FAIL
274-
3609 VULKAN : dEQP-GLES31.functional.srgb_texture_decode.skip_decode.sr8.* = FAIL

0 commit comments

Comments
 (0)