Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 4941d1d

Browse files
committed
Wait for GL command completion in the ExternalTextureGLRefreshedTooOften test
This test caused assertion failures when running on Windows with ANGLE if GL commands are pending when the test exits and the process shuts down.
1 parent 7a4a267 commit 4941d1d

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

shell/platform/embedder/tests/embedder_gl_unittests.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4019,10 +4019,14 @@ TEST_F(EmbedderTest, ExternalTextureGLRefreshedTooOften) {
40194019
auto context = surface.GetGrContext();
40204020

40214021
typedef void (*glGenTexturesProc)(uint32_t n, uint32_t* textures);
4022+
typedef void (*glFinishProc)();
4023+
40224024
glGenTexturesProc glGenTextures;
4025+
glFinishProc glFinish;
40234026

40244027
glGenTextures = reinterpret_cast<glGenTexturesProc>(
40254028
surface.GetProcAddress("glGenTextures"));
4029+
glFinish = reinterpret_cast<glFinishProc>(surface.GetProcAddress("glFinish"));
40264030

40274031
uint32_t name;
40284032
glGenTextures(1, &name);
@@ -4067,6 +4071,8 @@ TEST_F(EmbedderTest, ExternalTextureGLRefreshedTooOften) {
40674071
DlImageSampling::kLinear);
40684072

40694073
EXPECT_TRUE(resolve_called);
4074+
4075+
glFinish();
40704076
}
40714077

40724078
TEST_F(EmbedderTest,

0 commit comments

Comments
 (0)