Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 4846886

Browse files
authored
[Impeller] Remove Entity capture/AiksInspector. (#52526)
Resolves flutter/flutter#134748. This was a really fun experiment. I learned a lot from it, and it genuinely helped me solve some coverage-related problems, but the reality is it was too little too late -- by the time we had this capture system, we had already solved most of the problems that would have benefitted from this. It's been a few months since I've used or extended the capabilities of this capture system for something, and I don't have the spare time/energy to give it the love it needs to realize the vision I had for it. I still almost exclusively use a combination of native frame captures and print debugging to solve problems. RIP in peace.
1 parent c380e9f commit 4846886

26 files changed

+18
-1004
lines changed

ci/licenses_golden/licenses_flutter

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40209,8 +40209,6 @@ ORIGIN: ../../../flutter/impeller/aiks/aiks_context.cc + ../../../flutter/LICENS
4020940209
ORIGIN: ../../../flutter/impeller/aiks/aiks_context.h + ../../../flutter/LICENSE
4021040210
ORIGIN: ../../../flutter/impeller/aiks/aiks_playground.cc + ../../../flutter/LICENSE
4021140211
ORIGIN: ../../../flutter/impeller/aiks/aiks_playground.h + ../../../flutter/LICENSE
40212-
ORIGIN: ../../../flutter/impeller/aiks/aiks_playground_inspector.cc + ../../../flutter/LICENSE
40213-
ORIGIN: ../../../flutter/impeller/aiks/aiks_playground_inspector.h + ../../../flutter/LICENSE
4021440212
ORIGIN: ../../../flutter/impeller/aiks/canvas.cc + ../../../flutter/LICENSE
4021540213
ORIGIN: ../../../flutter/impeller/aiks/canvas.h + ../../../flutter/LICENSE
4021640214
ORIGIN: ../../../flutter/impeller/aiks/canvas_benchmarks.cc + ../../../flutter/LICENSE
@@ -40312,8 +40310,6 @@ ORIGIN: ../../../flutter/impeller/core/allocator.cc + ../../../flutter/LICENSE
4031240310
ORIGIN: ../../../flutter/impeller/core/allocator.h + ../../../flutter/LICENSE
4031340311
ORIGIN: ../../../flutter/impeller/core/buffer_view.cc + ../../../flutter/LICENSE
4031440312
ORIGIN: ../../../flutter/impeller/core/buffer_view.h + ../../../flutter/LICENSE
40315-
ORIGIN: ../../../flutter/impeller/core/capture.cc + ../../../flutter/LICENSE
40316-
ORIGIN: ../../../flutter/impeller/core/capture.h + ../../../flutter/LICENSE
4031740313
ORIGIN: ../../../flutter/impeller/core/device_buffer.cc + ../../../flutter/LICENSE
4031840314
ORIGIN: ../../../flutter/impeller/core/device_buffer.h + ../../../flutter/LICENSE
4031940315
ORIGIN: ../../../flutter/impeller/core/device_buffer_descriptor.cc + ../../../flutter/LICENSE
@@ -43092,8 +43088,6 @@ FILE: ../../../flutter/impeller/aiks/aiks_context.cc
4309243088
FILE: ../../../flutter/impeller/aiks/aiks_context.h
4309343089
FILE: ../../../flutter/impeller/aiks/aiks_playground.cc
4309443090
FILE: ../../../flutter/impeller/aiks/aiks_playground.h
43095-
FILE: ../../../flutter/impeller/aiks/aiks_playground_inspector.cc
43096-
FILE: ../../../flutter/impeller/aiks/aiks_playground_inspector.h
4309743091
FILE: ../../../flutter/impeller/aiks/canvas.cc
4309843092
FILE: ../../../flutter/impeller/aiks/canvas.h
4309943093
FILE: ../../../flutter/impeller/aiks/canvas_benchmarks.cc
@@ -43195,8 +43189,6 @@ FILE: ../../../flutter/impeller/core/allocator.cc
4319543189
FILE: ../../../flutter/impeller/core/allocator.h
4319643190
FILE: ../../../flutter/impeller/core/buffer_view.cc
4319743191
FILE: ../../../flutter/impeller/core/buffer_view.h
43198-
FILE: ../../../flutter/impeller/core/capture.cc
43199-
FILE: ../../../flutter/impeller/core/capture.h
4320043192
FILE: ../../../flutter/impeller/core/device_buffer.cc
4320143193
FILE: ../../../flutter/impeller/core/device_buffer.h
4320243194
FILE: ../../../flutter/impeller/core/device_buffer_descriptor.cc

impeller/BUILD.gn

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,6 @@ config("impeller_public_config") {
1414
defines += [ "IMPELLER_DEBUG=1" ]
1515
}
1616

17-
if (impeller_capture) {
18-
defines += [ "IMPELLER_ENABLE_CAPTURE=1" ]
19-
}
20-
2117
if (impeller_supports_rendering) {
2218
defines += [ "IMPELLER_SUPPORTS_RENDERING=1" ]
2319
}

impeller/aiks/BUILD.gn

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ impeller_component("aiks_playground") {
5757
sources = [
5858
"aiks_playground.cc",
5959
"aiks_playground.h",
60-
"aiks_playground_inspector.cc",
61-
"aiks_playground_inspector.h",
6260
]
6361
deps = [
6462
":aiks",

impeller/aiks/aiks_playground.cc

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ void AiksPlayground::SetTypographerContext(
2323
}
2424

2525
void AiksPlayground::TearDown() {
26-
inspector_.HackResetDueToTextureLeaks();
2726
PlaygroundTest::TearDown();
2827
}
2928

@@ -45,9 +44,8 @@ bool AiksPlayground::OpenPlaygroundHere(AiksPlaygroundCallback callback) {
4544
}
4645

4746
return Playground::OpenPlaygroundHere(
48-
[this, &renderer, &callback](RenderTarget& render_target) -> bool {
49-
const std::optional<Picture>& picture = inspector_.RenderInspector(
50-
renderer, [&]() { return callback(renderer); });
47+
[&renderer, &callback](RenderTarget& render_target) -> bool {
48+
const std::optional<Picture>& picture = callback(renderer);
5149

5250
if (!picture.has_value()) {
5351
return false;

impeller/aiks/aiks_playground.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include "flutter/fml/macros.h"
99
#include "impeller/aiks/aiks_context.h"
10-
#include "impeller/aiks/aiks_playground_inspector.h"
1110
#include "impeller/aiks/picture.h"
1211
#include "impeller/playground/playground_test.h"
1312
#include "impeller/typographer/typographer_context.h"
@@ -39,7 +38,6 @@ class AiksPlayground : public PlaygroundTest {
3938

4039
private:
4140
std::shared_ptr<TypographerContext> typographer_context_;
42-
AiksInspector inspector_;
4341

4442
AiksPlayground(const AiksPlayground&) = delete;
4543

impeller/aiks/aiks_playground_inspector.cc

Lines changed: 0 additions & 277 deletions
This file was deleted.

0 commit comments

Comments
 (0)