chinmay feedback1

Author: gaaclarke

impeller/renderer/backend/vulkan/BUILD.gn

@@ -9,8 +9,8 @@ impeller_component("vulkan_unittests") {
   testonly = true
   sources = [
     "blit_command_vk_unittests.cc",
-    "command_buffer_cache_unittests.cc",
     "context_vk_unittests.cc",
+    "pass_bindings_cache_unittests.cc",
     "test/mock_vulkan.cc",
     "test/mock_vulkan.h",
   ]
@@ -30,7 +30,6 @@ impeller_component("vulkan") {
     "blit_pass_vk.h",
     "capabilities_vk.cc",
     "capabilities_vk.h",
-    "command_buffer_cache.h",
     "command_buffer_vk.cc",
     "command_buffer_vk.h",
     "command_encoder_vk.cc",
@@ -53,6 +52,7 @@ impeller_component("vulkan") {
     "fence_waiter_vk.h",
     "formats_vk.cc",
     "formats_vk.h",
+    "pass_bindings_cache.h",
     "pipeline_cache_vk.cc",
     "pipeline_cache_vk.h",
     "pipeline_library_vk.cc",

impeller/renderer/backend/vulkan/command_buffer_cache.h renamed to impeller/renderer/backend/vulkan/pass_bindings_cache.h

@@ -11,7 +11,7 @@
 namespace impeller {
 
 template <typename CommandBuffer>
-class CommandBufferCache {
+class PassBindingsCache {
  public:
   void bindPipeline(CommandBuffer command_buffer,
                     vk::PipelineBindPoint pipeline_bind_point,

impeller/renderer/backend/vulkan/command_buffer_cache_unittests.cc renamed to impeller/renderer/backend/vulkan/pass_bindings_cache_unittests.cc

@@ -3,7 +3,7 @@
 // found in the LICENSE file.
 
 #include "flutter/testing/testing.h"
-#include "impeller/renderer/backend/vulkan/command_buffer_cache.h"
+#include "impeller/renderer/backend/vulkan/pass_bindings_cache.h"
 
 namespace impeller {
 namespace testing {
@@ -45,8 +45,8 @@ class MockCommandBuffer {
 };
 }  // namespace
 
-TEST(CommandBufferCacheTest, bindPipeline) {
-  CommandBufferCache<MockCommandBuffer> cache;
+TEST(PassBindingsCacheTest, bindPipeline) {
+  PassBindingsCache<MockCommandBuffer> cache;
   MockCommandBuffer buffer;
   VkPipeline vk_pipeline = reinterpret_cast<VkPipeline>(0xfeedface);
   vk::Pipeline pipeline(vk_pipeline);
@@ -57,8 +57,8 @@ TEST(CommandBufferCacheTest, bindPipeline) {
   ASSERT_EQ(buffer.tallies_->bindPipeline_count, 1);
 }
 
-TEST(CommandBufferCacheTest, setStencilReference) {
-  CommandBufferCache<MockCommandBuffer> cache;
+TEST(PassBindingsCacheTest, setStencilReference) {
+  PassBindingsCache<MockCommandBuffer> cache;
   MockCommandBuffer buffer;
   ASSERT_EQ(buffer.tallies_->setStencilReference_count, 0);
   cache.setStencilReference(
@@ -69,8 +69,8 @@ TEST(CommandBufferCacheTest, setStencilReference) {
   ASSERT_EQ(buffer.tallies_->setStencilReference_count, 1);
 }
 
-TEST(CommandBufferCacheTest, setScissor) {
-  CommandBufferCache<MockCommandBuffer> cache;
+TEST(PassBindingsCacheTest, setScissor) {
+  PassBindingsCache<MockCommandBuffer> cache;
   MockCommandBuffer buffer;
   vk::Rect2D scissors;
   ASSERT_EQ(buffer.tallies_->setScissor_count, 0);
@@ -80,8 +80,8 @@ TEST(CommandBufferCacheTest, setScissor) {
   ASSERT_EQ(buffer.tallies_->setScissor_count, 1);
 }
 
-TEST(CommandBufferCacheTest, setViewport) {
-  CommandBufferCache<MockCommandBuffer> cache;
+TEST(PassBindingsCacheTest, setViewport) {
+  PassBindingsCache<MockCommandBuffer> cache;
   MockCommandBuffer buffer;
   vk::Viewport viewports;
   ASSERT_EQ(buffer.tallies_->setViewport_count, 0);

impeller/renderer/backend/vulkan/render_pass_vk.cc

@@ -418,7 +418,7 @@ static bool AllocateAndBindDescriptorSets(const ContextVK& context,
 static void SetViewportAndScissor(
     const Command& command,
     const vk::CommandBuffer& cmd_buffer,
-    CommandBufferCache<vk::CommandBuffer>& cmd_buffer_cache,
+    PassBindingsCache<vk::CommandBuffer>& cmd_buffer_cache,
     const ISize& target_size) {
   // Set the viewport.
   const auto& vp = command.viewport.value_or<Viewport>(
@@ -444,7 +444,7 @@ static bool EncodeCommand(
     const Context& context,
     const Command& command,
     CommandEncoderVK& encoder,
-    CommandBufferCache<vk::CommandBuffer>& command_buffer_cache,
+    PassBindingsCache<vk::CommandBuffer>& command_buffer_cache,
     const ISize& target_size) {
   if (command.vertex_count == 0u || command.instance_count == 0u) {
     return true;
@@ -623,7 +623,7 @@ bool RenderPassVK::OnEncodeCommands(const Context& context) const {
         continue;
       }
 
-      if (!EncodeCommand(context, command, *encoder, command_buffer_cache_,
+      if (!EncodeCommand(context, command, *encoder, pass_bindings_cache_,
                          target_size)) {
         return false;
       }

impeller/renderer/backend/vulkan/render_pass_vk.h

@@ -5,8 +5,8 @@
 #pragma once
 
 #include "flutter/fml/macros.h"
-#include "impeller/renderer/backend/vulkan/command_buffer_cache.h"
 #include "impeller/renderer/backend/vulkan/context_vk.h"
+#include "impeller/renderer/backend/vulkan/pass_bindings_cache.h"
 #include "impeller/renderer/backend/vulkan/shared_object_vk.h"
 #include "impeller/renderer/backend/vulkan/texture_vk.h"
 #include "impeller/renderer/backend/vulkan/vk.h"
@@ -27,7 +27,7 @@ class RenderPassVK final : public RenderPass {
   std::weak_ptr<CommandEncoderVK> encoder_;
   std::string debug_label_;
   bool is_valid_ = false;
-  mutable CommandBufferCache<vk::CommandBuffer> command_buffer_cache_;
+  mutable PassBindingsCache<vk::CommandBuffer> pass_bindings_cache_;
 
   RenderPassVK(const std::shared_ptr<const Context>& context,
                const RenderTarget& target,