Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 43b4fef

Browse files
timvpGoogleCommit Bot
authored andcommitted
Revert "Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount"
This reverts commit a5db7d6. Reason for revert: VVL rolled with the fix. Original change's description: > Vulkan: Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount > > Disable UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount while the > Khronos issue is investigated. > > Bug: angleproject:5148 > Change-Id: If3cd4b028182a06411b928417e7c778ea02189d1 > Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2462075 > Reviewed-by: Jamie Madill <[email protected]> > Reviewed-by: Shahbaz Youssefi <[email protected]> > Commit-Queue: Tim Van Patten <[email protected]> [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed > 1 day ago. Bug: angleproject:5148 Change-Id: Ibb66370334554773dda3e849d0bc9f3e8f8577fc Reviewed-on: https://chromium-review.googlesource.com/c/angle/angle/+/2472997 Reviewed-by: Tim Van Patten <[email protected]> Commit-Queue: Tim Van Patten <[email protected]>
1 parent 1ca0c2a commit 43b4fef

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

src/libANGLE/renderer/vulkan/RendererVk.cpp

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -131,15 +131,19 @@ constexpr const char *kSkippedMessages[] = {
131131
"VUID-VkPipelineInputAssemblyStateCreateInfo-topology-00428",
132132
// http://anglebug.com/4063
133133
"VUID-VkDeviceCreateInfo-pNext-pNext",
134-
"VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext", "VUID_Undefined",
134+
"VUID-VkPipelineRasterizationStateCreateInfo-pNext-pNext",
135+
"VUID_Undefined",
135136
// https://issuetracker.google.com/issues/159493191
136-
"VUID-vkCmdDraw-None-02690", "VUID-vkCmdDrawIndexed-None-02690",
137+
"VUID-vkCmdDraw-None-02690",
138+
"VUID-vkCmdDrawIndexed-None-02690",
137139
// http://anglebug.com/4975
138-
"VUID-vkCmdDraw-None-02687", "VUID-vkCmdDrawIndexed-None-02687",
140+
"VUID-vkCmdDraw-None-02687",
141+
"VUID-vkCmdDrawIndexed-None-02687",
139142
// Best Practices Skips https://issuetracker.google.com/issues/166641492
140143
// https://issuetracker.google.com/issues/166793850
141144
"UNASSIGNED-BestPractices-vkCreateCommandPool-command-buffer-reset",
142-
"UNASSIGNED-BestPractices-pipeline-stage-flags", "UNASSIGNED-BestPractices-Error-Result",
145+
"UNASSIGNED-BestPractices-pipeline-stage-flags",
146+
"UNASSIGNED-BestPractices-Error-Result",
143147
"UNASSIGNED-BestPractices-vkAllocateMemory-small-allocation",
144148
"UNASSIGNED-BestPractices-vkBindMemory-small-dedicated-allocation",
145149
"UNASSIGNED-BestPractices-vkAllocateMemory-too-many-objects",
@@ -152,8 +156,7 @@ constexpr const char *kSkippedMessages[] = {
152156
"VUID-vkMapMemory-memory-00683",
153157
// http://anglebug.com/5027
154158
"UNASSIGNED-CoreValidation-Shader-PushConstantOutOfRange",
155-
// http://anglebug.com/5148
156-
"UNASSIGNED-CoreValidation-DevLimit-MissingQueryCount"};
159+
};
157160

158161
// Suppress validation errors that are known
159162
// return "true" if given code/prefix/message is known, else return "false"

0 commit comments

Comments
 (0)