Apply projective coordinate before overriding the final depth in all shaders

Author: bdero

impeller/entity/shaders/blending/framebuffer_blend.vert

@@ -22,6 +22,7 @@ out vec2 v_src_texture_coords;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(vertices, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_src_texture_coords =
       IPRemapCoords(src_texture_coords, frame_info.src_y_coord_scale);

impeller/entity/shaders/blending/porter_duff_blend.vert

@@ -21,6 +21,7 @@ out f16vec4 v_color;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(vertices, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_color = f16vec4(color);
   v_texture_coords =

impeller/entity/shaders/border_mask_blur.vert

@@ -19,6 +19,7 @@ out vec2 v_texture_coords;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
+  gl_Position = / gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_texture_coords =
       IPRemapCoords(texture_coords, frame_info.texture_sampler_y_coord_scale);

impeller/entity/shaders/clip.vert

@@ -14,5 +14,6 @@ in vec2 position;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
 }

impeller/entity/shaders/color_matrix_color_filter.vert

@@ -18,6 +18,7 @@ out vec2 v_texture_coords;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_texture_coords =
       IPRemapCoords(position, frame_info.texture_sampler_y_coord_scale);

impeller/entity/shaders/glyph_atlas.vert

@@ -81,7 +81,7 @@ void main() {
   }
 
   gl_Position = frame_info.mvp * position;
-  gl_Position = gl_Position / gl_Position.w;
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_uv = uv_origin + unit_position * uv_size;
   v_text_color = frame_info.text_color;

impeller/entity/shaders/gradient_fill.vert

@@ -18,6 +18,7 @@ out vec2 v_position;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_position = IPVec2TransformPosition(frame_info.matrix, position);
 }

impeller/entity/shaders/linear_to_srgb_filter.vert

@@ -18,6 +18,7 @@ out vec2 v_texture_coords;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_texture_coords =
       IPRemapCoords(position, frame_info.texture_sampler_y_coord_scale);

impeller/entity/shaders/position_color.vert

@@ -18,6 +18,7 @@ out f16vec4 v_color;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   v_color = f16vec4(color);
 }

impeller/entity/shaders/rrect_blur.vert

@@ -16,6 +16,7 @@ out vec2 v_position;
 
 void main() {
   gl_Position = frame_info.mvp * vec4(position, 0.0, 1.0);
+  gl_Position /= gl_Position.w;
   gl_Position.z = frame_info.depth;
   // The fragment stage uses local coordinates to compute the blur.
   v_position = position;