Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 3a16e52

Browse files
authored
Add temporary staging GN arg for Skia roll (#41743)
In order to enable the new behavior, dl_imagefilter_unittests need to be updated to reflect new bounds mapping values. This requires an atomic PR to disable the legacy arg and update after skia rolls. Required to land https://skia-review.googlesource.com/c/skia/+/693058 and progress on https://skbug.com/9283 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 5824ac8 commit 3a16e52

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/gn

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,7 @@ def to_gn_args(args):
302302
gn_args['skia_use_fontconfig'] = args.enable_fontconfig
303303
gn_args['skia_use_legacy_layer_bounds'
304304
] = True # Temporary: See skbug.com/12083, skbug.com/12303.
305+
gn_args['skia_use_legacy_colorfilter_imagefilter'] = True # Temporary staging
305306
gn_args['skia_use_icu'] = True
306307
gn_args['is_official_build'] = True # Disable Skia test utilities.
307308
gn_args['android_full_debug'

0 commit comments

Comments
 (0)