Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 39740fc

Browse files
committed
Revert "Fix unexpected pointer change (#129765)"
This reverts commit b6ac786.
1 parent 75c30f7 commit 39740fc

File tree

1 file changed

+6
-20
lines changed

1 file changed

+6
-20
lines changed

shell/platform/android/io/flutter/embedding/android/AndroidTouchProcessor.java

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,9 @@
1313
import java.util.HashMap;
1414
import java.util.Map;
1515

16-
import io.flutter.Log;
17-
1816
/** Sends touch information from Android to Flutter in a format that Flutter understands. */
1917
public class AndroidTouchProcessor {
2018

21-
private static final String TAG = "AndroidTouchProcessor";
2219
// Must match the PointerChange enum in pointer.dart.
2320
@IntDef({
2421
PointerChange.CANCEL,
@@ -112,7 +109,6 @@ public AndroidTouchProcessor(@NonNull FlutterRenderer renderer, boolean trackMot
112109
}
113110

114111
public boolean onTouchEvent(@NonNull MotionEvent event) {
115-
Log.v(TAG, "onTouchEvent, event " + event);
116112
return onTouchEvent(event, IDENTITY_TRANSFORM);
117113
}
118114

@@ -190,9 +186,6 @@ public boolean onTouchEvent(@NonNull MotionEvent event, @NonNull Matrix transfor
190186
public boolean onGenericMotionEvent(@NonNull MotionEvent event) {
191187
// Method isFromSource is only available in API 18+ (Jelly Bean MR2)
192188
// Mouse hover support is not implemented for API < 18.
193-
194-
Log.v(TAG, "onGenericMotionEvent, event " + event);
195-
196189
boolean isPointerEvent =
197190
Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR2
198191
&& event.isFromSource(InputDevice.SOURCE_CLASS_POINTER);
@@ -259,7 +252,6 @@ private void addPointerForIndex(
259252
buttons = 0;
260253
}
261254

262-
int panZoomType = -1;
263255
boolean isTrackpadPan = ongoingPans.containsKey(event.getPointerId(pointerIndex));
264256

265257
int signalKind =
@@ -272,14 +264,8 @@ private void addPointerForIndex(
272264
packet.putLong(motionEventId); // motionEventId
273265
packet.putLong(timeStamp); // time_stamp
274266
if (isTrackpadPan) {
275-
panZoomType = getPointerChangeForPanZoom(pointerChange);
276-
if (panZoomType > 0) {
277-
packet.putLong(panZoomType); // change
278-
packet.putLong(PointerDeviceKind.TRACKPAD); // kind
279-
} else {
280-
packet.putLong(pointerChange); // change
281-
packet.putLong(pointerKind); // kind
282-
}
267+
packet.putLong(getPointerChangeForPanZoom(pointerChange)); // change
268+
packet.putLong(PointerDeviceKind.TRACKPAD); // kind
283269
} else {
284270
packet.putLong(pointerChange); // change
285271
packet.putLong(pointerKind); // kind
@@ -288,7 +274,7 @@ private void addPointerForIndex(
288274
packet.putLong(event.getPointerId(pointerIndex)); // device
289275
packet.putLong(0); // pointer_identifier, will be generated in pointer_data_packet_converter.cc.
290276

291-
if (isTrackpadPan && (panZoomType > 0)) {
277+
if (isTrackpadPan) {
292278
float[] panStart = ongoingPans.get(event.getPointerId(pointerIndex));
293279
packet.putDouble(panStart[0]);
294280
packet.putDouble(panStart[1]);
@@ -356,7 +342,7 @@ private void addPointerForIndex(
356342
packet.putDouble(0.0); // scroll_delta_x
357343
}
358344

359-
if (isTrackpadPan && (panZoomType > 0)) {
345+
if (isTrackpadPan) {
360346
float[] panStart = ongoingPans.get(event.getPointerId(pointerIndex));
361347
packet.putDouble(viewToScreenCoords[0] - panStart[0]);
362348
packet.putDouble(viewToScreenCoords[1] - panStart[1]);
@@ -369,7 +355,7 @@ private void addPointerForIndex(
369355
packet.putDouble(1.0); // scale
370356
packet.putDouble(0.0); // rotation
371357

372-
if (isTrackpadPan && (panZoomType == PointerChange.PAN_ZOOM_END)) {
358+
if (isTrackpadPan && getPointerChangeForPanZoom(pointerChange) == PointerChange.PAN_ZOOM_END) {
373359
ongoingPans.remove(event.getPointerId(pointerIndex));
374360
}
375361
}
@@ -415,7 +401,7 @@ private int getPointerChangeForPanZoom(int pointerChange) {
415401
} else if (pointerChange == PointerChange.UP || pointerChange == PointerChange.CANCEL) {
416402
return PointerChange.PAN_ZOOM_END;
417403
}
418-
return -1;
404+
throw new AssertionError("Unexpected pointer change");
419405
}
420406

421407
@PointerDeviceKind

0 commit comments

Comments
 (0)