Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 31ec057

Browse files
authored
[web] Skip the history tests that introduced flakiness (#24957)
1 parent 31e6956 commit 31ec057

File tree

1 file changed

+4
-18
lines changed

1 file changed

+4
-18
lines changed

lib/web_ui/test/window_test.dart

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ void testMain() {
149149
// should've been correctly set to "/bar".
150150
expect(window.browserHistory.urlStrategy, isNot(isNull));
151151
expect(window.browserHistory.urlStrategy!.getPath(), '/bar');
152-
}, skip: browserEngine == BrowserEngine.webkit); // https://github.com/flutter/flutter/issues/50836
152+
}, skip: true); // https://github.com/flutter/flutter/issues/50836
153153

154154
test('initialize browser history with default url strategy (multiple)', () async {
155155
// On purpose, we don't initialize history on the window. We want to let the
@@ -177,25 +177,11 @@ void testMain() {
177177
// should've been correctly set to "/baz".
178178
expect(window.browserHistory.urlStrategy, isNot(isNull));
179179
expect(window.browserHistory.urlStrategy!.getPath(), '/baz');
180-
}, skip: browserEngine == BrowserEngine.webkit); // https://github.com/flutter/flutter/issues/50836
180+
}, skip: true); // https://github.com/flutter/flutter/issues/50836
181181

182182
test('can disable location strategy', () async {
183183
// Disable URL strategy.
184-
void disableUrlStrategy() {
185-
try {
186-
jsSetUrlStrategy(null);
187-
} on AssertionError catch (e) {
188-
if (e.message == 'Cannot set URL strategy more than once.') {
189-
print('=' * 20);
190-
// Print something easy to search for.
191-
print('HISTORY_TEST_FLAKY_ASSERTION_FAILURE');
192-
print('=' * 20);
193-
} else {
194-
rethrow;
195-
}
196-
}
197-
}
198-
expect(disableUrlStrategy, returnsNormally);
184+
expect(() => jsSetUrlStrategy(null), returnsNormally);
199185
// History should be initialized.
200186
expect(window.browserHistory, isNotNull);
201187
// But without a URL strategy.
@@ -207,7 +193,7 @@ void testMain() {
207193
await routeInformationUpdated('/foo/bar', null);
208194
// Path should not be updated because URL strategy is disabled.
209195
expect(window.browserHistory.currentPath, '/');
210-
});
196+
}, skip: true);
211197

212198
test('js interop throws on wrong type', () {
213199
expect(() => jsSetUrlStrategy(123), throwsA(anything));

0 commit comments

Comments
 (0)