Merge branch 'flutter:main' into master

Author: johnsonmh

.ci.yaml

@@ -1 +1,63 @@
-Checks: 'google-*'
+# A YAML format of https://clang.llvm.org/extra/clang-tidy/.
+
+# Prefix check with "-" to ignore.
+Checks: >-
+  bugprone-argument-comment,
+  bugprone-use-after-move,
+  bugprone-unchecked-optional-access,
+  clang-analyzer-*,
+  clang-diagnostic-*,
+  darwin-*,
+  google-*,
+  modernize-use-default-member-init,
+  objc-*,
+  -objc-nsinvocation-argument-lifetime,
+  readability-identifier-naming,
+  -google-build-using-namespace,
+  -google-default-arguments,
+  -google-objc-global-variable-declaration,
+  -google-objc-avoid-throwing-exception,
+  -google-readability-casting,
+  -clang-analyzer-nullability.NullPassedToNonnull,
+  -clang-analyzer-nullability.NullablePassedToNonnull,
+  -clang-analyzer-nullability.NullReturnedFromNonnull,
+  -clang-analyzer-nullability.NullableReturnedFromNonnull,
+  performance-for-range-copy,
+  performance-inefficient-vector-operation,
+  performance-move-const-arg,
+  performance-move-constructor-init,
+  performance-unnecessary-copy-initialization,
+  performance-unnecessary-value-param
+
+CheckOptions:
+  - key: modernize-use-default-member-init.UseAssignment
+    value: true
+  - key: readability-identifier-naming.EnumConstantCase
+    value: "CamelCase"
+  - key: readability-identifier-naming.EnumConstantPrefix
+    value: "k"
+  - key: readability-identifier-naming.GlobalConstantCase
+    value: "CamelCase"
+  - key: readability-identifier-naming.GlobalConstantPrefix
+    value: "k"
+  - key: readability-identifier-naming.PrivateMemberCase
+    value: "lower_case"
+  - key: readability-identifier-naming.PrivateMemberSuffix
+    value: "_"
+
+# Intended to include (lint) all headers except:
+# ... those in ../../gen (generated files don't need to follow clang tidy)
+# ... those in flutter/third_party (we didn't author this code, it's a dep)
+#
+# Unfortunately Clang Tidy uses an ancient version of regular expressions
+# without lookaheads, so the next best thing is to write out every directory
+# except third_party.
+#
+# If we ever add a new root directory, we'll have to update this expression.
+#
+# See the test in ./tools/clang_tidy/test/header_filter_regex_test.dart which
+# should theoretically catch if new directories are added but this regex is not
+# updated.
+#
+# tl;dr: I'm sorry.
+HeaderFilterRegex: "[..\/]+\/flutter\/(assets|benchmarking|build|ci|common|display_list|docs|examples|flow|flutter_frontend_server|flutter_vma|fml|impeller|lib|runtime|shell|skia|sky|testing|tools|vulkan|wasm|web_sdk)\/.*"

.cirrus.yml

@@ -1,59 +1,30 @@
-## Description
+*Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.*
 
-*Replace this paragraph with a description of what this PR is doing. If you're
-modifying existing behavior, describe the existing behavior, how this PR is
-changing it, and what motivated the change.*
+*List which issues are fixed by this PR. You must list at least one issue.*
 
-## Related Issues
+*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
 
-*Replace this paragraph with a list of issues related to this PR from our [issue
-database]. Indicate, which of these issues are resolved or fixed by this PR.
-There should be at least one issue listed here.*
+## Pre-launch Checklist
 
-## Tests
-
-I added the following tests:
-
-*Replace this with a list of the tests that you added as part of this PR. A
-change in behaviour with no test covering it will likely get reverted
-accidentally sooner or later. PRs must include tests for all
-changed/updated/fixed behaviors. See [testing the engine] for instructions on
-writing and running engine tests.*
-
-## Checklist
-
-Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (`[x]`). This will ensure a smooth and quick review process.
-
-- [ ] I read the [contributor guide] and followed the process outlined there for submitting PRs.
+- [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
+- [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
+- [ ] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
+- [ ] I listed at least one issue that this PR fixes in the description above.
+- [ ] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
+- [ ] I updated/added relevant documentation (doc comments with `///`).
 - [ ] I signed the [CLA].
-- [ ] I read and followed the [C++, Objective-C, Java style guides] for the engine.
-- [ ] I read the [tree hygiene] wiki page, which explains my responsibilities.
-- [ ] I updated/added relevant documentation.
 - [ ] All existing and new tests are passing.
-- [ ] I am willing to follow-up on review comments in a timely manner.
-
-
-## Reviewer Checklist
-
-- [ ] I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.
-
-
-## Breaking Change
-
-Did any tests fail when you ran them? Please read [handling breaking changes].
 
-- [ ] No, no existing tests failed, so this is *not* a breaking change.
-- [ ] Yes, this is a breaking change. *If not, delete the remainder of this section.*
-   - [ ] I wrote a design doc: https://flutter.dev/go/template *Replace this with a link to your design doc's short link*
-   - [ ] I got input from the developer relations team, specifically from: *Replace with the names of who gave advice*
-   - [ ] I wrote a migration guide: https://flutter.dev/go/breaking-changes-template *Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes*
+If you need help, consider asking for advice on the #hackers-new channel on [Discord].
 
 <!-- Links -->
-[issue database]: https://github.com/flutter/flutter/issues
-[contributor guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
+[Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
+[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
+[test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
+[Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
+[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
 [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine
-[C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/master/CONTRIBUTING.md#style
 [CLA]: https://cla.developers.google.com/
-[tree hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
-[handling breaking changes]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
-[engine presubmit flakes form]: https://forms.gle/Wc1VyFRYJjQTH6w5A
+[flutter/tests]: https://github.com/flutter/tests
+[breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
+[Discord]: https://github.com/flutter/flutter/wiki/Chat

.clang-tidy

@@ -0,0 +1,23 @@
+# See Dependabot documentation for all configuration options:
+# https://help.github.com/github/administering-a-repository/configuration-options-for-dependency-updates
+
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"
+      time: "22:00" # 10 PM MTV
+      timezone: "America/Los_Angeles"
+    labels:
+      - "autosubmit"
+    ignore:
+      # ignore patch versions, just rely on minor in order to update fewer times
+      - dependency-name: "github/codeql-action"
+        update-types: ["version-update:semver-minor"]
+  - package-ecosystem: "pub"
+    directory: "/lib/web_ui"
+    schedule:
+      interval: "daily"
+    labels:
+      - "autosubmit"

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,60 @@
+# Copyright 2013 The Flutter Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# See https://github.com/actions/labeler/blob/main/README.md for docs.
+'affects: desktop':
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/darwin/common/**/*
+      - shell/platform/darwin/macos/**/*
+      - shell/platform/linux/**/*
+      - shell/platform/windows/**/*
+
+embedder:
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/embedder
+
+'e: impeller':
+  - changed-files:
+    - any-glob-to-any-file:
+      - impeller/**/*
+
+platform-android:
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/android/**/*
+
+platform-ios:
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/darwin/common/**/*
+      - shell/platform/darwin/ios/**/*
+
+platform-fuchsia:
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/fuchsia/**/*
+
+platform-linux:
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/linux/**/*
+
+platform-macos:
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/darwin/common/**/*
+      - shell/platform/darwin/macos/**/*
+
+platform-web:
+  - changed-files:
+    - any-glob-to-any-file:
+      - lib/web_ui/**/*
+      - '**/web_sdk/**/*'
+
+platform-windows:
+  - changed-files:
+    - any-glob-to-any-file:
+      - shell/platform/windows/**/*

.github/dependabot.yml

@@ -0,0 +1,25 @@
+changelog:
+  exclude:
+    authors:
+      - skia-flutter-autoroll
+      - dependabot
+  categories:
+    - title: Impeller
+      labels:
+        - "e: impeller"
+    - title: Android
+      labels:
+        - platform-android
+    - title: iOS
+      labels:
+        - platform-ios
+    - title: Web
+      labels:
+        - platform-web
+    - title: Desktop
+      labels:
+        - platform-windows
+        - platform-macos
+    - title: Other Changes
+      labels:
+        - "*"

.github/labeler.yml

@@ -0,0 +1,20 @@
+# Copyright 2013 The Flutter Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+name: "Pull Request Labeler"
+on:
+- pull_request_target
+
+# Declare default permissions as read only.
+permissions: read-all
+
+jobs:
+  triage:
+    if: ${{ github.repository == 'flutter/engine' }}
+    permissions:
+      pull-requests: write
+    runs-on: ubuntu-latest
+    steps:
+    # Source available at https://github.com/actions/labeler/blob/main/README.md
+    - uses: actions/labeler@8558fd74291d67161a8a78ce36a881fa63b766a9

.github/release.yml

@@ -0,0 +1,54 @@
+name: Scorecards supply-chain security
+on:
+  # Only the default branch is supported.
+  branch_protection_rule:
+  push:
+    branches: [ main ]
+
+# Declare default permissions as read only.
+permissions: read-all
+
+jobs:
+  scorecards:
+    name: Scorecards analysis
+    runs-on: ubuntu-latest
+    if: ${{ github.repository == 'flutter/engine' }}
+    permissions:
+      # Needed to upload the results to code-scanning dashboard.
+      security-events: write
+      actions: read
+      contents: read
+      # Needed to access OIDC token.
+      id-token: write
+    steps:
+      - name: "Checkout code"
+        uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11
+        with:
+          persist-credentials: false
+      - name: "Run analysis"
+        uses: ossf/scorecard-action@0864cf19026789058feabb7e87baa5f140aac736
+        with:
+          results_file: results.sarif
+          results_format: sarif
+          # Read-only PAT token. To create it,
+          # follow the steps in https://github.com/ossf/scorecard-action#pat-token-creation.
+          repo_token: ${{ secrets.SCORECARD_READ_TOKEN }}
+          # Publish the results to enable scorecard badges. For more details, see
+          # https://github.com/ossf/scorecard-action#publishing-results.
+          # For private repositories, `publish_results` will automatically be set to `false`,
+          # regardless of the value entered here.
+          publish_results: true
+
+      # Upload the results as artifacts (optional).
+      - name: "Upload artifact"
+        uses: actions/upload-artifact@1eb3cb2b3e0f29609092a73eb033bb759a334595
+        with:
+          name: SARIF file
+          path: results.sarif
+          retention-days: 5
+
+      # Upload the results to GitHub's code scanning dashboard.
+      - name: "Upload to code-scanning"
+        uses: github/codeql-action/upload-sarif@cdcdbb579706841c47f7063dda365e292e5cad7a
+        with:
+          sarif_file: results.sarif