use vector::push_back for simple types

Author: flar

display_list/display_list.cc

@@ -38,7 +38,7 @@ static std::vector<size_t> MakeOffsets(const DisplayListStorage& storage,
   const uint8_t* end = start + byte_count;
   const uint8_t* ptr = start;
   while (ptr < end) {
-    offsets.emplace_back(ptr - start);
+    offsets.push_back(ptr - start);
     ptr += reinterpret_cast<const DLOp*>(ptr)->size;
   }
   return offsets;
@@ -124,7 +124,7 @@ void DisplayList::RTreeResultsToIndexVector(
           // then gets reset to the value stored in the stack top
           if (info.save_was_needed) {
             FML_DCHECK(next_restore_index < offsets_.size());
-            indices.emplace_back(next_restore_index);
+            indices.push_back(next_restore_index);
           }
           next_restore_index = info.previous_restore_index;
           save_infos.pop_back();
@@ -137,20 +137,20 @@ void DisplayList::RTreeResultsToIndexVector(
     switch (GetOpCategory(op->type)) {
       case DisplayListOpCategory::kAttribute:
         // Attributes are always needed
-        indices.emplace_back(index);
+        indices.push_back(index);
         break;
 
       case DisplayListOpCategory::kTransform:
       case DisplayListOpCategory::kClip:
         if (next_render_index < next_restore_index) {
-          indices.emplace_back(index);
+          indices.push_back(index);
         }
         break;
 
       case DisplayListOpCategory::kRendering:
       case DisplayListOpCategory::kSubDisplayList:
         if (index == next_render_index) {
-          indices.emplace_back(index);
+          indices.push_back(index);
         }
         break;
 
@@ -169,7 +169,7 @@ void DisplayList::RTreeResultsToIndexVector(
             FML_UNREACHABLE();
         }
         if (needed) {
-          indices.emplace_back(index);
+          indices.push_back(index);
         }
         break;
       }
@@ -180,7 +180,7 @@ void DisplayList::RTreeResultsToIndexVector(
         SaveInfo& info = save_infos.back();
         next_restore_index = info.previous_restore_index;
         if (info.save_was_needed) {
-          indices.emplace_back(index);
+          indices.push_back(index);
         }
         save_infos.pop_back();
         break;
@@ -383,7 +383,7 @@ DisplayListOpType DisplayList::GetOpType(DlIndex index) const {
 static void FillAllIndices(std::vector<DlIndex>& indices, DlIndex size) {
   indices.reserve(size);
   for (DlIndex i = 0u; i < size; i++) {
-    indices.emplace_back(i);
+    indices.push_back(i);
   }
 }