fix nits

Author: farchond

shell/common/vsync_waiter.h

@@ -65,6 +65,7 @@ class VsyncWaiter : public std::enable_shared_from_this<VsyncWaiter> {
   // as AwaitVSync().
   virtual void AwaitVSyncForSecondaryCallback() { AwaitVSync(); }
 
+  // FireCallback() can be safely called from any thread.
   void FireCallback(fml::TimePoint frame_start_time,
                     fml::TimePoint frame_target_time,
                     bool pause_secondary_tasks = true);

shell/platform/fuchsia/flutter/vsync_waiter.cc

@@ -51,13 +51,13 @@ fml::TimePoint VsyncWaiter::SnapToNextPhase(
     const fml::TimePoint last_frame_presentation_time,
     const fml::TimeDelta presentation_interval) {
   if (presentation_interval <= fml::TimeDelta::Zero()) {
-    FML_LOG(ERROR) << "Presentation interval must be positive. The value was: "
+    FML_LOG(WARNING) << "Presentation interval must be positive. The value was: "
                    << presentation_interval.ToMilliseconds() << "ms.";
     return now;
   }
 
   if (last_frame_presentation_time >= now) {
-    FML_LOG(ERROR)
+    FML_LOG(WARNING)
         << "Last frame was presented in the future. Clamping to now.";
     return now + presentation_interval;
   }
@@ -193,7 +193,6 @@ VsyncWaiter::VsyncWaiter(SessionConnection* session_connection,
 }
 
 VsyncWaiter::~VsyncWaiter() {
-  FML_LOG(WARNING) << "~VsyncWaiter()";
   fml::AutoResetWaitableEvent ui_latch;
   fml::TaskRunner::RunNowOrPostTask(
       task_runners_.GetUITaskRunner(),

shell/platform/fuchsia/flutter/vsync_waiter.h

@@ -25,22 +25,22 @@ using LatchPointVsyncPair = std::pair<fml::TimePoint, fml::TimePoint>;
 
 class VsyncWaiter final : public flutter::VsyncWaiter {
  public:
-  static constexpr zx_signals_t SessionPresentSignal = ZX_EVENT_SIGNALED;
-  VsyncWaiter(SessionConnection* session_connection,
-              flutter::TaskRunners task_runners,
-              fml::TimeDelta vsync_offset);
-
   static FrameTargetTimes GetTargetTimes(fml::TimeDelta vsync_offset,
                                          fml::TimeDelta vsync_interval,
                                          fml::TimePoint last_targetted_vsync,
                                          fml::TimePoint now,
                                          fml::TimePoint next_vsync);
 
+
   static fml::TimePoint SnapToNextPhase(
       const fml::TimePoint now,
       const fml::TimePoint last_frame_presentation_time,
       const fml::TimeDelta presentation_interval);
 
+  VsyncWaiter(SessionConnection* session_connection,
+              flutter::TaskRunners task_runners,
+              fml::TimeDelta vsync_offset);
+
   ~VsyncWaiter() override;
 
  private: