Version 2.19.0-324.0.dev

Dart CI · Dart CI · commit 1d418b40d8bd · 2022-10-20T10:13:11.000-07:00
Merge 6e4e129 into dev
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -56,6 +56,12 @@
 
 ### Libraries
 
+#### `dart:core`
+
+- Added `copyWith` extension method on `DateTime` (see [#24644][]).
+
+[#24644]: https://github.com/dart-lang/sdk/issues/24644
+
 #### `dart:convert`
 
 - **Breaking change** [#34233][]: The previously deprecated API
diff --git a/pkg/front_end/test/extensions/data/ambiguous/lib1.dart b/pkg/front_end/test/extensions/data/ambiguous/lib1.dart
@@ -7,6 +7,7 @@
   AmbiguousExtension2,
   UnambiguousExtension1,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/ambiguous/lib2.dart b/pkg/front_end/test/extensions/data/ambiguous/lib2.dart
@@ -7,6 +7,7 @@
   AmbiguousExtension2,
   UnambiguousExtension2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/ambiguous/main.dart b/pkg/front_end/test/extensions/data/ambiguous/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   lib1.dart.AmbiguousExtension1,
diff --git a/pkg/front_end/test/extensions/data/as_show/lib.dart b/pkg/front_end/test/extensions/data/as_show/lib.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   Extension1,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/as_show/main.dart b/pkg/front_end/test/extensions/data/as_show/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   lib.dart.Extension1,
diff --git a/pkg/front_end/test/extensions/data/as_show/origin.dart b/pkg/front_end/test/extensions/data/as_show/origin.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   Extension2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/explicit_this.dart b/pkg/front_end/test/extensions/data/explicit_this.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   A2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/export_twice/lib1.dart b/pkg/front_end/test/extensions/data/export_twice/lib1.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   E,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/export_twice/lib2.dart b/pkg/front_end/test/extensions/data/export_twice/lib2.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/export_twice/main.dart b/pkg/front_end/test/extensions/data/export_twice/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   lib1.dart.E]*/
diff --git a/pkg/front_end/test/extensions/data/export_unnamed/lib.dart b/pkg/front_end/test/extensions/data/export_unnamed/lib.dart
@@ -6,6 +6,7 @@
   NamedExtension,
   _extension#1,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/export_unnamed/main.dart b/pkg/front_end/test/extensions/data/export_unnamed/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   lib.dart.NamedExtension]*/
diff --git a/pkg/front_end/test/extensions/data/extension_on_type_variable.dart b/pkg/front_end/test/extensions/data/extension_on_type_variable.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   GeneralGeneric,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/implicit_this.dart b/pkg/front_end/test/extensions/data/implicit_this.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   A2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/instance_members.dart b/pkg/front_end/test/extensions/data/instance_members.dart
@@ -6,6 +6,7 @@
   A2,
   B2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/named_declarations.dart b/pkg/front_end/test/extensions/data/named_declarations.dart
@@ -8,6 +8,7 @@
   B3,
   B4,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/other_kinds.dart b/pkg/front_end/test/extensions/data/other_kinds.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   A2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/part/main.dart b/pkg/front_end/test/extensions/data/part/main.dart
@@ -6,6 +6,7 @@
   Extension,
   _extension#1,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/patching/main.dart b/pkg/front_end/test/extensions/data/patching/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   origin.dart.Extension,
diff --git a/pkg/front_end/test/extensions/data/patching/origin.dart b/pkg/front_end/test/extensions/data/patching/origin.dart
@@ -6,6 +6,7 @@
   Extension,
   GenericExtension,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/prefix/lib1.dart b/pkg/front_end/test/extensions/data/prefix/lib1.dart
@@ -6,6 +6,7 @@
   HiddenExtension1,
   ShownExtension1,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/prefix/lib2.dart b/pkg/front_end/test/extensions/data/prefix/lib2.dart
@@ -6,6 +6,7 @@
   HiddenExtension2,
   ShownExtension2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/prefix/lib3.dart b/pkg/front_end/test/extensions/data/prefix/lib3.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   ShownExtension3,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/prefix/main.dart b/pkg/front_end/test/extensions/data/prefix/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   lib1.dart.ShownExtension1,
diff --git a/pkg/front_end/test/extensions/data/reexport/lib.dart b/pkg/front_end/test/extensions/data/reexport/lib.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/reexport/lib1.dart b/pkg/front_end/test/extensions/data/reexport/lib1.dart
@@ -6,6 +6,7 @@
   ClashingExtension,
   UniqueExtension1,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/reexport/lib2.dart b/pkg/front_end/test/extensions/data/reexport/lib2.dart
@@ -6,6 +6,7 @@
   ClashingExtension,
   UniqueExtension2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/reexport/main.dart b/pkg/front_end/test/extensions/data/reexport/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   lib1.dart.UniqueExtension1,
diff --git a/pkg/front_end/test/extensions/data/show_hide/lib1.dart b/pkg/front_end/test/extensions/data/show_hide/lib1.dart
@@ -6,6 +6,7 @@
   HiddenExtension1,
   ShownExtension1,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/show_hide/lib2.dart b/pkg/front_end/test/extensions/data/show_hide/lib2.dart
@@ -6,6 +6,7 @@
   HiddenExtension2,
   ShownExtension2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/show_hide/main.dart b/pkg/front_end/test/extensions/data/show_hide/main.dart
@@ -4,6 +4,7 @@
 
 /*library: scope=[
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName,
   lib1.dart.ShownExtension1,
diff --git a/pkg/front_end/test/extensions/data/static_members.dart b/pkg/front_end/test/extensions/data/static_members.dart
@@ -6,6 +6,7 @@
   A2,
   B2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/super.dart b/pkg/front_end/test/extensions/data/super.dart
@@ -5,6 +5,7 @@
 /*library: scope=[
   A2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/type_variables.dart b/pkg/front_end/test/extensions/data/type_variables.dart
@@ -7,6 +7,7 @@
   A3,
   A4,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/unnamed_declarations.dart b/pkg/front_end/test/extensions/data/unnamed_declarations.dart
@@ -9,6 +9,7 @@
   _extension#3,
   _extension#4,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/test/extensions/data/use_as_type.dart b/pkg/front_end/test/extensions/data/use_as_type.dart
@@ -6,6 +6,7 @@
   A2,
   B2,
   async.dart.FutureExtensions,
+  core.dart.DateTimeCopyWith,
   core.dart.EnumByName,
   core.dart.EnumName]*/
 
diff --git a/pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.expect b/pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.expect
@@ -156,6 +156,7 @@ additionalExports = (core::Deprecated,
   core::Expando,
   core::WeakReference,
   core::Finalizer,
+  core::DateTimeCopyWith,
   core::EnumName,
   core::EnumByName,
   core::identical,
diff --git a/pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.outline.expect b/pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.outline.expect
@@ -91,6 +91,7 @@ additionalExports = (core::Deprecated,
   core::Expando,
   core::WeakReference,
   core::Finalizer,
+  core::DateTimeCopyWith,
   core::EnumName,
   core::EnumByName,
   core::identical,
diff --git a/pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.transformed.expect b/pkg/front_end/testcases/general/error_export_from_dill/main.dart.weak.transformed.expect
@@ -152,6 +152,7 @@ additionalExports = (core::Deprecated,
   core::Expando,
   core::WeakReference,
   core::Finalizer,
+  core::DateTimeCopyWith,
   core::EnumName,
   core::EnumByName,
   core::identical,
diff --git a/pkg/front_end/testcases/incremental/export_core.yaml.world.2.expect b/pkg/front_end/testcases/incremental/export_core.yaml.world.2.expect
@@ -21,6 +21,7 @@ additionalExports = (asy::Future,
   core::ConcurrentModificationError,
   core::CyclicInitializationError,
   core::DateTime,
+  core::DateTimeCopyWith,
   core::Deprecated,
   core::Duration,
   core::Enum,
diff --git a/pkg/front_end/testcases/incremental/export_core.yaml.world.3.expect b/pkg/front_end/testcases/incremental/export_core.yaml.world.3.expect
@@ -21,6 +21,7 @@ additionalExports = (asy::Future,
   core::ConcurrentModificationError,
   core::CyclicInitializationError,
   core::DateTime,
+  core::DateTimeCopyWith,
   core::Deprecated,
   core::Duration,
   core::Enum,
diff --git a/sdk/lib/core/date_time.dart b/sdk/lib/core/date_time.dart
@@ -873,3 +873,58 @@ class DateTime implements Comparable<DateTime> {
           r'(?:[ T](\d\d)(?::?(\d\d)(?::?(\d\d)(?:[.,](\d+))?)?)?' // Time part.
           r'( ?[zZ]| ?([-+])(\d\d)(?::?(\d\d))?)?)?$'); // Timezone part.
 }
+
+/// Adds [copyWith] method to [DateTime] objects.
+@Since("2.19")
+extension DateTimeCopyWith on DateTime {
+  /// Creates a new [DateTime] from this one by updating individual properties.
+  ///
+  /// The [copyWith] method creates a new [DateTime] object with values
+  /// for the properties [DateTime.year], [DateTime.hour], etc, provided by
+  /// similarly named arguments, or using the existing value of the property
+  /// if no argument, or `null`, is provided.
+  ///
+  /// Example:
+  /// ```dart
+  /// final now = DateTime.now();
+  /// final sameTimeOnMoonLandingDay =
+  ///     now.copyWith(year: 1969, month: 07, day: 20);
+  /// ```
+  ///
+  /// Like for the [DateTime] and [DateTime.utc] constructors,
+  /// which this operation uses to create the new value,
+  /// property values are allowed to overflow or underflow the range
+  /// of the property (like a [month] outside the 1 to 12 range),
+  /// which can affect the more significant properties
+  /// (for example, a month of 13 will result in the month of January
+  /// of the next year.)
+  ///
+  /// Notice also that if the result is a local-time DateTime,
+  /// seasonal time-zone adjustments (daylight saving) can cause some
+  /// combinations of dates, hours and minutes to not exist, or to exist
+  /// more than once.
+  /// In the former case, a corresponding time in one of the two adjacent time
+  /// zones is used instead. In the latter, one of the two options is chosen.
+  DateTime copyWith({
+    int? year,
+    int? month,
+    int? day,
+    int? hour,
+    int? minute,
+    int? second,
+    int? millisecond,
+    int? microsecond,
+    bool? isUtc,
+  }) {
+    return ((isUtc ?? this.isUtc) ? DateTime.utc : DateTime.new)(
+      year ?? this.year,
+      month ?? this.month,
+      day ?? this.day,
+      hour ?? this.hour,
+      minute ?? this.minute,
+      second ?? this.second,
+      millisecond ?? this.millisecond,
+      microsecond ?? this.microsecond,
+    );
+  }
+}
diff --git a/tests/corelib/date_time_copy_with_test.dart b/tests/corelib/date_time_copy_with_test.dart
diff --git a/tests/corelib_2/date_time_copy_with_test.dart b/tests/corelib_2/date_time_copy_with_test.dart
diff --git a/tools/VERSION b/tools/VERSION
